From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31396 invoked by alias); 15 Sep 2010 09:57:42 -0000 Received: (qmail 31387 invoked by uid 22791); 15 Sep 2010 09:57:41 -0000 X-SWARE-Spam-Status: No, hits=-1.2 required=5.0 tests=AWL,BAYES_00,MSGID_MULTIPLE_AT,TW_SN X-Spam-Check-By: sourceware.org Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.200.151) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 15 Sep 2010 09:57:36 +0000 Received: from md2.u-strasbg.fr (md2.u-strasbg.fr [IPv6:2001:660:2402::187]) by mailhost.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id o8F9vMwD054708 ; Wed, 15 Sep 2010 11:57:22 +0200 (CEST) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from mailserver.u-strasbg.fr (ms3.u-strasbg.fr [IPv6:2001:660:2402:d::12]) by md2.u-strasbg.fr (8.14.4/jtpda-5.5pre1) with ESMTP id o8F9vLXO020707 ; Wed, 15 Sep 2010 11:57:21 +0200 (CEST) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from d620muller (gw-ics.u-strasbg.fr [130.79.210.225]) (user=mullerp mech=LOGIN) by mailserver.u-strasbg.fr (8.14.4/jtpda-5.5pre1) with ESMTP id o8F9vKKq068652 (version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NO) ; Wed, 15 Sep 2010 11:57:20 +0200 (CEST) (envelope-from pierre.muller@ics-cnrs.unistra.fr) From: "Pierre Muller" To: "'Tom Tromey'" Cc: References: <20100731162500.32FAE5664F4@henry1.codesourcery.com> <20100817184407.GC3599@adacore.com> <20100818101406.GA2903@adacore.com> <15264.6257346079$1282142643@news.gmane.org> <004b01cb3faf$b07ed580$117c8080$@muller@ics-cnrs.unistra.fr> <001b01cb48ee$6b8425f0$428c71d0$@muller@ics-cnrs.unistra.fr> <44796.6229789474$1283326243@news.gmane.org> <000301cb4aa0$7c44fd70$74cef850$@muller@ics-cnrs.unistra.fr> In-Reply-To: Subject: RE: Your INTERMEDIATE_ENCODING patch for Solaris Date: Wed, 15 Sep 2010 17:20:00 -0000 Message-ID: <002301cb54bc$661506f0$323f14d0$@muller@ics-cnrs.unistra.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-09/txt/msg00287.txt.bz2 > -----Message d'origine----- > De=A0: gdb-patches-owner@sourceware.org [mailto:gdb-patches- > owner@sourceware.org] De la part de Tom Tromey > Envoy=E9=A0: Tuesday, September 14, 2010 10:57 PM > =C0=A0: Pierre Muller > Cc=A0: gdb-patches@sourceware.org > Objet=A0: Re: Your INTERMEDIATE_ENCODING patch for Solaris >=20 > >>>>> "Tom" =3D=3D Tom Tromey writes: >=20 > Pierre> Probably just define PHONY_ICONV if the first set of conditions > is > Pierre> not met (by the way, I am not sure the libiconv version test > Pierre> that we added is really pertinent.) >=20 > Tom> Thanks. I think I got the logic wrong: >=20 > Tom> +/* If we got here and have wchar_t support, we might be on a > system > Tom> + with some problem. So, we just disable everything. */ > Tom> +#if !(defined (HAVE_WCHAR_H) && defined (HAVE_BTOWC)) > Tom> +#define PHONY_ICONV > Tom> +#endif >=20 > Tom> I think that "!" is wrong -- it even contradicts the comment. > Tom> I'm sorry to keep bothering you about this, but could you remove > that > Tom> "!" and try again? >=20 > Any word on this? > I would like to commit this patch if it seems ok. I can at least confirm that for Sparc OpenSolaris 5.11 snv_111b it does disable use of iconv functions from libc.so.1 So, at least for me, this should be modified that way.=20 Pierre