From: "Pierre Muller" <pierre.muller@ics-cnrs.unistra.fr>
To: "'Pierre Muller'" <pierre.muller@ics-cnrs.unistra.fr>,
"'Pedro Alves'" <palves@redhat.com>
Cc: "'gdb-patches'" <gdb-patches@sourceware.org>
Subject: [RFA PATCH 1/3 V4] Remember the case pattern that allowed finding a field of this.
Date: Wed, 04 Feb 2015 23:37:00 -0000 [thread overview]
Message-ID: <003001d040d3$7746f340$65d4d9c0$@muller@ics-cnrs.unistra.fr> (raw)
In-Reply-To: <002f01d036a3$456c29b0$d0447d10$@muller@ics-cnrs.unistra.fr>
This is the fix in the pascal parser (p-exp.y),
to avoid the error that GDB does find normal variables
case insensitively, but not fields of this,
inside a class or object method.
gdb/ChangeLog entry:
2015-02-04 Pierre Muller <muller@sourceware.org>
* p-exp.y (yylex): Reorganize code to return the matched pattern
for a field of this.
---
gdb/p-exp.y | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/gdb/p-exp.y b/gdb/p-exp.y
index a1c78bf..101de09 100644
--- a/gdb/p-exp.y
+++ b/gdb/p-exp.y
@@ -1551,7 +1551,7 @@ yylex (void)
int is_a_field = 0;
int hextype;
-
+ is_a_field_of_this.type = NULL;
if (search_field && current_type)
is_a_field = (lookup_struct_elt_type (current_type, tmp, 1) != NULL);
if (is_a_field)
@@ -1598,15 +1598,20 @@ yylex (void)
VAR_DOMAIN, &is_a_field_of_this);
}
- if (is_a_field)
+ if (is_a_field || (is_a_field_of_this.type != NULL))
{
tempbuf = (char *) realloc (tempbuf, namelen + 1);
strncpy (tempbuf, tmp, namelen);
tempbuf [namelen] = 0;
yylval.sval.ptr = tempbuf;
yylval.sval.length = namelen;
+ yylval.ssym.sym = NULL;
free (uptokstart);
- return FIELDNAME;
+ yylval.ssym.is_a_field_of_this = is_a_field_of_this.type != NULL;
+ if (is_a_field)
+ return FIELDNAME;
+ else
+ return NAME;
}
/* Call lookup_symtab, not lookup_partial_symtab, in case there are
no psymtabs (coff, xcoff, or some future change to blow away the
@@ -1739,7 +1744,6 @@ yylex (void)
free(uptokstart);
/* Any other kind of symbol. */
yylval.ssym.sym = sym;
- yylval.ssym.is_a_field_of_this = is_a_field_of_this.type != NULL;
return NAME;
}
}
--
2.1.4
next prev parent reply other threads:[~2015-02-04 23:37 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <54ae4586.01e3440a.7b06.fffff844SMTPIN_ADDED_BROKEN@mx.google.com>
2015-01-08 10:48 ` [RFA] Fix pascal behavior for class fields Pedro Alves
2015-01-08 13:01 ` Pierre Muller
[not found] ` <54ae7f9f.c323460a.36ed.ffffff30SMTPIN_ADDED_BROKEN@mx.google.com>
2015-01-08 13:41 ` Pedro Alves
2015-01-08 14:15 ` gdb-patches RFA: " Pierre Muller
[not found] ` <54ae911b.85e3440a.1d96.5ffdSMTPIN_ADDED_BROKEN@mx.google.com>
2015-01-09 10:52 ` Pedro Alves
2015-01-09 10:55 ` Pedro Alves
2015-01-09 16:16 ` [RFA PATCH 1/3] Remember the case pattern that allowed finding a field of this Pierre Muller
2015-01-23 7:30 ` [RFA PATCH 1/3 V3] " Pierre Muller
2015-02-04 23:37 ` Pierre Muller [this message]
2015-01-09 16:16 ` [RFA 0/3] Fix pascal behavior for class fields with testcase Pierre Muller
2015-01-09 16:18 ` [RFA PATCH 2/3] Add debug-stabs debug-dwarf and class option for pascal compiler Pierre Muller
2015-02-04 23:37 ` [RFA 0/3 V4] Fix pascal behavior for class fields with testcase Pierre Muller
2015-02-15 6:59 ` PING " Pierre Muller
2015-04-07 20:06 ` PING^2 " Pierre Muller
[not found] ` <54e043b2.626ec20a.0c59.ffffaeacSMTPIN_ADDED_BROKEN@mx.google.com>
2015-04-20 6:00 ` PING " Doug Evans
2015-04-21 20:33 ` Pierre Muller
2015-01-09 16:18 ` [RFA PATCH 3/3] Testcase for pascal/17815 Pierre Muller
[not found] ` <54afff61.6790420a.0fa7.4f63SMTPIN_ADDED_BROKEN@mx.google.com>
2015-01-10 0:45 ` [RFA PATCH 2/3] Add debug-stabs debug-dwarf and class option for pascal compiler Doug Evans
2015-01-10 0:55 ` Pierre Muller
[not found] ` <54b07891.01b3c20a.2a7b.ffff9f96SMTPIN_ADDED_BROKEN@mx.google.com>
2015-01-10 21:23 ` Doug Evans
2015-01-14 15:04 ` [RFA PATCH 2/3 V2] Add "class" " Pierre Muller
[not found] ` <54b6858f.a287440a.5b61.ffff9ef0SMTPIN_ADDED_BROKEN@mx.google.com>
2015-01-22 12:49 ` Pedro Alves
2015-01-23 5:21 ` [RFA PATCH 2/3 V3] " Pierre Muller
2015-01-23 11:55 ` Pedro Alves
2015-02-04 23:37 ` [RFA PATCH 2/3 V4] " Pierre Muller
[not found] ` <54afff6b.ee8d440a.16ee.ffffb424SMTPIN_ADDED_BROKEN@mx.google.com>
2015-01-22 12:46 ` [RFA PATCH 3/3] Testcase for pascal/17815 Pedro Alves
2015-01-23 7:16 ` [RFA PATCH 3/3 V3] " Pierre Muller
2015-01-23 12:29 ` Pedro Alves
2015-02-04 23:37 ` [RFA PATCH 3/3 V4] " Pierre Muller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='003001d040d3$7746f340$65d4d9c0$@muller@ics-cnrs.unistra.fr' \
--to=pierre.muller@ics-cnrs.unistra.fr \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).