From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12259 invoked by alias); 14 Jul 2014 16:25:06 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 12193 invoked by uid 89); 14 Jul 2014 16:25:06 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.6 required=5.0 tests=AWL,BAYES_00,MSGID_MULTIPLE_AT autolearn=no version=3.3.2 X-HELO: mailhost.u-strasbg.fr Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.222.218) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 14 Jul 2014 16:25:04 +0000 Received: from mailhost.u-strasbg.fr (localhost [127.0.0.1]) by antispam (Postfix) with ESMTP id 682AE221616; Mon, 14 Jul 2014 18:25:01 +0200 (CEST) Received: from mailhost.u-strasbg.fr (localhost [127.0.0.1]) by antivirus (Postfix) with ESMTP id 58070221648; Mon, 14 Jul 2014 18:25:01 +0200 (CEST) Received: from md15.u-strasbg.fr (md15.u-strasbg.fr [130.79.200.204]) by mr8.u-strasbg.fr (Postfix) with ESMTP id 3E1F6221616; Mon, 14 Jul 2014 18:24:49 +0200 (CEST) Received: from ms13.u-strasbg.fr (ms13.u-strasbg.fr [130.79.204.113]) by md15.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id s6EGOlYG014522 ; Mon, 14 Jul 2014 18:24:48 +0200 (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from E6510Muller (lec67-4-82-230-53-140.fbx.proxad.net [82.230.53.140]) (Authenticated sender: mullerp) by ms13.u-strasbg.fr (Postfix) with ESMTPSA id 813D51FD76; Mon, 14 Jul 2014 18:24:36 +0200 (CEST) From: "Pierre Muller" To: "'Gary Benson'" , "'Andreas Schwab'" Cc: , "'Andrew Burgess'" , "'Doug Evans'" , "'Eli Zaretskii'" , "'Florian Weimer'" , "'Mark Kettenis'" , "'Pedro Alves'" , "'Tom Tromey'" , "'Corinna Vinschen'" References: <20140609152229.GA27494@blade.nx> <20140609152434.GD27494@blade.nx> <000901cf9eb5$16841da0$438c58e0$@muller@ics-cnrs.unistra.fr> <20140714085154.GA27730@blade.nx> <20140714114241.GA31867@blade.nx> In-Reply-To: <20140714114241.GA31867@blade.nx> Subject: RE: Cygwin build failure following [PATCH 3/3 v5] Demangler crash handler Date: Mon, 14 Jul 2014 17:52:00 -0000 Message-ID: <003201cf9f80$21997890$64cc69b0$@muller@ics-cnrs.unistra.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable X-SW-Source: 2014-07/txt/msg00344.txt.bz2 > -----Message d'origine----- > De=A0: gdb-patches-owner@sourceware.org [mailto:gdb-patches- > owner@sourceware.org] De la part de Gary Benson > Envoy=E9=A0: lundi 14 juillet 2014 13:43 > =C0=A0: Andreas Schwab > Cc=A0: Pierre Muller; gdb-patches@sourceware.org; 'Andrew Burgess'; 'Doug > Evans'; 'Eli Zaretskii'; 'Florian Weimer'; 'Mark Kettenis'; 'Pedro > Alves'; 'Tom Tromey'; 'Corinna Vinschen' > Objet=A0: Re: Cygwin build failure following [PATCH 3/3 v5] Demangler > crash handler >=20 > Andreas Schwab wrote: > > Gary Benson writes: > > > diff --git a/gdb/cp-support.c b/gdb/cp-support.c > > > index a8ea6fc..6a09b46 100644 > > > --- a/gdb/cp-support.c > > > +++ b/gdb/cp-support.c > > > @@ -1557,7 +1557,9 @@ gdb_demangle (const char *name, int options) > > > #if defined (HAVE_SIGACTION) && defined (SA_RESTART) > > > sa.sa_handler =3D gdb_demangle_signal_handler; > > > sigemptyset (&sa.sa_mask); > > > +#ifdef HAVE_SIGALTSTACK > > > sa.sa_flags =3D SA_ONSTACK; > > > +#endif > > > > You probably need to initialize sa.sa_flags in any case. >=20 > Good spot, thanks Andreas. >=20 > Pierre, I've inlined an updated patch below. I can confirm that the proposed patch fixes the Cygwin build failure. Thanks, Gary, Pierre Muller =20