From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28051 invoked by alias); 15 Dec 2017 11:02:38 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 28038 invoked by uid 89); 15 Dec 2017 11:02:37 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 spammy=xmas, woke X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 15 Dec 2017 11:02:36 +0000 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id F1C6C7E426; Fri, 15 Dec 2017 11:02:34 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 247C26FEE8; Fri, 15 Dec 2017 11:02:33 +0000 (UTC) Subject: Re: [RFC] regresssion(internal-error) printing subprogram argument To: Joel Brobecker References: <20171213103655.msbaxfrykc36f4a7@adacore.com> <20171215094755.dwocipbcwvtdm6f6@adacore.com> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: <00320239-44c8-b9c3-013b-b27c771e3401@redhat.com> Date: Fri, 15 Dec 2017 11:02:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20171215094755.dwocipbcwvtdm6f6@adacore.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-12/txt/msg00372.txt.bz2 Hi Joel, I woke up realizing that I completely forgot that psymbols have no overload/function parameter info in C++, so a straight strcmp probably doesn't work properly for C++. Indeed, I remembered now to do "maint check-psymtabs" when debugging gdb, and I get back a few problems: (top-gdb) maint check-psymtabs Global symbol `__gnu_cxx::operator!= >' only found in src/gdb/cli/cli-cmds.c psymtab Global symbol `__gnu_cxx::operator- >' only found in src/gdb/cli/cli-cmds.c psymtab [...] Maybe what we need is to be a little less aggressive then and add a new symbol_name_match_type::SEARCH_SYMBOL instead that takes as input a non-user-input search symbol like symbol_name_match_type::LITERAL was, and then we skip any decoding/demangling steps (like LITERAL) and make: - Ada treat that as a verbatim match, - other languages treat it as symbol_name_match_type::FULL. I can't look at this right now, though I'll try to play with it a bit more later today. I'm a bit worried on timing since I'm going to be away next week (today's my last official day before xmas holiday). :-/ No idea offhand on the issue below. Thanks, Pedro Alves On 12/15/2017 09:47 AM, Joel Brobecker wrote: >> Reading back the patch on the list, I realized that this must be >> fixing "maint check-psymtabs" for Ada. And indeed, without my >> patch, I get here: >> >> $ gdb ./testsuite/outputs/gdb.ada/var_arr_typedef/var_arr_typedef >> (gdb) start >> ... >> (gdb) maint check-psymtabs >> Global symbol `adaS' only found in gdb/testsuite/outputs/gdb.ada/var_arr_typedef/b~var_arr_typedef.adb psymtab >> Global symbol `interfacesS' only found in gdb/testsuite/outputs/gdb.ada/var_arr_typedef/b~var_arr_typedef.adb psymtab >> Global symbol `packB' only found in gdb/testsuite/outputs/gdb.ada/var_arr_typedef/b~var_arr_typedef.adb psymtab >> Global symbol `packS' only found in gdb/testsuite/outputs/gdb.ada/var_arr_typedef/b~var_arr_typedef.adb psymtab >> Global symbol `systemS' only found in gdb/testsuite/outputs/gdb.ada/var_arr_typedef/b~var_arr_typedef.adb psymtab >> Global symbol `var_arr_typedefB' only found in gdb/testsuite/outputs/gdb.ada/var_arr_typedef/b~var_arr_typedef.adb psymtab >> (gdb) >> >> After: >> >> (gdb) start >> ... >> (gdb) maint check-psymtabs >> (gdb >> >> Looks like we only test that command for C, currently... > > Good point! > > Here is a commit which adds a testcase. > > Sadly, unlike you, I still get an error: > > (gdb) maintenance check-psymtabs > Global symbol `interfaces__cS' only found in /[...]/maint_with_ada/b~var_arr_typedef.adb psymtab > > I am not sure why this is happening just yet; the symbol, at first, > looked like it had an interesting feature, which is both a DW_AT_name > and a DW_AT_linkage name: > > <1>: Abbrev Number: 35 (DW_TAG_variable) > DW_AT_name : (indirect string, offset: 0x476): ada_main__u00047 > DW_AT_decl_file : 5 > DW_AT_decl_line : 132 > DW_AT_linkage_name: (indirect string, offset: 0x1b7e): interfaces__cS > DW_AT_type : <0x79> > DW_AT_external : 1 > DW_AT_location : 9 byte block: 3 20 1 0 0 0 0 0 0 (DW_OP_addr: 120) > > However, there are plenty of other similar symbols, for instance: > > <1>: Abbrev Number: 35 (DW_TAG_variable) > DW_AT_name : (indirect string, offset: 0x4b9): ada_main__u00049 > DW_AT_decl_file : 5 > DW_AT_decl_line : 136 > DW_AT_linkage_name: (indirect string, offset: 0x17cc): system__bounded_stringsS > DW_AT_type : <0x79> > DW_AT_external : 1 > DW_AT_location : 9 byte block: 3 28 1 0 0 0 0 0 0 (DW_OP_addr: 128) > > So I'm still not sure what makes interfaces__cS special. I will look > into it when I have a chance... >