RE: [RFC 3/6] mingw-hdep: Add "maint set testuite-mode on/off" command.

["Pierre Muller" <pierre.muller@ics-cnrs.unistra.fr>]

> -----Message d'origine-----
> De : gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] De la part de Eli Zaretskii
> Envoyé : vendredi 27 septembre 2013 07:52
> À : Pierre Muller
> Cc : gdb-patches@sourceware.org
> Objet : Re: [RFC 3/6] mingw-hdep: Add "maint set testuite-mode on/off"
> command.
> 
> > From: "Pierre Muller" <pierre.muller@ics-cnrs.unistra.fr>
> > Cc: <gdb-patches@sourceware.org>
> > Date: Thu, 26 Sep 2013 22:13:47 +0200
> >
> > > Shouldn't this command be supported on all platforms, and be a no-op
> > > on all of them but MinGW?  Otherwise the test suite will fail for
> > > tests that use this setting, won't it?
> >
> >   Yes, this is indeed a possibility,
> > but I think that I suggested this already some time ago,
> > and that the feedback was not very positive...
> >
> >   Anyhow, take a look at part 4 of the patch series,
> > which adds "-iex {maint set testsuite-mode on}" to GDBINTERNALFLAGS
> > if, and only if, the host is *-*-mingw*.
> >   This should avoid the problem you raise, no?
> 
> Yes, but it puts the burden of remembering that on the person who
> writes the test, which IMO is sub-optimal.

  Hi Eli,

  I don't think so,
this is added at the parsing of lib/gdb.exp,
which means that the additional parameters are automatically
used for all tests if my patch number 4 is correct...

  I must confess that I am still a little bit confused about the subtle
differences
that seem to exist between target, host and build
in the runtest meaning versus the GDB makefiles meaning.

  Example:
  in src/gdb/testsuite,
when I run the tesuite using cygwin environment
for a x86_64-w65-mingw32 host GDB, the
x86_64-w64-mingw32- prefix for the compilers are not passed to the
testsuite,
because they expect that runtest will be run on host, which is the same as
target...
But here we still run dejagnu on build system (cygwin),
and thus runtest uses gcc (cygwin version) instead of x86_64-w64-mingw32-gcc
executable
which of course leads to lots of errors...
  This is why overriding CC_FOR_TARGET and friends is also required to
correctly run
ming host testsuite on cygwin environment.

  I don't know if there is a way to correctly fix this...
especially as host could also be a remote system, that only has mingw
environment,
in such a case, the settings would be correct.

Pierre Muller