From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4454 invoked by alias); 27 Sep 2013 06:53:38 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 4440 invoked by uid 89); 27 Sep 2013 06:53:37 -0000 Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.222.212) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 27 Sep 2013 06:53:37 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=3.4 required=5.0 tests=AWL,BAYES_50,MSGID_MULTIPLE_AT,SPAM_SUBJECT autolearn=no version=3.3.2 X-HELO: mailhost.u-strasbg.fr Received: from mailhost.u-strasbg.fr (localhost [127.0.0.1]) by antispam (Postfix) with ESMTP id 9CC59141209; Fri, 27 Sep 2013 08:53:33 +0200 (CEST) Received: from mailhost.u-strasbg.fr (localhost [127.0.0.1]) by antivirus (Postfix) with ESMTP id 8D47D141238; Fri, 27 Sep 2013 08:53:33 +0200 (CEST) Received: from md14.u-strasbg.fr (md14.u-strasbg.fr [130.79.200.249]) by mr2.u-strasbg.fr (Postfix) with ESMTP id 5E73C141209; Fri, 27 Sep 2013 08:53:31 +0200 (CEST) Received: from ms17.u-strasbg.fr (ms17.u-strasbg.fr [130.79.204.117]) by md14.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id r8R6rVj5018392 ; Fri, 27 Sep 2013 08:53:31 +0200 Received: from E6510Muller (lec67-4-82-230-53-140.fbx.proxad.net [82.230.53.140]) (Authenticated sender: mullerp) by ms17.u-strasbg.fr (Postfix) with ESMTPSA id 9D1C41FD95; Fri, 27 Sep 2013 08:53:29 +0200 (CEST) From: "Pierre Muller" To: "'Eli Zaretskii'" Cc: References: <"002901cebaf2$35ec65a0$a1c530e0$@muller"@ics-cnrs.unistra.fr> <"003201cebaf3$338a8b60$9a9fa220$@muller"@ics-cnrs.unistra.fr> <83li2jfis1.fsf@gnu.org> <"003e01cebaf4$e97923e0$bc6b6ba0$@muller"@ics-cnrs.unistra.fr> <83k3i2g6aq.fsf@gnu.org> In-Reply-To: <83k3i2g6aq.fsf@gnu.org> Subject: RE: [RFC 3/6] mingw-hdep: Add "maint set testuite-mode on/off" command. Date: Fri, 27 Sep 2013 06:53:00 -0000 Message-ID: <003c01cebb4e$454e5dd0$cfeb1970$@muller@ics-cnrs.unistra.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable X-SW-Source: 2013-09/txt/msg00949.txt.bz2 > -----Message d'origine----- > De=A0: gdb-patches-owner@sourceware.org [mailto:gdb-patches- > owner@sourceware.org] De la part de Eli Zaretskii > Envoy=E9=A0: vendredi 27 septembre 2013 07:52 > =C0=A0: Pierre Muller > Cc=A0: gdb-patches@sourceware.org > Objet=A0: Re: [RFC 3/6] mingw-hdep: Add "maint set testuite-mode on/off" > command. >=20 > > From: "Pierre Muller" > > Cc: > > Date: Thu, 26 Sep 2013 22:13:47 +0200 > > > > > Shouldn't this command be supported on all platforms, and be a no-op > > > on all of them but MinGW? Otherwise the test suite will fail for > > > tests that use this setting, won't it? > > > > Yes, this is indeed a possibility, > > but I think that I suggested this already some time ago, > > and that the feedback was not very positive... > > > > Anyhow, take a look at part 4 of the patch series, > > which adds "-iex {maint set testsuite-mode on}" to GDBINTERNALFLAGS > > if, and only if, the host is *-*-mingw*. > > This should avoid the problem you raise, no? >=20 > Yes, but it puts the burden of remembering that on the person who > writes the test, which IMO is sub-optimal. Hi Eli, I don't think so, this is added at the parsing of lib/gdb.exp, which means that the additional parameters are automatically used for all tests if my patch number 4 is correct... I must confess that I am still a little bit confused about the subtle differences that seem to exist between target, host and build in the runtest meaning versus the GDB makefiles meaning. Example: in src/gdb/testsuite, when I run the tesuite using cygwin environment for a x86_64-w65-mingw32 host GDB, the x86_64-w64-mingw32- prefix for the compilers are not passed to the testsuite, because they expect that runtest will be run on host, which is the same as target... But here we still run dejagnu on build system (cygwin), and thus runtest uses gcc (cygwin version) instead of x86_64-w64-mingw32-gcc executable which of course leads to lots of errors... This is why overriding CC_FOR_TARGET and friends is also required to correctly run ming host testsuite on cygwin environment. I don't know if there is a way to correctly fix this... especially as host could also be a remote system, that only has mingw environment, in such a case, the settings would be correct. Pierre Muller