From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28397 invoked by alias); 19 Aug 2010 15:03:48 -0000 Received: (qmail 28236 invoked by uid 22791); 19 Aug 2010 15:03:46 -0000 X-SWARE-Spam-Status: No, hits=-1.1 required=5.0 tests=AWL,BAYES_00,MSGID_MULTIPLE_AT X-Spam-Check-By: sourceware.org Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.200.155) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 19 Aug 2010 15:03:41 +0000 Received: from baal.u-strasbg.fr (baal.u-strasbg.fr [IPv6:2001:660:2402::41]) by mailhost.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id o7JF3P4j016357 ; Thu, 19 Aug 2010 17:03:25 +0200 (CEST) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from mailserver.u-strasbg.fr (ms5.u-strasbg.fr [IPv6:2001:660:2402:d::14]) by baal.u-strasbg.fr (8.14.0/jtpda-5.5pre1) with ESMTP id o7JF3Nn8098431 ; Thu, 19 Aug 2010 17:03:24 +0200 (CEST) (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from d620muller (gw-ics.u-strasbg.fr [130.79.210.225]) (user=mullerp mech=LOGIN) by mailserver.u-strasbg.fr (8.14.4/jtpda-5.5pre1) with ESMTP id o7JF3Mb7079256 (version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NO) ; Thu, 19 Aug 2010 17:03:23 +0200 (CEST) (envelope-from pierre.muller@ics-cnrs.unistra.fr) From: "Pierre Muller" To: "'Tom Tromey'" Cc: References: <20100731162500.32FAE5664F4@henry1.codesourcery.com> <20100817184407.GC3599@adacore.com> <20100818101406.GA2903@adacore.com> <15264.6257346079$1282142643@news.gmane.org> In-Reply-To: Subject: RE: Your INTERMEDIATE_ENCODING patch for Solaris Date: Thu, 19 Aug 2010 15:03:00 -0000 Message-ID: <004b01cb3faf$b07ed580$117c8080$@muller@ics-cnrs.unistra.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-08/txt/msg00337.txt.bz2 Hi Tom, I think your patch still has a problem: if I have a system (like my i386 open solaris) that only has the libc iconv functions, but no libiconv) The libc headers do not set __STDC_ISO_10646__=20 nor defined _LIBICONV_VERSION macro. Thus we do not know how to handle those iconv functions. I think that we should simply ignore them by defining PHONY_ICONV in such c= ases. The problem is then that we already loaded libc iconv.h header which then leads to an error of conflicting types for iconv definition. This probably means that the check that in done inside gdb_wchar.h should= be changed into a configuration macro, something like HAVE_USABLE_ICONV. Pierre PS: libc iconv on Solaris seems to work more or less, but it doesn't like 'ASCII' charset (don't know why..) but code in _initialize_charset does transform '646' into 'ASCII' which is bad. If LANG is set to en_US.UTF-8 for instance, the 'print version' works. So changing the '646' -> 'ASCII' into a '646' -> 'UTF-8'=20 would also improve things for solaris, but I have no idea if this would also affect Non Solaris hosts. =20=20 PS2: what about being able to disable iconv at configure level with --disable-iconv that would skip iconv checks and thus lead to PHONY_ICONV?