[RFA- v3] Testcase for bug report 11531 and fix for Solaris

["Pierre Muller" <pierre.muller@ics-cnrs.unistra.fr>]

  Following Pedro's and Joel's comments
I simplified my test for bug report 11531
and used Joel's comment about the use of 
'delete_breakpoints' command.

I made the test to also succeed in case a software
watchpoint is used.

  Is this OK?

Pierre

2010-04-24  Pierre Muller  <muller@ics.u-strasbg.fr>

	PR breakpoints/11531.
	* testsuite/gdb.base/gdb11531.c: New file.
	* testsuite/gdb.base/gdb11531.exp: New file.

Index: testsuite/gdb.base/gdb11531.c
===================================================================
RCS file: testsuite/gdb.base/gdb11531.c
diff -N testsuite/gdb.base/gdb11531.c
--- /dev/null	1 Jan 1970 00:00:00 -0000
+++ testsuite/gdb.base/gdb11531.c	26 Apr 2010 11:19:43 -0000
@@ -0,0 +1,40 @@
+/* This testcase is part of GDB, the GNU debugger.
+
+   Copyright 2010 Free Software Foundation, Inc.
+
+   Contributed by Pierre Muller.
+
+   This program is free software; you can redistribute it and/or modify
+   it under the terms of the GNU General Public License as published by
+   the Free Software Foundation; either version 3 of the License, or
+   (at your option) any later version.
+
+   This program is distributed in the hope that it will be useful,
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+   GNU General Public License for more details.
+
+   You should have received a copy of the GNU General Public License
+   along with this program.  If not, see <http://www.gnu.org/licenses/>.
+
+   Test for Solaris specific watchpoint problem.  */
+
+struct rec
+{
+ int x;
+ double y;
+ int z;
+};
+
+static struct rec myrec;
+
+int
+main ()
+{
+  myrec.x = 5;
+  myrec.y = 3.4;
+  myrec.z = 56;
+  myrec.x = 78;
+  return myrec.x;
+}
+
Index: testsuite/gdb.base/gdb11531.exp
===================================================================
RCS file: testsuite/gdb.base/gdb11531.exp
diff -N testsuite/gdb.base/gdb11531.exp
--- /dev/null	1 Jan 1970 00:00:00 -0000
+++ testsuite/gdb.base/gdb11531.exp	26 Apr 2010 11:19:43 -0000
@@ -0,0 +1,64 @@
+# This testcase is part of GDB, the GNU debugger.
+
+# Copyright 2010 Free Software Foundation, Inc.
+
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 3 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+
+# Test GDB ibug report 11531.
+# This is a problem related to CANNOT_STEP_HW_WATCHPOINTS macro.
+# It affects Solaris native targets.
+
+if $tracelevel then {
+	strace $tracelevel
+}
+
+set prms_id 0
+set bug_id 0
+
+set testfile "gdb11531"
+
+if { [prepare_for_testing $testfile.exp $testfile $testfile.c {debug}] } {
+    return -1;
+}
+
+
+if { ![runto main] } then {
+    fail "run to main"
+    return
+}
+
+# The breakpoint is probably at the instruction where the value being
+# watched (myrec.x) gets updated.  This is the instruction where we
+# expect to receive a watchpoint notification when we do the "stepi"
+# below.  However, having the breakpoint at the same location as this
+# intruction can possibly interfere with our testcase, as stepping
+# over the breakpoint in order to get past it may incorrectly lead
+# to the debugger missing the watchpoint hit.  This would be a bug
+# in GDB, but this is not the bug that we are trying to test here.
+# So, we remove all breakpoints first.
+
+delete_breakpoints
+
+set nl "\[\r\n\]+"
+
+gdb_test "watch myrec.x" ".*atchpoint \[0-9\]+: myrec\.x" "Set watchpoint"
+
+gdb_test "next" \
+    ".*${nl}.*atchpoint \[0-9\]+: myrec\.x${nl}Old value = 0${nl}New value
= 5${nl}.*" \
+    "watchpoint variable triggers at next"
+
+gdb_test "continue" \
+    ".*${nl}.*atchpoint \[0-9\]+: myrec\.x${nl}Old value = 5${nl}New value
= 78${nl}.*" \
+    "watchpoint variable triggers at continue"
+