From: Simon Marchi <simark@simark.ca>
To: Vyacheslav Petrishchev <vyachemail@gmail.com>,
Christian Biesinger <cbiesinger@google.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v1] gdbsupport: Fix setting up 'development' var.
Date: Thu, 05 Mar 2020 19:36:00 -0000 [thread overview]
Message-ID: <00654d63-7ed9-7e34-be2c-f95bd99ba6b3@simark.ca> (raw)
In-Reply-To: <d851ec32-e6c7-99cf-e2a0-6783ccb2a36b@gmail.com>
On 2020-02-26 2:40 a.m., Vyacheslav Petrishchev wrote:
>
>
> On 2/26/20 3:17 AM, Christian Biesinger wrote:
>> Oh, that explains the error someone mentioned on IRC recently...
>>
>> I can't approve patches, but it looks like you used Debian's autoconf
>> to regenerate the configure script, leading to extra changes. To avoid
>> that it is best if you install and use an unmodified upstream autoconf
>> directly, perhaps by installing with --prefix and running it from
>> there.
>>
>> Christian
>>
>
> yes, it was Debian's autoconf, thanks
>
> Vyacheslav
>
Thanks, I hadn't noticed before now you provided an updated patch.
I added a commit message to it and pushed it.
You can check my series here which does a bit of further cleanup in that area:
https://sourceware.org/ml/gdb-patches/2020-03/msg00123.html
Simon
prev parent reply other threads:[~2020-03-05 19:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-25 20:33 [PATCH] " Vyacheslav Petrishchev
2020-02-25 21:18 ` Christian Biesinger via gdb-patches
2020-02-26 7:40 ` [PATCH v1] " Vyacheslav Petrishchev
2020-03-05 19:36 ` Simon Marchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=00654d63-7ed9-7e34-be2c-f95bd99ba6b3@simark.ca \
--to=simark@simark.ca \
--cc=cbiesinger@google.com \
--cc=gdb-patches@sourceware.org \
--cc=vyachemail@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).