From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) by sourceware.org (Postfix) with ESMTPS id 1F357383D816 for ; Tue, 31 May 2022 12:03:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1F357383D816 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wm1-f49.google.com with SMTP id f23-20020a7bcc17000000b003972dda143eso1102977wmh.3 for ; Tue, 31 May 2022 05:03:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=Tr+7FO9RtzOokpwhL6CtnNEMvZ7X2Y+r19OwMI4Hi4M=; b=CCyN9v0ky5sz7JxDHnFGbe0pvlEZvB7yQDLfu72sjoBnDZk0h6uWBS06loYPyFdcgZ jnzuEsLMAGpfSmWxlFnD4BrYclM0DWP07b/+QljG6/hDBtBwoXxaPcOMOV6xcP0HMYna YWytqobHwDZDQDC8lrq05ilj16O/7R2zZZjpUFH33al+MyDNn4Pu7bbNCeLes2L+Y2N3 B2DwhXg64WM2KhpKr2H3GLNddmvHcTrpUGC/zPu4pqM6Ep3xZwNtUnzMVOYZRoRC/gup 6g564eylQa44loDvKSy2bS7VGb8DH97D3+dU0zdih1EwbZYtDfuUd5cxrVO/j047Ef6X J1IQ== X-Gm-Message-State: AOAM533Mp32sjyWzOIkD2BRE9e+Ju/A07Wxb0JVB0hICAINvV5m3i7fG VKlsPtuLO4ujZZ2HofIa7WegbmKu83k= X-Google-Smtp-Source: ABdhPJwcl5u0Y8Jjiy9OMInFvv/C9+rHF7Hx4urYp4QbOJLMkjaeXYMJOuSDVsLLreCmPxqA0t64lA== X-Received: by 2002:a05:600c:4f51:b0:397:86a9:b827 with SMTP id m17-20020a05600c4f5100b0039786a9b827mr20750343wmq.114.1653998612843; Tue, 31 May 2022 05:03:32 -0700 (PDT) Received: from ?IPV6:2001:8a0:f924:2600:209d:85e2:409e:8726? ([2001:8a0:f924:2600:209d:85e2:409e:8726]) by smtp.gmail.com with ESMTPSA id l5-20020a1c2505000000b0039763d41a48sm2000714wml.25.2022.05.31.05.03.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 31 May 2022 05:03:31 -0700 (PDT) Message-ID: <006eed32-3f65-61c4-686b-451cbdc40fb9@palves.net> Date: Tue, 31 May 2022 13:03:30 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH] Improve break-range's documentation Content-Language: en-US To: Eli Zaretskii Cc: gdb-patches@sourceware.org References: <20220526194250.2310460-1-pedro@palves.net> <838rqmm7gb.fsf@gnu.org> <6914f754-4e33-5aa1-4ea6-dca9504e8bfe@palves.net> <837d63j8tx.fsf@gnu.org> <83r149j4qq.fsf@gnu.org> From: Pedro Alves In-Reply-To: <83r149j4qq.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 31 May 2022 12:03:35 -0000 On 2022-05-31 12:55, Eli Zaretskii wrote: >> Date: Tue, 31 May 2022 12:31:40 +0100 >> Cc: gdb-patches@sourceware.org >> From: Pedro Alves >> >> Set a breakpoint for an address range given by @var{start-locspec} and >> @var{end-locspec}, which are location specs. @xref{Location >> Specifications}, for a list of all the possible forms of location >> -specs. If either @var{start-locspec} or @var{end-locspec} resolve to >> -multiple addresses in the program, then the command aborts with an >> -error without creating a breakpoint. The breakpoint will stop >> -execution of the inferior whenever it executes an instruction at any >> -address within the specified range, including @var{start-locspec} and >> -@var{end-locspec}. >> +specs. @value{GDBN} resolves both @var{start-locspec} and >> +@var{end-locspec}, and uses the addresses of the resolved code >> +locations as start and end addresses of the range to break at. If >> +either @var{start-locspec} or @var{end-locspec} resolve to multiple >> +code locations in the program, then the command aborts with an error >> +without creating a breakpoint. The breakpoint will stop execution of >> +the inferior whenever it executes an instruction at any address >> +between the start and end addresses, inclusive. > > This is fine, but please swap the last sentence with the one before > it, since, as written, the penultimate sentence breaks the logic of > the description of what the command does by describing an exceptional > situation too early. The way it is written made sense to me, as we first say GDB resolves the locspecs, and then the exceptional situation is exactly about the resolving we just described. Anyhow, I'll change it and merge.