From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 169463839808 for ; Wed, 25 May 2022 10:50:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 169463839808 Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-587-Hkev8k2OPsKYkJ-77ycCIA-1; Wed, 25 May 2022 06:50:04 -0400 X-MC-Unique: Hkev8k2OPsKYkJ-77ycCIA-1 Received: by mail-wm1-f71.google.com with SMTP id r6-20020a05600c35c600b0039740f3d32dso922738wmq.9 for ; Wed, 25 May 2022 03:50:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=6fBHIsT42j05aNo44nEAocsmnfQGKUyq8IlU/rppVx0=; b=Z+qWD7l7IvNZSadQBzkNTiMJng6BHwP+WlmGOnWg0K/Y3Wyf/uRgI3DmrrxGzwlM1n Rd1KETOmQpoWjRZdGmm7MQ9TMUuFt/57fPAnAvZg8aeJ+g/BqLQcuXg5ML3+a8J0c4L3 TkZl+M9H/pvNc9ft99gPz7eFJErrKA1gGkEvAjwQRUkUgW+p8doE09uWy4ae6J4QdXnS O+RKpVPlT+OJrqY3gB9gUA2+9dG1r5eJ4XappMBWUwOp7HYx3co6x+hrA+3+rjNhmo2q fFxVUCT6TW+2uW6Bk/C2RJbgB0mXBMnK0lMiAHhVOT1jv8XMDrGB0FaIebySDuRltUv9 0gOA== X-Gm-Message-State: AOAM5311PmxmuqhEhp7oK6hYElk2dX8t8fSB56+SYrv2XtjfGHWbUjyL wd9o0a4GK9VT4dN2mFTyAr+oC09t36dZkKynqB8x/7spd96M6xVFgdFXrquPAzCOi4mbnO6s7iG lWBQ/hqq09ZcelpYKSuGK+3sY4I9IBQftkDiFIiPMcgQy2L6D1X29oMVWPWoMbl5mUgJHRLaFzw == X-Received: by 2002:a5d:64e9:0:b0:20f:dc21:e652 with SMTP id g9-20020a5d64e9000000b0020fdc21e652mr13037172wri.308.1653475803205; Wed, 25 May 2022 03:50:03 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxxqxjek2RuQEBQXcjuD9YZQIEr1wQv8mHN5RyrGNCk+1kzqmlrCOfpojGh02/m7GP1HD9/2Q== X-Received: by 2002:a5d:64e9:0:b0:20f:dc21:e652 with SMTP id g9-20020a5d64e9000000b0020fdc21e652mr13037150wri.308.1653475802966; Wed, 25 May 2022 03:50:02 -0700 (PDT) Received: from localhost (host109-154-214-95.range109-154.btcentralplus.com. [109.154.214.95]) by smtp.gmail.com with ESMTPSA id c124-20020a1c3582000000b003973ea7e725sm1631944wma.0.2022.05.25.03.50.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 May 2022 03:50:02 -0700 (PDT) From: Andrew Burgess To: gdb-patches@sourceware.org Cc: Andrew Burgess Subject: [PATCHv6 1/6] gdb/python: convert gdbpy_err_fetch to use gdbpy_ref Date: Wed, 25 May 2022 11:49:50 +0100 Message-Id: <007ca6e9bc34c07a125d95bbeaa18f65c182280c.1653475113.git.aburgess@redhat.com> X-Mailer: git-send-email 2.25.4 In-Reply-To: References: MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-Spam-Status: No, score=-12.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 May 2022 10:50:07 -0000 Convert the gdbpy_err_fetch class to make use of gdbpy_ref, this removes the need for manual reference count management, and allows the destructor to be removed. There should be no functional change after this commit. I think this cleanup is worth doing on its own, however, in a later commit I will want to copy instances of gdbpy_err_fetch, and switching to using gdbpy_ref means that I can rely on the default copy constructor, without having to add one that handles the reference counts, so this is good preparation for that upcoming change. --- gdb/python/py-utils.c | 8 ++++---- gdb/python/python-internal.h | 23 ++++++++++------------- 2 files changed, 14 insertions(+), 17 deletions(-) diff --git a/gdb/python/py-utils.c b/gdb/python/py-utils.c index 63eb4e8078c..57710dd56c8 100644 --- a/gdb/python/py-utils.c +++ b/gdb/python/py-utils.c @@ -194,10 +194,10 @@ gdbpy_err_fetch::to_string () const Using str (aka PyObject_Str) will fetch the error message from gdb.GdbError ("message"). */ - if (m_error_value && m_error_value != Py_None) - return gdbpy_obj_to_string (m_error_value); + if (m_error_value.get () != nullptr && m_error_value.get () != Py_None) + return gdbpy_obj_to_string (m_error_value.get ()); else - return gdbpy_obj_to_string (m_error_type); + return gdbpy_obj_to_string (m_error_type.get ()); } /* See python-internal.h. */ @@ -205,7 +205,7 @@ gdbpy_err_fetch::to_string () const gdb::unique_xmalloc_ptr gdbpy_err_fetch::type_to_string () const { - return gdbpy_obj_to_string (m_error_type); + return gdbpy_obj_to_string (m_error_type.get ()); } /* Convert a GDB exception to the appropriate Python exception. diff --git a/gdb/python/python-internal.h b/gdb/python/python-internal.h index d947b96033b..79219c6bb86 100644 --- a/gdb/python/python-internal.h +++ b/gdb/python/python-internal.h @@ -549,14 +549,12 @@ class gdbpy_err_fetch gdbpy_err_fetch () { - PyErr_Fetch (&m_error_type, &m_error_value, &m_error_traceback); - } + PyObject *error_type, *error_value, *error_traceback; - ~gdbpy_err_fetch () - { - Py_XDECREF (m_error_type); - Py_XDECREF (m_error_value); - Py_XDECREF (m_error_traceback); + PyErr_Fetch (&error_type, &error_value, &error_traceback); + m_error_type.reset (error_type); + m_error_value.reset (error_value); + m_error_traceback.reset (error_traceback); } /* Call PyErr_Restore using the values stashed in this object. @@ -565,10 +563,9 @@ class gdbpy_err_fetch void restore () { - PyErr_Restore (m_error_type, m_error_value, m_error_traceback); - m_error_type = nullptr; - m_error_value = nullptr; - m_error_traceback = nullptr; + PyErr_Restore (m_error_type.release (), + m_error_value.release (), + m_error_traceback.release ()); } /* Return the string representation of the exception represented by @@ -587,12 +584,12 @@ class gdbpy_err_fetch bool type_matches (PyObject *type) const { - return PyErr_GivenExceptionMatches (m_error_type, type); + return PyErr_GivenExceptionMatches (m_error_type.get (), type); } private: - PyObject *m_error_type, *m_error_value, *m_error_traceback; + gdbpy_ref<> m_error_type, m_error_value, m_error_traceback; }; /* Called before entering the Python interpreter to install the -- 2.25.4