From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) by sourceware.org (Postfix) with ESMTPS id 8BE44393827C for ; Mon, 13 Nov 2023 14:08:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8BE44393827C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 8BE44393827C Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=209.85.221.54 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699884493; cv=none; b=op1HrQJF24dboU2cjw2sqKDQXcKckQXmp56wd8kra1+3BFy0KObHGSjM9I6NedVYliRq9HVoe05cAUMMPKXL3jqqNvn+phB+PqsADGAJ375rIho6aIvRA8CviVkYVME1lbYNe3mI63foIezYt0Yc31d3LhDcCQo87kttjs1HSOQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699884493; c=relaxed/simple; bh=h4EjJlYyCtNreJNYFQkJfwP+MXrYPYsOdUcZiCsVza8=; h=Message-ID:Date:MIME-Version:Subject:To:From; b=hSj2D92NrCTyQECh9HZ/NSEhzojyPmJ07LDVmBdtCmEI4Euw+cibg18SVAvopFHDa+IVhQgPAZgoubmf6A2B9t2jq3cyt7dv+/gahfag+e7WFanOqZJVshKp0pPwiCkSfducHMy8/3gaCvTIXeWvarfEua1n9JlSIhow1tGl5f0= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-32f87b1c725so3064310f8f.3 for ; Mon, 13 Nov 2023 06:08:12 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699884491; x=1700489291; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=MGQU2msC8MgxcJiQTtNWd0iFqZO+o09Ya343I+TiX8U=; b=REkMhiLTfLPHYJbxSt8Euw2HYaQSJo+A5vb5Z0FghAMi8BxE/FlhDj7ddD6nZaLR3W 3+Cm9TI7sT12QE8cxBUqBEaOKAvJmqbIkdQjd+u9dn+liY0kCyU2palcf1cTFVzS0ar9 9vFq8fVaM+R0PcvYTWDiLXPYJFmyAem4eXaM8vgMVYUeFo3U7N8ljhVn7tlGQOpuqJcf C85l06yrRVb89J88rtQizDPUu2M9X7T6OGDLxlZ9LuAXb1VZ8ylKQvV1lUTZpsd9Juoq weJ0zSc5y4Ml2vq1VCrYVwnJZxQ827Fxxkwy/5mS5rf5kwooBwrsMk3ctc2lr6VConCx 9x9g== X-Gm-Message-State: AOJu0Yy0SKdVTlZkQxBuSWRhJ5KskwiOKvJgCUhlDxQpyy7JIjYNbu2o wT/6tJoWUvtszpjHn89UCaFc7PusRAQ= X-Google-Smtp-Source: AGHT+IEBm8aYY63xPeKUvhZwuxe1kHP+n7GwN23wvvUJj+URBhr8oQx7D0D9mkO/pPvgrCnu4+xAtw== X-Received: by 2002:a05:6000:1acd:b0:32f:79de:8b7f with SMTP id i13-20020a0560001acd00b0032f79de8b7fmr5237449wry.49.1699884490726; Mon, 13 Nov 2023 06:08:10 -0800 (PST) Received: from ?IPV6:2001:8a0:f91e:1a00:8060:1e54:fb28:9635? ([2001:8a0:f91e:1a00:8060:1e54:fb28:9635]) by smtp.gmail.com with ESMTPSA id w7-20020adff9c7000000b0032fbd0c7d04sm5525593wrr.55.2023.11.13.06.08.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Nov 2023 06:08:10 -0800 (PST) Message-ID: <007e46da-ce26-4cc6-a13a-d7a29fddad36@palves.net> Date: Mon, 13 Nov 2023 14:08:09 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 11/31] gdbserver: Hide and don't detach pending clone children Content-Language: en-US To: Andrew Burgess , gdb-patches@sourceware.org References: <20221212203101.1034916-1-pedro@palves.net> <20221212203101.1034916-12-pedro@palves.net> <878rcv1cdp.fsf@redhat.com> From: Pedro Alves In-Reply-To: <878rcv1cdp.fsf@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2023-06-07 17:10, Andrew Burgess via Gdb-patches wrote: > Pedro Alves writes: >> - /* If THREAD is the parent of a fork child that was not reported to GDB, >> - return this child, else nullptr. */ >> - virtual thread_info *thread_pending_child (thread_info *thread); >> + /* If THREAD is the parent of a fork/vfork/clone child that was not >> + reported to GDB, return this child, else nullptr. */ >> + virtual thread_info *thread_pending_child (thread_info *thread, >> + target_waitkind *kind); > > Should the comment not say what happens to KIND? I think this comment > applies throughout this patch where KIND was added as an argument. > Indeed, fixed throughout. > Otherwise, this looks good. > > Reviewed-By: Andrew Burgess > Thanks!