From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20204 invoked by alias); 31 Oct 2013 16:14:59 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 20177 invoked by uid 89); 31 Oct 2013 16:14:58 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.0 required=5.0 tests=AWL,BAYES_20,MSGID_MULTIPLE_AT autolearn=no version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: mailhost.u-strasbg.fr Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.222.212) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 31 Oct 2013 16:14:57 +0000 Received: from mailhost.u-strasbg.fr (localhost [127.0.0.1]) by antispam (Postfix) with ESMTP id 38288140888; Thu, 31 Oct 2013 17:14:53 +0100 (CET) Received: from mailhost.u-strasbg.fr (localhost [127.0.0.1]) by antivirus (Postfix) with ESMTP id 2801714088C; Thu, 31 Oct 2013 17:14:53 +0100 (CET) Received: from md14.u-strasbg.fr (md14.u-strasbg.fr [130.79.200.249]) by mr2.u-strasbg.fr (Postfix) with ESMTP id 91767140888; Thu, 31 Oct 2013 17:14:46 +0100 (CET) Received: from ms11.u-strasbg.fr (ms11.u-strasbg.fr [130.79.204.111]) by md14.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id r9VGEj5g020315 ; Thu, 31 Oct 2013 17:14:46 +0100 Received: from E6510Muller (gw-ics.u-strasbg.fr [130.79.210.225]) (Authenticated sender: mullerp) by ms11.u-strasbg.fr (Postfix) with ESMTPSA id 03A311FD7B; Thu, 31 Oct 2013 17:14:39 +0100 (CET) From: "Pierre Muller" To: "'Tom Tromey'" , "'Jan Kratochvil'" Cc: "'Pierre Muller'" , "'Keith Seitz'" , , "'Sergio Durigan Junior'" References: <5249C987.50809@redhat.com> <87d2no4uim.fsf@fleche.redhat.com> <524BA344.2070802@redhat.com> <20131016095743.GA17072@host2.jankratochvil.net> <52602A08.4020705@redhat.com> <20131018193445.GA12496@host2.jankratochvil.net> <87k3gw8219.fsf@fleche.redhat.com> In-Reply-To: <87k3gw8219.fsf@fleche.redhat.com> Subject: RE: Regression for gdb.pascal/* [Re: [RFA 4/4] Constify parse_linesepc] Date: Thu, 31 Oct 2013 16:14:00 -0000 Message-ID: <008c01ced654$4fd02100$ef706300$@muller@ics-cnrs.unistra.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable X-SW-Source: 2013-10/txt/msg00934.txt.bz2 > -----Message d'origine----- > De=A0: gdb-patches-owner@sourceware.org [mailto:gdb-patches- > owner@sourceware.org] De la part de Tom Tromey > Envoy=E9=A0: mardi 29 octobre 2013 17:39 > =C0=A0: Jan Kratochvil > Cc=A0: Pierre Muller; Keith Seitz; gdb-patches@sourceware.org ml; Sergio > Durigan Junior > Objet=A0: Re: Regression for gdb.pascal/* [Re: [RFA 4/4] Constify > parse_linesepc] >=20 > >>>>> "Jan" =3D=3D Jan Kratochvil writes: >=20 > Jan> Maybe we could juse use > Jan> [pascal patch] Use case_sensitive_off [Re: Regression for > Jan> gdb.pascal/* [Re: [RFA 4/4] Constify parse_linesepc]] > Jan> https://sourceware.org/ml/gdb-patches/2013-10/msg00581.html > Jan> and forget about all the case changes then. >=20 > I think this would be the best approach. >=20 > However, I think it would be good for Pierre to weigh in. > Pierre, you replied on this thread but I don't think you addressed > Jan's > patch, which seems like the best way forward. I am sorry, but I have not enough time lately to=20 look more deeply into this problem... One thing I do remember was about the fact that some of the internal procedures/functions used by Free Pascal compiler were written with lowercased assembly labels to avoid conflicts with usual procedures or functions Is Keith patch already in latest git? OK, it seems Keith last patch is not in, while it does indeed fix otherwise illegitimate stack access (alloca memory read after exiting function using it...) So Keith patch should go in. Concerning Jan's patch, I am more hesitant because the fact to change the default behavior of=20 pascal parser to case-insensitive does have noticeable behavior changes for end-users... I did not see any difference in the testsuite between Keith and Jan's patch, as Keith patch alone already get's us back to only one failure in the test "p 0x1.1" I must admit that Free pascal never accepted to parse=20 hexadecimal reals, is this accepted in any other pascal compiler ? According to 'git blame' this test was added by Jan on 2010-09-06... Second related question is: there is an xfail in the test, but I stil get FAIL here... Shouldn't I get XFAIL? > If Pierre can't respond soon-ish, I think we should go ahead in the > interests of forward motion and regression-fixing; and deal with > whatever fallout arises when he returns. As I said, let's commit Keith part and wait a little bit on the case insensitive change... I would also like to fix the completion bug in between to check if Jan's patch changes anything in that part.. Pierre as pascal language maintainer =20=20