public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Philippe Waroquiers <philippe.waroquiers@skynet.be>,
	gdb-patches@sourceware.org
Subject: Re: [RFAv5 2/3] Test the convenience functions $_gdb_setting and $_gdb_int_setting.
Date: Wed, 30 Oct 2019 19:44:00 -0000	[thread overview]
Message-ID: <00dc4a30-efc7-36bd-c913-8616524249a6@redhat.com> (raw)
In-Reply-To: <20190915185314.19875-3-philippe.waroquiers@skynet.be>

The subject is stale -- it's $_gdb_setting / $_gdb_setting_str nowadays.

> +# Verifies that $_gdb_setting (SETTING) gives a value whose ptype matches EXPECTED.
> +proc check_type {setting expected} {
> +    with_test_prefix "check_type $setting $expected" {
> +	gdb_test "print \$_gdb_maint_setting(\"$setting\")"
> +	gdb_test "ptype $" "$expected"
> +    }
>  }
>  

I think it would still be good to add here:

 	gdb_test "ptype \$_gdb_maint_setting(\"$setting\")" \
            "type = int"

This is so if someone changes ptype of convenience
functions, maybe making it work for this case, the testcase makes
sure this case is inspected.

Otherwise this version LGTM.

Thanks,
Pedro Alves

  reply	other threads:[~2019-10-30 19:44 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-15 18:53 [RFAv5 0/3] Convenience functions $_gdb_setting/$_gdb_setting_str Philippe Waroquiers
2019-09-15 18:53 ` [RFAv5 1/3] Implement convenience functions to examine GDB settings Philippe Waroquiers
2019-10-30 19:43   ` Pedro Alves
2019-09-15 18:53 ` [RFAv5 2/3] Test the convenience functions $_gdb_setting and $_gdb_int_setting Philippe Waroquiers
2019-10-30 19:44   ` Pedro Alves [this message]
2019-09-15 18:53 ` [RFAv5 3/3] NEWS and documentation for " Philippe Waroquiers
2019-10-30 19:48   ` Pedro Alves
2019-09-29 15:28 ` PING Re: [RFAv5 0/3] Convenience functions $_gdb_setting/$_gdb_setting_str Philippe Waroquiers
2019-10-20 10:25   ` PING^2 " Philippe Waroquiers
2019-10-30 19:39 ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=00dc4a30-efc7-36bd-c913-8616524249a6@redhat.com \
    --to=palves@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=philippe.waroquiers@skynet.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).