Re: [PATCH] gdb/debuginfod: Prevent out_of_range exception

[Pedro Alves <pedro@palves.net>]

On 2022-04-14 19:56, Aaron Merey via Gdb-patches wrote:
> +    # Test that URLs are printed correctly for the first-use notice
> +    set testname "Notice empty URL"
> +    set url ""
> +    setenv DEBUGINFOD_URLS $url

With remote-host testing, this will only change the environment on the build machine,
while GDB runs on the host machine.  Looking at the file, I see it is already
doing a bunch of things that won't work in remote-host scenario, so we can ignore it
for this patch, but really the testcase should have an early exit if [is_remote host].

> +    clean_restart
> +    send_gdb "file $binfile\n"
> +    gdb_expect {
> +	-re ".*Enable debuginfod.*" { fail $testname }
> +	-re ".*$gdb_prompt" { pass $testname }
> +	timeout { fail $testname }
> +    }
> +

We really shouldn't be adding plain gdb_expect uses for GDB matches.  E.g., why not gdb_test here?