From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 51896 invoked by alias); 29 Jun 2018 14:40:20 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 51884 invoked by uid 89); 29 Jun 2018 14:40:19 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=linkedin, LinkedIn, replies, UD:linkedin.com X-HELO: a2-122.smtp-out.eu-west-1.amazonses.com Received: from a2-122.smtp-out.eu-west-1.amazonses.com (HELO a2-122.smtp-out.eu-west-1.amazonses.com) (54.240.2.122) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 29 Jun 2018 14:40:18 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=jl7vyxitgsfircfdhxflkj2c3tgxidze; d=farjump.io; t=1530283215; h=Subject:From:To:Date:Mime-Version:Content-Type:Content-Transfer-Encoding:In-Reply-To:References:Message-Id; bh=o1lyiZj0mu/Xb28x0oxDj8ILtnrR6izZsIpMXOC5ej4=; b=RuDQWO0iLpaeLoSHS+Chq6MLFFbtfrvb/nenYGgFNomVca86mis6s9k+bFDNx78X VaqZIy5WbpCKVSkOXHCcmbqz/fWed1V6YHIPygUhyBb7fMjJOEBPLvaPgl/ICkMbtsA dm0AMvOC7U1UxOzUnsIg4tFNzSlu/MgQyh4nxWZ4= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=uku4taia5b5tsbglxyj6zym32efj7xqv; d=amazonses.com; t=1530283215; h=Subject:From:To:Date:Mime-Version:Content-Type:Content-Transfer-Encoding:In-Reply-To:References:Message-Id:Feedback-ID; bh=o1lyiZj0mu/Xb28x0oxDj8ILtnrR6izZsIpMXOC5ej4=; b=X8qIdAcbFEHArbClVHhKezJQjYMgdO+V3xu8djYl9mpVE5KbZorTvEMVJDHLX3kc dbQyo3zzR1GBds9Gy4gEt/43vHvg9iZ4VELwu82AnIO23jdcAxlrY+jpbKEexcRHXja 3XZBA1UwErcqD8jm6PapS43tiix33nUL7NuOUIfk= Subject: Re: [PATCH v3] Allow using special files with File I/O functions From: =?UTF-8?Q?Julio_Guerra?= To: =?UTF-8?Q?Pedro_Alves?= , =?UTF-8?Q?gdb-patches=40s?= =?UTF-8?Q?ourceware=2Eorg?= Date: Fri, 29 Jun 2018 14:40:00 -0000 Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable In-Reply-To: <9e53034b-7e28-625e-ad70-fbb53863c7e1@redhat.com> References: <20180628192635.44056-1-julio@farjump.io> <0102016447dcf9e9-3989bcd9-1272-4a05-93c5-77823c7a0921-000000@eu-west-1.amazonses.com> <3c1caf7f-f50f-a8d7-43f3-f8fa8eca663d@redhat.com> <79758ca1-2541-9ae6-d793-b367d6094468@farjump.io> <010201644bd94c4b-0d8759a9-5625-4773-a858-6e218d4fc9db-000000@eu-west-1.amazonses.com> <9e53034b-7e28-625e-ad70-fbb53863c7e1@redhat.com> <6ea235bf-bc87-256a-e745-e54f5e97bf5c@farjump.io> Message-ID: <010201644bfcc9f7-34e2955f-fdda-460d-9ffd-f03a76b20d30-000000@eu-west-1.amazonses.com> X-SW-Source: 2018-06/txt/msg00718.txt.bz2 Le 29/06/2018 =C3=A0 16:28, Pedro Alves a =C3=A9crit=C2=A0:=0D > Hi,=0D >=0D > Your message came our hard to read:=0D >=0D > https://sourceware.org/ml/gdb-patches/2018-06/msg00715.html=0D >=0D > Please make sure your client is set up to quote replies.=0D >=0D > On 06/29/2018 03:01 PM, Julio Guerra wrote:=0D >=0D >> I assumed a system >=3D POSIX.1-2001 here. man 7 inode says:=0D >>=0D >> =0D >>=0D >> The S_IF* constants are present in POSIX.1-2001 and later.=0D >> [=E2=80=A6]=0D >> The S_ISLNK() and S_ISSOCK() macros were not in POSIX.1-1996, but=0D >> both are present in POSIX.1-2001=0D >>=0D >>=0D > POSIX specification !=3D actual implementations. Also, Windows !=3D POSI= X,=0D > for example. See the gnulib page I pointed at. Also, looking through=0D > history with "git blame", etc. may find something.=0D =0D Isn't GDB compiled with mingw? I am no expert in mingw, but I thought it=0D was a POSIX implementation based on Windows.=0D Anyway, we can add usual #ifdef guards arounds the cases.=0D >=0D >> Yes, because of man 2 open:=0D >>=0D >> =0D >>=0D >> EISDIR: The named file is a directory and oflag includes O_WRONLY or O_R= DWR,=0D >> or includes O_CREAT without O_DIRECTORY.=0D > I assume you're on Linux, so "man 2" is the Linux Programmer's manual.=0D > But GDB works in other hosts too. So it may be the code was there for=0D > some other host. I mean, why did someone write that in the first place?= =0D > Again, sounds like some code archaeology is in order.=0D =0D Yes, but I checked it was POSIX too:=0D http://pubs.opengroup.org/onlinepubs/9699919799/functions/open.html=0D >=0D > I forgot to say in the previous email, but it would be really nice if we= =0D > could add some coverage for these change to the testsuite. I've asked=0D > before but I don't remember the answer -- Would it be possible to portabl= y=0D > update e.g. gdb.base/fileio.exp to cover at least one kind=0D > of FILEIO_STDEV_SPECIAL file?=0D =0D Ok, I'll have a look, but I thought there File IOs were not implemented=0D in gdbserver, so what runs this test? If it is natively run, it won't=0D cover remote_fileio_func_*.=0D =0D -- =0D Julio Guerra=0D Co-founder & CTO of Farjump=0D Mobile: +33 618 644 164=0D LinkedIn: https://linkedin.com/in/guerrajulio=0D Slack: farjump.slack.com=0D =0D