From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 38521 invoked by alias); 25 Jul 2018 20:01:03 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 38247 invoked by uid 89); 25 Jul 2018 20:00:41 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=H*MI:000000, H*MI:amazonses, truth, mistakes X-HELO: a2-119.smtp-out.eu-west-1.amazonses.com Received: from a2-119.smtp-out.eu-west-1.amazonses.com (HELO a2-119.smtp-out.eu-west-1.amazonses.com) (54.240.2.119) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 25 Jul 2018 20:00:40 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=jl7vyxitgsfircfdhxflkj2c3tgxidze; d=farjump.io; t=1532548832; h=Subject:From:To:Cc:Date:Mime-Version:Content-Type:Content-Transfer-Encoding:In-Reply-To:References:Message-Id; bh=/XKLUIpg8g9CvVOV/RCK083DoOoLQBanu7feFuu+lJA=; b=RC7oFi6JA+5sIJQGbrGWpo5XiUqdjJJmrk5WoWnVwP9aQ464e8jh6MB/13r7nq73 lsrZRl2TFqmR39zIFCcZhIjhid1Q2nGg4urw0XGssbM9Zf727EuoDa/SsWHjWI5D0se NyS5w8S1LNDexepFmANDCXmF46apk3KnVP5+LDug= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=uku4taia5b5tsbglxyj6zym32efj7xqv; d=amazonses.com; t=1532548832; h=Subject:From:To:Cc:Date:Mime-Version:Content-Type:Content-Transfer-Encoding:In-Reply-To:References:Message-Id:Feedback-ID; bh=/XKLUIpg8g9CvVOV/RCK083DoOoLQBanu7feFuu+lJA=; b=OtWc0xDe2FUOU9IX2jl40yE1vJNQ69Vq5G/CWdBB0LT9kB3ipwEaMdvm/2ZfZt21 FRlveR7kybSVKgJ5eExAi1iwkfW+vULRpDPXlVP6BuffsioTRGMAd5/I9j5VlDVcoUv phP87ImqO/aOeFPArU95mQifAyeKr+fDWL6ofACk= Subject: Re: [PATCH] Install fileio.h to share File I/O protocol type definitions From: =?UTF-8?Q?Julio_Guerra?= To: =?UTF-8?Q?Tom_Tromey?= Cc: =?UTF-8?Q?gdb-patches=40sourceware=2Eorg?= , =?UTF-8?Q?Pedro_Alves?= Date: Wed, 25 Jul 2018 20:01:00 -0000 Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable In-Reply-To: <87o9evyump.fsf@tromey.com> References: <20180709093410.63068-1-julio@farjump.io> <010201647e64586b-d00b8b01-c2d4-4b0d-8f9c-3485ccafa87c-000000@eu-west-1.amazonses.com> <87o9evyump.fsf@tromey.com> <9f54db97-2e20-1935-c730-e6036a5809e0@farjump.io> Message-ID: <01020164d3075dd7-c5101668-597f-4dd0-81ef-d7a1bc2642fc-000000@eu-west-1.amazonses.com> X-SW-Source: 2018-07/txt/msg00708.txt.bz2 Le 25/07/2018 =C3=A0 21:37, Tom Tromey a =C3=A9crit=C2=A0:=0D >>>>>> "Julio" =3D=3D Julio Guerra writes:=0D > Your message had ^M characters at the end of each line - no big deal but= =0D > please make sure this isn't what would appear an eventual push.=0D =0D I am not sure to understand where did you saw ^M chars? I used git=0D format-patch + send-email as usually, I don't understand where they=0D could come from.=0D =0D > Julio> Prevent remote programs from redefining File I/O protocol types by= installing=0D > Julio> include/gdb/fileio.h to share its type definitions.=0D >=0D > This seems reasonable enough, but what is it you plan to use it for?=0D > (I could guess I suppose but it seemed better to ask.)=0D =0D When you implement gdb stubs supporting the File I/O protocol, the=0D remote programs then using File I/O services will require those types.=0D Right now, we have to define them ourselves, but by installing this=0D file, we could firstly stop redefining them, and secondly, have some=0D kind of single source of truth as it's easy to do mistakes when=0D redefining them (actually, our struct stat redefinition was wrong for=0D years, but no one was using it until now).=0D =0D > It seems like it would be a good idea to have some documentation for=0D > this, if it's something we intend to support.=0D =0D The documentation already talks about these types here=0D https://sourceware.org/gdb/onlinedocs/gdb/Protocol_002dspecific-Representat= ion-of-Datatypes.html#Protocol_002dspecific-Representation-of-Datatypes=0D But do you want me to add some documentation about this file being=0D installed before the list?=0D =0D -- =0D Julio Guerra=0D =0D