From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by sourceware.org (Postfix) with ESMTPS id 6FE483851A9C for ; Thu, 20 Oct 2022 09:22:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6FE483851A9C Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id A75D222C22; Thu, 20 Oct 2022 09:22:10 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 8C2B513494; Thu, 20 Oct 2022 09:22:10 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id wEapIEITUWNKOQAAMHmgww (envelope-from ); Thu, 20 Oct 2022 09:22:10 +0000 Message-ID: <01165d25-2a86-7479-a831-e457e915b878@suse.de> Date: Thu, 20 Oct 2022 11:22:10 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: Don't build readline/libreadline.a, when --with-system-readline is supplied Content-Language: en-US To: Simon Marchi , =?UTF-8?B?0JTQuNC70Y/QvSDQn9Cw0LvQsNGD0LfQvtCy?= Cc: gdb-patches@sourceware.org References: <8cb2cddc50577d82422176d1ffebe140@polymtl.ca> From: Tom de Vries In-Reply-To: <8cb2cddc50577d82422176d1ffebe140@polymtl.ca> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-11.1 required=5.0 tests=BAYES_00, BODY_8BITS, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, NICE_REPLY_A, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Oct 2022 09:22:17 -0000 On 1/3/19 06:09, Simon Marchi wrote: > On 2018-12-12 02:46, Дилян Палаузов wrote: >> https://sourceware.org/bugzilla/show_bug.cgi?id=18632 >> >> The bundled libreadline is always built, even if the system is >> ./configure'd --with-system-readline and the build libreadline.a is not >> used. >> >> Proposed patch: >> >> Fix ./configure.ac not to proceed readline/, when --with-system- >> readline is provided >> >> diff --git a/configure.ac b/configure.ac >> index 159f968..adf6dfb 100644 >> --- a/configure.ac >> +++ b/configure.ac >> @@ -253,6 +253,12 @@ if test x$with_system_zlib = xyes ; then >>    noconfigdirs="$noconfigdirs zlib" >>  fi >> >> +# Don't compile the bundled readline/libreadline.a if --with-system- >> readline >> +# is provided. >> +if test x$with_system_readline = xyes ; then >> +  noconfigdirs="$noconfigdirs readline" >> +fi >> + >>  # some tools are so dependent upon X11 that if we're not building with >> X, >>  # it's not even worth trying to configure, much less build, that tool. > > Thanks.  I've tested it and pushed it (with the generated configure and > the matching ChangeLog entry). > > For those who wonder, Joseph Myers suggested we take care of this patch > in GDB and then sync it with gcc [1]. > Which never happened, and therefore a recent sync from gcc repo dropped this patch, so I reopened https://sourceware.org/bugzilla/show_bug.cgi?id=18632. Thanks, - Tom > Simon > > [1] https://gcc.gnu.org/ml/gcc-patches/2018-12/msg00299.html