From: Carl Love <cel@us.ibm.com>
To: Ulrich Weigand <Ulrich.Weigand@de.ibm.com>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Cc: "will_schmidt@vnet.ibm.com" <will_schmidt@vnet.ibm.com>,
"bergner@linux.ibm.com" <bergner@linux.ibm.com>
Subject: Re: [PATCH 2/2] PowerPC: update comments for the MMA instruction name changes.
Date: Fri, 04 Nov 2022 08:25:05 -0700 [thread overview]
Message-ID: <01229749440474597d4a1d08a6a16fb849c7a1e0.camel@us.ibm.com> (raw)
In-Reply-To: <115c61170db1308646226a9ba67b278ad49ac711.camel@de.ibm.com>
Ulrich:
On Fri, 2022-11-04 at 13:04 +0000, Ulrich Weigand wrote:
> Carl Love <cel@us.ibm.com> wrote:
>
> > PowerPC update comments for the MMA instruction name changes.
>
> The *comment* changes are OK. However, this:
>
> - __asm__ __volatile__ ("pmxvi8ger4spp 6, %x0, %x1, 11, 13, 5"
> + __asm__ __volatile__ ("pmdmxvi8ger4spp 6, %x0, %x1, 11, 13, 5"
> :: "wa" (vec_xa), "wa" (vec_xb) );
> - __asm__ __volatile__ ("pmxvf32gerpp 7, %x0, %x1, 11, 13"
> + __asm__ __volatile__ ("pmdmxvf32gerpp 7, %x0, %x1, 11, 13"
> :: "wa" (vec_xa), "wa" (vec_xb) );
>
> actually changes code, and in particular it requires that the
> compiler and/or assembler used to build the test case understands
> the new name. This would cause the test to fail when run on a
> system with an older toolchain.
>
> I think this part of the patch should be removed.
Yup, forgot about that change. I have reverted it back to the older
names and put a comment in stating that the test uses the older names
for backward compatibility. Thanks.
I will post version 2 of the patch.
Carl
next prev parent reply other threads:[~2022-11-04 15:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20111d66a467599d893bf85bbdf2e82b76377127.camel@us.ibm.com>
2022-11-03 17:30 ` [PATCH 0//2] PowerPC: MMA+ Outer-Product Instruction name change Carl Love
2022-11-03 17:30 ` [PATCH 1/2] PowerPC: fix for the gdb.arch/powerpc-power10.exp test Carl Love
2022-11-04 13:02 ` Ulrich Weigand
2022-11-03 17:30 ` [PATCH 2/2] PowerPC: update comments for the MMA instruction name changes Carl Love
2022-11-04 13:04 ` Ulrich Weigand
2022-11-04 15:25 ` Carl Love [this message]
2022-11-04 15:49 ` [PATCH 2/2 version 2] " Carl Love
2022-11-04 16:02 ` Ulrich Weigand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=01229749440474597d4a1d08a6a16fb849c7a1e0.camel@us.ibm.com \
--to=cel@us.ibm.com \
--cc=Ulrich.Weigand@de.ibm.com \
--cc=bergner@linux.ibm.com \
--cc=gdb-patches@sourceware.org \
--cc=will_schmidt@vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).