From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=R1pi=5H=simark.ca=simark@sourceware.org>
Received: from simark.ca (simark.ca [158.69.221.121])
	by sourceware.org (Postfix) with ESMTPS id AE59C3858D33
	for <gdb-patches@sourceware.org>; Tue, 10 Jan 2023 18:05:12 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org AE59C3858D33
Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca
Received: from [10.0.0.11] (unknown [217.28.27.60])
	(using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
	 key-exchange X25519 server-signature RSA-PSS (2048 bits))
	(No client certificate requested)
	by simark.ca (Postfix) with ESMTPSA id 260581E0D3;
	Tue, 10 Jan 2023 13:05:12 -0500 (EST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail;
	t=1673373912; bh=nSrN8LQ5jalXSeam/rPxJt+NMhpp/j/Nt4cKeb+Yt7A=;
	h=Date:Subject:To:References:From:In-Reply-To:From;
	b=CE/Mq/7JEoyFlPBWxwE5rRzuwLluLOfaqj6braJoeRCKaxJxceKgePq6OV/8WD09A
	 Vh+47sa+z5G5ViXMltVzExsIweV/gp+IbnYQVQLhc2vpZGrPpvTOUbtotJnL43uPIJ
	 NkiGgvWiTbnbSvBO1oYvr5oIErh/37FBpJ7HzPG0=
Message-ID: <01243e5b-137f-9ac0-8235-8f51df07902e@simark.ca>
Date: Tue, 10 Jan 2023 13:05:11 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.1
Subject: Re: [pushed] [gdb/testsuite] Fix gdb.threads/dlopen-libpthread.exp
 for upstream glibc
Content-Language: en-US
To: Tom de Vries <tdevries@suse.de>, gdb-patches@sourceware.org
References: <20221230155407.5917-1-tdevries@suse.de>
 <7bb6a09d-b915-c855-804d-4c3b13e38b37@simark.ca>
 <174dba84-bac5-af4c-cd2b-85257f57b025@suse.de>
From: Simon Marchi <simark@simark.ca>
In-Reply-To: <174dba84-bac5-af4c-cd2b-85257f57b025@suse.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <gdb-patches.sourceware.org>

> Attached patch fixes things.
> 
> WDYT?
> 
> Thanks,
> - Tom


Here:

> # We link the exec without -lpthread, but libpthread.so may already be loaded at main
> # due to LD_PRELOAD.
> set libpthread_maybe_preloaded 0
> set binfile [standard_output_file $executable]
> if { [has_dependency $binfile libpthread\\.so] == 1 } {
>     set libpthread_maybe_preloaded 1
> }

Ok, so this works because ldd is influenced by LD_PRELOAD, I didn't
know.

> 
> # We link the shlib with -lpthread, but since glibc 2.34 libpthread has been
> # merged with libc, so libpthread.so may not be a dependency.
> set libpthread_missing 0
> if { [has_dependency $binfile libpthread\\.so] == 0 } {
>     set libpthread_missing 1
> }

The two has_dependency calls use $binfile.  Should one of them use
$binfile_lib?  The second one I think.

Simon