From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-eopbgr50075.outbound.protection.outlook.com [40.107.5.75]) by sourceware.org (Postfix) with ESMTPS id 556E73858C62 for ; Tue, 27 Sep 2022 10:42:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 556E73858C62 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=T4tfNfG6sOaZ6jQa76SCEOqf8xxydMoQEd4H/oMBm27E88FHr15NGuGW5/jRlb+NXr0xTbwgGf43IgJmFIWVSBEIxaN1nCmX89hEs42RKFPs41gQ/+1D2dPNAdpfj9FcJQ3bj8D7R3AN1XzdRYJFXHbDRIL/g794Cg0LUvzZNFlKx9junV1fGcHsG4fhzrcOG4RtsV/5Xu303LMCw76cYBKwNPyrn6u3UUyhcrSi/2GMwBbKEXB9McHaUI0dWEeHmDI8FO/MNMIysaqkPDmGWTjB4rpthirOsaFxjCJj7A3c6NIVfNvtOILzPadE3BtOaLqhOq1L06lUEW4VNj9wkA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=b/iHDBD6tUi0Al0i8C0uls+LJAV/oCZWZiVufyqmiWI=; b=LQbgELKzTpcNCPk+ZFWCaFrHKIN1K9PksRUL3PzMZtPV3V+UFRzX3l59g85bofpps3J4eMbFH7spweOBGOLopzU8OwE3ihX2frwJaw2vw31HktOYeE1AE4f5btsh2/H/Ts3zxYnWMg2/yP0T0dUy+Lbba//z4eoWZRitDTjwe44dosnP+VgCcyC4XniahearpotRjPJP49KX54Fr926i/KGY0/zUyPmouoKgK/akFIlCfzGCl7Z6efc1lSArCUL/2+QKDnzv5wmaYGbIzyDIFmHIiRhHO8I/WR50VoM0PV0KXdoZhibOFJ3s9o6p+YRQwCkB6Wc8D53HPkglJQ+aOQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=sourceware.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) Received: from AS9PR06CA0024.eurprd06.prod.outlook.com (2603:10a6:20b:462::32) by AM9PR08MB5953.eurprd08.prod.outlook.com (2603:10a6:20b:2d8::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.26; Tue, 27 Sep 2022 10:42:42 +0000 Received: from VE1EUR03FT030.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:462:cafe::55) by AS9PR06CA0024.outlook.office365.com (2603:10a6:20b:462::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.26 via Frontend Transport; Tue, 27 Sep 2022 10:42:42 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT030.mail.protection.outlook.com (10.152.18.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.14 via Frontend Transport; Tue, 27 Sep 2022 10:42:42 +0000 Received: ("Tessian outbound 937eed45f6ed:v128"); Tue, 27 Sep 2022 10:42:41 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 790b3e7389729cf8 X-CR-MTA-TID: 64aa7808 Received: from 0b80620fadd1.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 1EFE8EEA-2B7A-4C0C-8C4E-96EC8B27C854.1; Tue, 27 Sep 2022 10:42:34 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 0b80620fadd1.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 27 Sep 2022 10:42:34 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RiQUmwOvanl7hLCDTjmXPzm+w0UsL63J3/ZydoP6qOEV/BhKUi5g2jV6p1srXtKywvg1z251CLIeTlB+Lae4GLGA2Dx9cOfM4WXmtl0RDtttstSKgb/LSOY7FLm9IEmVl2ykUGyCKMVIIanWC+3QB5HV4sSIpWDCl5TX2x5q6JaO+wEFKER0RAeAA8d8nnEYVH1MaYj+fJaXmGHk+Shd0aOCKLQ+lLT4bTTbeS4iRSljqvTTsDlGY/4UTdHMflufVhspm9tuV2ug/N9uyzeZtH1AEV9u0cPhL83Rkz4hAr29LsCzWKxzPsLTuaVcGTLlHuIdK+OsJNViT0kbgw56Ig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=b/iHDBD6tUi0Al0i8C0uls+LJAV/oCZWZiVufyqmiWI=; b=HxxB4xBkWPXv4dl0OTt3cWP2gljc5AnsahluqR8wAXDMxBOmopyZDBUGZCSThKihL07RMq1N0lL8REt2k8/72tdRNQWEPhiKZsShk5Zo6roBO7SClV21I8+0Yxv0McoRpigrIW0+Ak9T6OU7vHL9OIRPPdN+XjfuSVxbwHHVFuSVo8opKhhik4jtQVV16f57A/8A0doC/uJnfeAVVZoIKoNNa2u3PuDPeT0z7DnadSpUytMPccRGwaO0mpvQ8T8Sfqe5ZAdgSum+bem5V8aOgAr/9mFk5L1qJWYB1XVUqA6xK/hQVvZ9piQdyQ9+eVf6y4aMtHFVGKWViYkBnYjgVw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) by DB4PR08MB8199.eurprd08.prod.outlook.com (2603:10a6:10:381::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.26; Tue, 27 Sep 2022 10:42:33 +0000 Received: from VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::c5f9:a25b:a5f2:6094]) by VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::c5f9:a25b:a5f2:6094%5]) with mapi id 15.20.5654.026; Tue, 27 Sep 2022 10:42:33 +0000 Message-ID: <01699e1a-78c4-01dd-ecd4-841cd795409c@arm.com> Date: Tue, 27 Sep 2022 11:42:30 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 0/3] Fix gdb.gdb/python-helper.exp + cleanups Content-Language: en-US To: Bruno Larsen , Simon Marchi , Tom de Vries , gdb-patches@sourceware.org References: <20220923141801.1106678-1-simon.marchi@polymtl.ca> <4fe6a9e7-9b87-2755-b741-3a06180cdcc3@suse.de> <5d6abf06-bda0-15a2-7579-0f0c76c70ac5@redhat.com> From: Luis Machado In-Reply-To: <5d6abf06-bda0-15a2-7579-0f0c76c70ac5@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0250.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a7::21) To VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: VI1PR08MB3919:EE_|DB4PR08MB8199:EE_|VE1EUR03FT030:EE_|AM9PR08MB5953:EE_ X-MS-Office365-Filtering-Correlation-Id: 7545e501-cb55-4a84-d070-08daa0750198 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: Gxm1A13P+5UvGbde5AN19NlXBAX2EhJBNN580sIAZH1fs9wO8ouZFPYXjIKOfcTyeL2Ov7HjujVRRWnWcHp/QzGbTxd3TVM8c+WPzgsqK9s5QTAy0ti304vz5V3+MVpMuDbH2x9tFw8LfercNUITwzE0f2kmJ/Ti0xgUZ4x5Pa8WncX5nIDCJ6PxuouGwoJQXtcrLU+p2+5PPud/NUGPbiQCDkxL+aSq4hrPReg/qOUu8s2vknA9hZxgUuJzprDmNHbki3o+g4ig71QjTM6QvEKmYDBcZnn+kY8iD9G6wnDmItxf8/hy60PZGJJSWzBEy0QzhgRaWaSMOhwCpA09tXlwj0QJ+NmFTh2EOKiXYn7hxEh3EpTh9tKpH+QMGO8ynbBbriwl48Ocad+i3G3TsSsOg0C0kpG3a9kD4ggGuKjkBvGumvaSJibFkeMlXfQS6fV6MOpFsSmK6PRQwTl+t8GMYyC4L6LUloZM/DvxaMgVfns5hAAw/rv7nRhMG7Dim0NNg3OFYObXQlOzUDLp2bxFOEBQQe9feX1RoLDkWv+qqCFc0sqGVh1ZJNAa3alZiwHO30GNXsULDYBt/A8511FBGDK98C7KAFImex4O2LtgpCfW9Vsyi326+42V5Gwjdp0GejZ5lNEFiVb0OBKKJbzDmc3O6exRlyjsU4PCl5PqqLk3UoheSMXoVqcpHf/FNILbPzzyQ9rJyOlWOzdZooFvyD8J9YXYNMVaI4995Et63kKj62lidTWPhTk7ARS0dner0/XLmpAgR7HabaKsc6cvpH+ba2nGwbfhcgCz5L4OnbrkNUVsqvGGezWcWZu9 X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR08MB3919.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(136003)(376002)(39860400002)(366004)(396003)(346002)(451199015)(36756003)(84970400001)(8676002)(86362001)(66476007)(66946007)(41300700001)(2616005)(186003)(66556008)(966005)(38100700002)(478600001)(31696002)(6486002)(5660300002)(8936002)(44832011)(53546011)(83380400001)(316002)(6512007)(110136005)(26005)(31686004)(6506007)(2906002)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB4PR08MB8199 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT030.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 8f95c9c0-cf4d-46c0-b314-08daa074fc01 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: x2QgrAgiqJ/8aYHB6FALEQOv81/m3pDZAiUaoVUIrA31W4EkwhMbZVMnOQVoo72HSg/FPsC3Tv8awfAyjyr9QPJxvpj+VSpcLjM6+VWmoBr25YFQLoBjwiNrPBapWRaMFTYdtPaiT6GoPY5E7ZaA3InhbLxJ/WoeyNUmxbKDfMOAykSd9ZNoBtLsconJSqjEy5tVAQVgcnM22JxZBcXXsXhalcqKQmYjEPiA0V3SXf++9hDJH1urMxOP3oTRB+bm3f+V5QphE2rSoPZo6/9RanwaGNh0ozdxZeuC5UIQbi1d0o/zMtJdGraQff1CUz865IyKbgYjBhYKn9mQBdBL8sTs0D6Z7IdOiMJaGgfeEjd/Id0xffmBwv2g+tqC+2AEbZ6/ql2UJ17byAB0Nfec/oQRN1LZ8DTnkE0iyYPjnkUKsrcnFyYbgB+UVCEPcD4XYPw5+OtJb5++7pJ1nkdrhwxKYTNQy+Y95BXcAtM13zCNsaY0dbTmmSpF/S8sn+2l4K4WxF3uw7NdhU7mOLeKo/fQ6rBEam9FXt5KwpDoClyWFpGWvcJX45DHQdB82GHhhx6WZkNlgqNAH98eFBTTHXB1Xts6feqIrkqpujoCdR2qO6xbXP4HaEO1HOSIeEJTdWkA4pSdtV1VAtRyS/rehekp5HJqQW2Pgx3eukH++V4gn43tyFDvB5+C+S/aPK16nWuybbXvivvOE5So6D/2gjFPBx9ua4Bve3dwVKV0g5sgQD0s5bMs+Eg4lSUWiDQYqL31zOVsjIDe4fW/q3nxpcltygILQ08IsH+ywc+VfqTrFsBoNqChfVPYvM41Xu+40OQ/4v/AeACydGa5UCYlHA== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(13230022)(4636009)(39860400002)(396003)(346002)(376002)(136003)(451199015)(40470700004)(36840700001)(46966006)(31696002)(81166007)(356005)(86362001)(36756003)(31686004)(84970400001)(82740400003)(36860700001)(44832011)(186003)(5660300002)(2616005)(40460700003)(40480700001)(41300700001)(82310400005)(2906002)(478600001)(966005)(6506007)(26005)(6486002)(53546011)(6512007)(336012)(47076005)(83380400001)(8936002)(8676002)(316002)(110136005)(70586007)(70206006)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Sep 2022 10:42:42.3662 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7545e501-cb55-4a84-d070-08daa0750198 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT030.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB5953 X-Spam-Status: No, score=-6.0 required=5.0 tests=BAYES_00, BODY_8BITS, DKIM_SIGNED, DKIM_VALID, FORGED_SPF_HELO, KAM_DMARC_NONE, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_NONE, TXREP, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Sep 2022 10:42:48 -0000 On 9/27/22 11:34, Bruno Larsen wrote: > On 26/09/2022 20:01, Simon Marchi via Gdb-patches wrote: >> >> On 2022-09-23 17:35, Tom de Vries wrote: >>> On 9/23/22 19:02, Luis Machado via Gdb-patches wrote: >>>> On 9/23/22 15:17, Simon Marchi via Gdb-patches wrote: >>>>> My patches that touched TYPE_LENGTH and TYPE_TARGET_TYPE caused >>>>> regressions in gdb.gdb/python-helper.exp.  I forgot to update >>>>> gdb-gdb.py.in, as always. >>>>> >>>>> It looks like my CI doesn't run the test properly.  Because inserting the >>>>> first breakpoint times out, do_self_tests skips the test.  I also had >>>>> troubles running the test locally due to these timeouts.  So the first >>>>> two patches address problems related to that, and the third one is the >>>>> actual fix. >>>>> >>>>> Simon Marchi (3): >>>>>     gdb/testsuite: bump duration for the whole test in do_self_tests >>>>>     gdb/testsuite: use gdb_test in gdb.gdb/python-helper.exp >>>>>     gdb/testsuite: update field names in gdb-gdb.py.in >>>>> >>>>>    gdb/gdb-gdb.py.in                       |  4 +- >>>>>    gdb/testsuite/gdb.gdb/python-helper.exp | 88 +++++-------------------- >>>>>    gdb/testsuite/lib/gdb.exp               |  8 +-- >>>>>    gdb/testsuite/lib/selftest-support.exp  | 36 +++------- >>>>>    4 files changed, 31 insertions(+), 105 deletions(-) >>>>> >>>>> >>>>> base-commit: 8e037eae6823caf5b9cb5b4feb3de838abb25956 >>>> Thanks for the series. I tested this on my end and it seems to work nicely. >>>> >>>> The only hiccup I noticed is when GDB runs into a SIGSEGV due to the guile >>>> interpreter hitting GC_find_limit_with_bound. I'm not sure why this happens. Maybe >>>> it is a problem with guile and armhf. >>> It's documented behaviour of libgc1, see >>> https://sourceware.org/bugzilla/show_bug.cgi?id=29325 . >> Ack, this is an orthogonal issue (and for some reason I don't see it on >> my Arch Linux, but I have certainly seen it elsewhere). > > This bug happens because of an old version of libgc being used, where they used that segfault to probe memory for something. They have developed a new way of probing that doesn't trigger this segfault, but not all distributions seem to have backported it. It's probably not happening on Arch because htey have a new version of the library, while on fedora it was happening until recently (Alexandra backported that for us). Fixing this sort of needs to happen on a per-distro basis, as it isn't GDB related, it's an "available libraries" problem. Thanks for the tip. I'll try to update the packages for this particular distro (Ubuntu 22.04). > > Cheers, > Bruno > >> >> Just to confirm, does the series look good to you too Tom? >> >> Simon >> >