From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id C7BBB3858D28 for ; Thu, 5 Jan 2023 16:36:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C7BBB3858D28 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=polymtl.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=polymtl.ca Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 305GaY7C022991 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 5 Jan 2023 11:36:39 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 305GaY7C022991 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=default; t=1672936599; bh=KpBnRFJd8rn/Qx/Bhl2mDkeINOsFGy4FGcVdldv6cKY=; h=Date:Subject:To:References:From:In-Reply-To:From; b=uxXWyla/ZgoCcalXjvcCRmIPfmdiDx/4x8q/yNiuktn/kFhq/5fFZI+FuUn+PQRwB w7OJQ+6wfJqpx/+gD3GqU6+FyJg3OiuTBGEv/rDAjMiR0VOdjKW+wNZG+X3QtpnUFq oBcKIhUZ0n+04Kytn+IuYMTq/XVvK1ouFmoQ3AqQ= Received: from [192.168.255.180] (unknown [207.35.41.250]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 15B1B1E0D3; Thu, 5 Jan 2023 11:36:34 -0500 (EST) Message-ID: <01722fc1-e9cc-1372-0e51-db288a036f3f@polymtl.ca> Date: Thu, 5 Jan 2023 11:36:37 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH] gdb: use gdb_test_multiple in gdb_breakpoint Content-Language: fr To: Tom de Vries , gdb-patches@sourceware.org References: <20230103192216.108444-1-simon.marchi@polymtl.ca> <315f1d7a-a948-5512-fd89-a40d7a25e937@polymtl.ca> From: Simon Marchi In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Thu, 5 Jan 2023 16:36:34 +0000 X-Spam-Status: No, score=-3034.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 1/5/23 11:31, Tom de Vries wrote: > On 1/5/23 17:28, Simon Marchi wrote: >> On 1/5/23 04:04, Tom de Vries wrote: >>> On 1/3/23 20:22, Simon Marchi via Gdb-patches wrote: >>>> - -re "$gdb_prompt $" { >>>> - if { $print_fail } { >>>> - fail $test_name >>>> - } >>>> - return 0 >>>> - } >>> >>> This caused: >>> ... >>> FAIL: gdb.dwarf2/dw2-main-no-line-number.exp: gdb_breakpoint: set breakpoint at 1 >>> FAIL: gdb.dwarf2/dw2-main-no-line-number.exp: !$breakpoint_at_missing_lineno_set >>> FAIL: gdb.go/methods.exp: going to first breakpoint (the program exited) >>> FAIL: gdb.go/methods.exp: going to second breakpoint (the program is no longer running) >>> ... >>> >>> Re-inserting this piece of code fixes it. >> >> Ah, sorry for this, and thanks for reporting. The CI test job I usually >> use is a bit broken right now, so I don't test as well as I should. > > Ah, that's too bad, I hope you get it running properly again. > >> Does the patch below look good? >> > > LGTM, thanks. > > - Tom Thanks, pushed. Simon