From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from CAN01-YT3-obe.outbound.protection.outlook.com (mail-yt3can01on2067.outbound.protection.outlook.com [40.107.115.67]) by sourceware.org (Postfix) with ESMTPS id CE4E63858436 for ; Wed, 24 May 2023 18:54:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CE4E63858436 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=efficios.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=efficios.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=agfQTBfs9Ti7Rcu2yRI9cS/zmbPr2U2G4+NCcYP5trHjgLgvnhGitMKIMNe52tAegmZwi9PU8l3AitP5bghncL86CdJCOkVi8bGuCqZP0qb5i2Ke2CLymvX4Q4rMixJUCzfihwctVjZLQppPVEdWEf84AAdiuFkzm47PMuiUqXnHsBpQc3kKPv4J97A7JHqsAsz8KKMPVtXj9yjmybw5dXdwByUsZB5DuzaScu9pd1i3AdbOhdQfQV687QESgJOF6+jyKXKw9/4hagMRzOmno2wA2vHtYc5vf2vybdGZ9V1SJKXHSIm+ruwYNqmC+KKBfywM2aB9OkbJe72v4Ef14Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/e5tt+lmmgBYvGQBVrTWdeWobmlhpThppXPIXwyr/1M=; b=WK/LtowHUsGxjEM2uJygZwJbrTtUjz7FUzcDJfehO6M2hqFNSgALhyHL5S+Y0t8r4r07z4fTa8YbfMv/cViC+xAdyRzH4ZJ3NRM9UbNVRHmpIP5i2EOAOf+GJfKx/SUtYO7UBNicqwf31OpCl6qustb2OKSGtUI5uBAEZP6xNTjztBJIi2G4gQOKLe0cY28n7vXOK+p5cII3X7i5HPhQWUvxQ6oZLdnCZNKukso6TdB29RMFzf4ZY9nUtpKsJzrOxEMYktgPlCQNuAXVatSxVGa04Whs2jze1q45WMyelPt95IJJog428vaS+AoVErQ6cUTjBU5yctWOYaHZQ/9rTQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=efficios.com; dmarc=pass action=none header.from=efficios.com; dkim=pass header.d=efficios.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficios.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/e5tt+lmmgBYvGQBVrTWdeWobmlhpThppXPIXwyr/1M=; b=FHJ/kSlEYLorAXqvh6iSDUAdt45Y+aUFFSKUhHLFCNxG9ExGsYfbCMB2kWzfhoO8TVxMy+9AdC6NdVH0+TRe0kijQQrLPimeHhzgj+ykXEEpDnO3ejTHP+f9+F3VMTAdESu4ODoVm8B4l2sH49hi5dZE++Fnw4NOHt4xddtGrIOeRqXdOVRguyeime3nU7EO3HhT4cWXTJ4zruYCLCPZl3GBbaRxyK+uj7f/O942T8KPsPXkg8Tohe9xYMGIEp4tx5jjgGNrBr9FQAAzoISngEP8QftECwnipZ/7ePQlXvAIy1fwV7yXsM2uKWhQaKHexOHSaJj51BuI4r0nZsMqDw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=efficios.com; Received: from YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:a::23) by YQXPR01MB6509.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:4c::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.28; Wed, 24 May 2023 18:54:36 +0000 Received: from YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM ([fe80::28e9:8b26:5c7a:46a8]) by YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM ([fe80::28e9:8b26:5c7a:46a8%3]) with mapi id 15.20.6433.015; Wed, 24 May 2023 18:54:36 +0000 Message-ID: <018b222d-960e-f871-599b-512cce845717@efficios.com> Date: Wed, 24 May 2023 14:54:35 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH] gdbsupport: add support for references to checked_static_cast To: Andrew Burgess , Simon Marchi via Gdb-patches References: <20230518205737.403656-1-simon.marchi@efficios.com> <878rdd7u9p.fsf@redhat.com> <87o7m961xi.fsf@redhat.com> Content-Language: fr From: Simon Marchi In-Reply-To: <87o7m961xi.fsf@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: YQBPR0101CA0202.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:67::24) To YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:a::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: YT1PR01MB2828:EE_|YQXPR01MB6509:EE_ X-MS-Office365-Filtering-Correlation-Id: 3e919488-2667-4a9e-f4d1-08db5c885227 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xJGOfREY2arDYtBMzbZDhDroS0Z2dJCvoFaMahZxb+bFQlWE8SQu9JLG7lmJl04ttuQARRjmFJlxlGDXy0hAWffV5pdylZQeYg7e5uUIIetSG1ytsaMG3wrgWvCIAzAuTv5ytlG1oCRR+DjGFRY5TyIwkl+LBkkBvzOwZQ6jtqa4O7zXTaoqDSgvU3pBSnLp83lRqiFALjXHgpXFFaJCH2t/p5m2d0TALcjkVycD3usB796k6Z/3wKwTstM2kjmsAt/ybnvkHFzYAUpZU5M4Wlmx9R4qE5GVn2Y0KUB1RBt9nlE0ASfpF5q9f6+izhUkdPpxXRFQlzMfyGW8HeHCXgsy1V42F3aJ5E37+cGWSMvs8cYQD9/wyGSjhBgV2M+yVz4wrv5hzFe5g5mW1yQLq5dw2eoPSrB0Kjy5KK1GdJuEFRu1kphP68mvGalhRCCuQ9VNkncsj9dcuuHa40+Vf2m39VVyfBrKjRdH65/Fbz5hRZys6CVTvqQH7tJ1lz5JcnlQnMyW7DjHW1Jz0hH2Lloq6VelTMdkHizAy9cX/aNkUgS4sKMnoy59SJIzHWHsBA4PQEsZGee6FUcs5wozhOEFUOLOQHexvAss6+mfhGEMPeJCopCQcLtLpzABOXhGo+WD4fHo1KlleZ3TsfFjpQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230028)(366004)(376002)(346002)(136003)(39830400003)(396003)(451199021)(38100700002)(31686004)(2906002)(2616005)(478600001)(8676002)(8936002)(26005)(44832011)(6506007)(186003)(316002)(6512007)(110136005)(5660300002)(53546011)(41300700001)(6486002)(31696002)(83380400001)(66476007)(66556008)(66946007)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?S2xBR0MwZ0s1K2pldGtUaTFwVEY4RWRMN0l6cG0yMVN3NENHMGQxTG0renZ2?= =?utf-8?B?aXhoeTZORGw4VkFrRzBCYXliWXcyTnNkNmpiVlhzTy8zQTFMb3VmWkhIT3hl?= =?utf-8?B?aHRtVlE5eFJqY3REaHRxUVl5S29YdFI5MTRmdmZDM1gyekFpN2hpYWNuVWdY?= =?utf-8?B?bHhEZVpJMXEyNndGcTFuVDNsNG11dE1XZmJxNWl3STh5UnlpVU92b3FHUHlj?= =?utf-8?B?TGhWOUlETSswVC9ZNGFFeHNBUE8xQ0RNNURTSGs2blltMjdVMWJFRUsyOFl5?= =?utf-8?B?RU5nOUxWNXNleFZCS2dwVDRzL0wwU0dkTFZwYWVIZk9peWtuWk5xbnRWcldr?= =?utf-8?B?YXdadDRERHNZZzBzMGZTM3g4OVMrRVJvdmlqTS9aVG5qUi9qOFovQm9ta0hz?= =?utf-8?B?SGdGVzRjR1lOQ1JieEJTaXRPci83a0pJenZmNFRtSkM2a1NkWE5YemFvNkFk?= =?utf-8?B?ck50c21NRFpxMFE4OVpkZzExRDUxQ0JsYXI1bW1ITnROZTJnUWdDakRwdzBK?= =?utf-8?B?NXhlZ1YrYjdrTWZJbXVEM0hqYWZYSUJkcWFySFJhb2NBOGFKNHdFblhCRkps?= =?utf-8?B?WGREc0JBOE5zUk1PWFo5NVlQZjJRNWFQWTE5SlU5eUtJWmNHbU5laDlEVHFp?= =?utf-8?B?ckRwcmlSUVY1eVBmTVhtc3ZNeUpGS0VkWmNvTDFOdzhySVN0Q1NVNURCL2tZ?= =?utf-8?B?VGFwVHZveVFVaUlEMERuUDZVU1BvZ1pSVndSQUEwRVN1MkJ2bUg5dHZyd2hs?= =?utf-8?B?SFZhNkFFejZGNDUxY3NNTE42T1lkVWdRS2pQYTZZRmZDT3JzNjcvaUs4STV2?= =?utf-8?B?dWhsRUdrZ1pXd3UzUEFFM0tDeUFpaERvTHhZZ1VCVnkrK2Y1WU1VamdCcnpP?= =?utf-8?B?clVjNHNTbS9id21jc0YzR3RUdlE0SlFLR3lzUEVWQ1ZTcG5OUG5IaHBQaGE3?= =?utf-8?B?cHVhVFZWYVJaeDBLOE5lZ3E5czBBY3FaSllYSW1yeVd4bjEvOGZuNnhjMklH?= =?utf-8?B?b2oxQVZxdEZSeEFJWHNhZW9sbWh6NVc3N1lwNStWcE5FOWxReWVEdzQxYTN1?= =?utf-8?B?MzNsQ2t0bEVmcjMvS2FwRTZIUkw0SVh3T051c2Q1Q05YK2h2Vmd4M0xMb0hz?= =?utf-8?B?RXJFNlNQUERLbnFTaGdBU2txZ3dDNVpjTERuelJQa0Iyd2hOMERQYTFOc2Fw?= =?utf-8?B?Vzh2cDg2Q3N6OGhLWTUyOE1DVzdYZGwrUmtGNVRielR6TzJmT0hndllUNkN0?= =?utf-8?B?dTY3RmNNM2kybmNtc0oySFRZUzZndjFSZGN6eGZkUDlSaFVFdzhOcGNJZXl3?= =?utf-8?B?UnBxQkRkVU1CQ2VQR0E0bnF5WjFrcFM4amJ3KzFQVGhHZUVkQjhRdklxQUVo?= =?utf-8?B?clZ1cDgzVnd0Y01BcGJGNmRodlE1ZVRNRFJhbHpyQ0ltOURLRWZIUU9IU1Q2?= =?utf-8?B?OVYvbmhjVTVwMktJcFlZN3dXejlhYWZrU1pyOVRTUnErZnMxTzc5WHFPZnQw?= =?utf-8?B?YkxkaTBDWmdudWFDeEwyWVNlMFpKZW1lUmpwYlh5cUhwa1NyTlNzalgvaWtk?= =?utf-8?B?MklYVyttVjBYRmd4R1E5ZnBDMDByTDU1d1gxQy92WkNiaU9UQ1hVNElqZVVI?= =?utf-8?B?N29WUVdFNFpTL1FYWjNUcWhDTDNUZ0twL0tlMVY1dEQ2dUVUaFRpZUZ3Nm1V?= =?utf-8?B?aU1ZWjFEYjJDNFBhWWo4RjNQL1p5QWNXNndtZ3c0TFdScm1QaXR3RFk2L2xE?= =?utf-8?B?ZGxxbFZlUHJ0ZnNnL2NUZnZlU0hSeHlwdDVwNHNXWnNoaVVDdXlCUUl5Z0U5?= =?utf-8?B?cDNXN1JiNndKY00rT0ZiWXo1Wkd0NG5kdUwrMnZkbU1VekpJTzErQm5sU3NC?= =?utf-8?B?dGFiNzJ5cjdScytLckFQeVFlNG40WmpJVkwveldNZTNkTnpmTlU1bG0xZHNr?= =?utf-8?B?dXRHdGI4d09ranJYT2hMM3ZOTnFCL3F2MTViK0dEeStmQ1pzTXhHNU9aeWNM?= =?utf-8?B?bCtrMUNiTm5yamtFZDZVMmtzTGhMYnBLa1p1dDFVSHJ1b3M2Zjh5TzAybEU5?= =?utf-8?B?L01SazRpWkpFcjFWYXFOc3g2L3pKd2lMdHVFbXY3NHNIcW93RWFFcXk5V2xp?= =?utf-8?Q?k1GAL7/BSJ2MRwCsHpDcgnH2p?= X-OriginatorOrg: efficios.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3e919488-2667-4a9e-f4d1-08db5c885227 X-MS-Exchange-CrossTenant-AuthSource: YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 May 2023 18:54:36.8449 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4f278736-4ab6-415c-957e-1f55336bd31e X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: a0nB1DHrp6HFaUViNLcEha7quw5nOk/5PikvNENUTGcnxnlhJbONCOUYTGTfHWQdyi9qDpRPEI4UL0jwv62rnQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: YQXPR01MB6509 X-Spam-Status: No, score=-3033.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 5/24/23 14:04, Andrew Burgess wrote: > Simon Marchi writes: > >> On 5/24/23 09:07, Andrew Burgess wrote: >>> Simon Marchi via Gdb-patches writes: >>> >>>> Add a checked_static_cast overload that works with references. A bad >>>> dynamic cast with references throws std::bad_cast, it would be possible >>>> to implement the new overload based on that, but it seemed simpler to >>>> just piggy back off the existing function. >>>> >>>> I found some potential uses of this new overload in amd-dbgapi-target.c, >>>> update them to illustrate the use of the new overload. To build >>>> amd-dbgapi-target.c, on needs the amd-dbgapi library, which I don't >>>> expect many people to have. But I have it, and it builds fine here. I >>>> did test the new overload by making a purposely bad cast and it did >>>> catch it. >>> >>> Looks great. Thanks for expanding this feature. >>> >>> Reviewed-By: Andrew Burgess >> >> Thanks. Are you also fine with the switch to use >> gdb::Requires to do the "target is reference" >> check, as Lancelot suggested? > > Yes, that looks good too. Thanks, pushed. Simon