From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12907 invoked by alias); 28 Sep 2017 22:00:26 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 9746 invoked by uid 89); 28 Sep 2017 22:00:22 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:745 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 28 Sep 2017 22:00:15 +0000 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id AE517C04AC41; Thu, 28 Sep 2017 22:00:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com AE517C04AC41 Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=palves@redhat.com Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 819C353; Thu, 28 Sep 2017 22:00:09 +0000 (UTC) Subject: Re: [RFA 03/12] Remove cleanups from utils.c To: Tom Tromey , gdb-patches@sourceware.org References: <20170928195011.27382-1-tom@tromey.com> <20170928195011.27382-4-tom@tromey.com> From: Pedro Alves Message-ID: <019fe60e-62d1-e91d-7ce4-90a0af583354@redhat.com> Date: Thu, 28 Sep 2017 22:00:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20170928195011.27382-4-tom@tromey.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-09/txt/msg00888.txt.bz2 This is OK, with nits below. On 09/28/2017 08:50 PM, Tom Tromey wrote: > - > - linebuffer = xstrvprintf (format, args); > - old_cleanups = make_cleanup (xfree, linebuffer); > - fputs_maybe_filtered (linebuffer, stream, filter); > - do_cleanups (old_cleanups); > + std::string linebuffer (string_vprintf (format, args)); Please use copy initialization: std::string linebuffer = string_vprintf (format, args); ... to spare readers from wondering what explicit/converting constructor this is trying to call. > - linebuffer = xstrvprintf (format, args); > - old_cleanups = make_cleanup (xfree, linebuffer); > + std::string linebuffer (string_vprintf (format, args)); Ditto. Thanks, Pedro Alves