Re: [PATCH ver 3] Fix hardware watchpoint check in test gdb.base/watchpoint-reuse-slot.exp

[Ulrich Weigand <Ulrich.Weigand@de.ibm.com>]

Carl Love <cel@us.ibm.com> wrote:

>+# The skip_hw_watchpoint_tests checks if watchpoints are supported by
the
>+# processor.  On PowerPC, the check runs a small test program under
gdb
>+# to determine if the Power processor supports HW watchpoints.  The
check
>+# must be done before starting the test so as to not disrupt the
execution
>+# of the actual test.
>+
>+set skip_hw_watchpoint_tests_p [skip_hw_watchpoint_tests]

>-if { ![target_info exists gdb,no_hardware_watchpoints]} {
>+if { ![skip_hw_breakpoint_tests] } {

I guess this will *work* as the skip_hw_breakpoint_tests
function uses a cache to avoid re-running the test.

But it would seem more logical here to use the 
skip_hw_watchpoint_tests_p variable defined above.

Bye,
Ulrich