From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 43503 invoked by alias); 24 Oct 2016 23:00:54 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 43475 invoked by uid 89); 24 Oct 2016 23:00:53 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.3 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 24 Oct 2016 23:00:42 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D09F2A0B54; Mon, 24 Oct 2016 23:00:41 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u9ON0dVS028593; Mon, 24 Oct 2016 19:00:40 -0400 Subject: Re: GDB AIX build broken To: David Edelsohn References: Cc: GDB Patches , Tom Tromey From: Pedro Alves Message-ID: <01ba546d-060d-8591-9c5a-84d4bda2af22@redhat.com> Date: Mon, 24 Oct 2016 23:00:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-10/txt/msg00678.txt.bz2 On 10/24/2016 11:52 PM, David Edelsohn wrote: > On Mon, Oct 24, 2016 at 6:46 PM, Pedro Alves wrote: >> [fixed Tom's address] >> >> On 10/24/2016 11:40 PM, David Edelsohn wrote: >>> GDB build on AIX is broken due to a recent commit. >>> >> >> Which commit? Maybe the gnulib update? Is this a clean >> build from scratch? > > I have no idea which commit. git bisect will tell. > It probably was a bad idea to completely > disrupt the GDB Buildbots while disruptively converting GDB to C++. It's probably a bad idea to speculate and throw blame around. > >> >>> /home/dje/src/binutils-gdb/gdb/common/buffer.c >>> /home/dje/src/binutils-gdb/gdb/common/buffer.c: In function 'void >>> buffer_xml_printf(buffer*, const char*, ...)': >>> /home/dje/src/binutils-gdb/gdb/common/buffer.c:133:27: error: expected >>> ')' before 'PRId64' >>> sprintf (str, "%" PRId64, >>> ^~~~~~ >> >>> Errors with PRIxxx macros normally mean a problem with header file >>> inclusion. for example, gdb/btrace.c, which also uses PRIxxx macros, >>> builds without error. >> >> Sounds like what you'd get if PRId64 is not defined in that >> compilation unit, somehow. > > First, strangely, gdb/common/buffer.c uses > > #include "inttypes.h" > > with quotes, not brackets. I can't find a local definition of that header file. > > It seems to be much happier with included first > > diff --git a/gdb/common/buffer.c b/gdb/common/buffer.c > index e9eee09..a989024 100644 > --- a/gdb/common/buffer.c > +++ b/gdb/common/buffer.c > @@ -17,10 +17,10 @@ > You should have received a copy of the GNU General Public License > along with this program. If not, see . */ > > +#include > #include "common-defs.h" > #include "xml-utils.h" > #include "buffer.h" > -#include "inttypes.h" That's a hint, but it can't be the fix. common-defs.h must be the first file included. I suspect that gnulib's inttypes.h replacement logic is broken on AIX. Thanks, Pedro Alves