From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.gmx.net (mout.gmx.net [212.227.15.18]) by sourceware.org (Postfix) with ESMTPS id C5639385BF92 for ; Wed, 1 Apr 2020 20:18:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org C5639385BF92 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gmx.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=n54@gmx.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1585772290; bh=+y75trXS0th8hrNmGnTR4UXneUGFadIIAdTSVqbtmpY=; h=X-UI-Sender-Class:To:Cc:References:From:Subject:Date:In-Reply-To; b=Z3HFVdZIAuVyOnLQm1a1sZU+S8x2eR7zCnXI5HIOesag38PeaqHBYQzOZG/86N7RZ 22h69I9IUoDoLR4IWDH/8kYtC+LqXlU3hCSoHqLdcP4X9AA8RvnLNT/2elUf8e9Wd4 WEQYhI71s7wQf9Fwwq1jo/SJTehWHTk6g7baZXpg= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.0.241] ([89.79.191.25]) by mail.gmx.com (mrgmx005 [212.227.17.184]) with ESMTPSA (Nemesis) id 1MuUnA-1j2TuS2xG6-00rZBT; Wed, 01 Apr 2020 22:18:10 +0200 To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20200325183541.6662-1-n54@gmx.com> <87imij0zv6.fsf@tromey.com> From: Kamil Rytarowski Autocrypt: addr=n54@gmx.com; prefer-encrypt=mutual; keydata= mQINBFVwUF8BEADHmOg7PFLIcSDdMx5HNDYr8MY2ExGfUTrKwPndbt3peaa5lHsK+UGoPG48 KiWkhEaMmjaXHFa7XgVpJHhFmNoJXfPgjI/sOKTMCPQ5DEHEHTibC4mta7IBAk+rmnaOF0k8 bxHfP8Qbls66wvicrAfTRXn/1ReeNc3NP4Sq39PoVHkfQTlnQiD4eAqBdq61B7DhzjhbKAZ4 RsNtLfB6eOv9qvmblUzs50ChYewM9hvn+c7MdDH+x2UXoSDhkBDkKcJGkX91evos8s9AuoEd D32X5e+bmdUGe8Cr3cAZJ8IEXR6F9828/kxzPliMsCWVRx1Fr28baCJOUGgFPNr3ips78m9+ Iw8PdQ101jU0dvucDFxw/1SCGYEZzV+O/237oRPuLCiDX5nhQoxf6dn9ukQleLBMNy2BLI4H g342NhF21HLA+KlyLOHaMKQCKzlal+zVNZTRTCh/ikMhsxWQjBfnqTDbMj85DnWwtump27SI qhPjUnS0a6MKoS/A+hbi64k5zztkvloELfCSrX7NyBTT0jgF2IGFIxZMrKCtQ9StcGMCV9MX tjcBy6fj7QMontEaIDRJEMjg8UIGw1B687OhalOv1ISia4xOWvpYAM6ipgqh6tBQmFzasL9P h1RtcVdFpFbhwVlr1Bly8c25gBNQHL5GUjLMn45LlQz50OzrkwARAQABtCdLYW1pbCBSeXRh cm93c2tpIChOZXRCU0QpIDxuNTRAZ214LmNvbT6JAjwEEwEIACYCGyMHCwkIBwMCAQYVCAIJ CgsEFgIDAQIeAQIXgAUCVbKGFwIZAQAKCRBLswjpsC52bIVpD/9i8npieI91xMIVvAHIUMeo cQO0IrNb+b/PuTj2qNemdwU7dhVJ7tVU5O1H2hI2M4rHGzjzDTxYzdxka0+A8CVEuvFdf6sF lXlXF0wM7rC6MoaB0QLAKxkZB5OtCILxLx7Bl2Y4cTPMU9v+qSL6yrdmhxogkufa4d6O9Zl/ FCWO2kH/BphKOiDtbyvdo2WULSLWP2IXN+0rCpNL4wbTfYLgV9JtMf8f0naGsdy7BFuDWsIE vtHh8dkQZP7dz6Qy67kx8negZaehSEgXwiae0HwQIn3xTQrFmBDALDsCgXuLWPTvglSkqTak uG+8X5fyTy0cU10TNKsU+rFBO+/xsUoIQOGrARwfWOIfJNPelzh/qigSnyNQNH8u5vFRPg9n fqB/AcvvAvtOYOo8EN9Ofx11gNj397NXc5HBQTrX6k5GNAeBWE3Ng1uO6scIwAS7qGnqGezU ABmQKLN37gmJiiGwhQAnSE6HILLBC5Z2b0S2rQsPKg8WgUmPa1YIcDkDtNB/LJcDsdU4Fm+r U2ksKU7tGD2ZfBt8H2nqfPKKeB+Uv/TBigjRvx/m70vjhqVxwCZA9Fqr9vkQkZroNfqP+3dp Z5V5fjmxO5abE2+IikSvFagwMtgx56i8Yrr2BzE8P5/S4cKq1kgyQoF+lVGDKRkUKCv1i4Fo aftnSxN8jTFZDbkCDQRVcFBfARAAutbzb8wAHGL5FPPWKErQ3Bsrp9RDTVqRzp7kBMOtd/14 MrOsWWyiml4XnvBYsJuhZWomFoeulcOXAPoTJ2vTw6erWYtdOiZymfQ3GMWpxzgkOVeNjsFF 9AQ38FCMKmIDs9dgn+KXSIXlZA34khKLd163SN5U/KHfYlnnocec31u+7rVa1hlF5DBSSpoi s8cs41foBYC5NsB/i+yqGIlfzHy7pC2u5kyQCuJotLH4y0rT5X+YBC7z7cqKChtILNDGw0ht qps29fwOGBE/FWmu8CbpSHj8pvg7uUyQcKbZbNChBfWtOJKdjnNs5VHf2ec95SwYmWl6Xz66 G892HY4ODtvl05/kh0qtdJd2oI4gJBsBx/N1585/3JYN4k78GIHTnML3xJydRRs9wwM3AXf/ iDGrMyY7qHQVXJLdO5nPe7LHg48vryCMkBnTMw5iNFPVCu5w1BaZyHxuS2HvpsgUtQoBa2QE P1jYNI+2qgoiIG4VQDhYtrD0WJaYdi/C2UVDxRy07dt73SV3RQ7ijOiUrz4g3/deFKY16/1k sE+N5Sc5Tjt84ChjO3nJRbHrQxd6dCOElR70e3R2yAuSB4m7LJpO20IB9CtWhlF/0AtfL91W O8GGGqLWB0Z04hmwRs/l8T4WWIlykLshbunWN6jsP1Y27FeilTZ+Pc9mYOEUFfEAEQEAAYkC HwQYAQgACQUCVXBQXwIbDAAKCRBLswjpsC52bPayD/9jE8mdNudrudSxbDB2vf8pU8r5flCq vIkfOdpZGV/Wx/Zx+HFHHp+b2aNBGSNyFTnph1Ku9bvg06vD0o+b7SdA1vrBgRG41t0OCIyf vejz65Xpin2EtCllcBM8zUCxHo43blON8fNw70P1Ec0loBp4TAal1MiXbB8kxRTRcEPVO9YF 9NPsFxycoWl0ZSvu4ESrQlrjRbVv+W0Fy/XqcQwEtDziFQHQXNRbTy8INPD49CsB7BkKRK+f 1vMmw7SxfsyEhyCgo9ZWfHb/+w9T5h+UhF87L/m287z7W+s4aCAPBzjbIWhtngGJJwIgiWdI I9J6YJLcHLvVZLw7xzA/flcjc0VfzOgJOJw3hBukHnEz7/CKgnABwyNu52P+PQbxVTiTjMKm 06eV732u9ZLD9ZgEazfmyGDHzsuzoXwsRnmcnbwYYAiynS+vfGl5oMtMa5qzsPhlzuvRlXHm zr8VjF8c9RThvyZyyHtWYAqNmBecMvM0whigjMeoAMJ5LtpyZgxjbHj1XnVdNBZgfJkOzsc/ twffi7RYphRx0d9z5UZ1Yl5Rvl05vTaJ7YhhNC7xuE8yGOQmDUsPDwWqO/eXUDErJjCOBR5b 0yILqRPYNT0Fj/th9gtEbZy1Gp0TVBkZM3tfjDRu43Pn6iSKObO/j0rNuq1LwN/EMxDifeZO 4XSbcg== Subject: Re: [PATCH] Implement nbsd_nat_target::thread_name Message-ID: <01e11821-bab3-9ae1-ce96-aef249066a45@gmx.com> Date: Wed, 1 Apr 2020 22:17:02 +0200 User-Agent: Mozilla/5.0 (X11; NetBSD amd64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <87imij0zv6.fsf@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:2bnyvgPm3N7PkTGcZWtHTweET+UVkJp7XRLZQ29gbRXTBr0Rw7e /Y0wu5zD2X7hfiTZ+164PPp1yIeVLbyix0ffwuECBHyaaudpWgD94agg5BRYcyi975o1isR fFfeApM7T+y3Hl1Gws5CO0m1O+hV3xLKK6TF3g5GFaNYsglFlqv/OOZCW+Y75S5mme/+7rF GZnNgNhn3+Egir4ybfIrw== X-UI-Out-Filterresults: notjunk:1;V03:K0:JdJmF8j0fpA=:nLZlm7HJvqjgiGUo2Jh+Sj drSEpwNhpqWg95qUFyZmvoJvkc3i/Q754/bzpEYLCYMwrnadcSxMM/PLBUoB1I3xaeZRGlnR0 i3hof9RkbQnmhmUJouILb8mzJ7/TdTVqGsrqwE5X9iOm7QF6tFcMQ60MFlFD1cuH1fv2Ap4Gu ufp0AGiS/CvmUAm0qF+4x087dkKAZAKWFJR2tsaEB5ssD0rm7M7TC0GgpPIAA8T3kL04DHCwg yLVe6fooV4/NkEUNAklHTM4+lVyyFwudMOOg0JwXyO5JCNEyjjCMISpdsvZrgvNb6BjIor8vQ fjQZb3S4cAi+BSTKbXAizgO3TydaF3XRez8Xny7yCz2mGE0Q6R5E1e5TyJsWPU2+cxd3F+FYq nWOOuvNzUVHvBABzxJz4XEVLHr+bo1hXnfTt10JDpC+Uunp4cbZWmcJqxIBhh40ynbNHq3rhV AxnM3ghzbZlsuIswkUTc2Q0iX06N1lI/Q1LfymPjLZvgctPUtHYeySwR9tbTdL4XeL6TxA+Z7 9bNKizlc0AIcLbV3qBwrVys0nfEs5Nfjw3cVQ3RLl86ZIc0Bf5eWWbAxO2pyhuCGrh5FjDN9d sV+7TjhTiwJ4lfMHoCQmnY54jRhNkV1inqD0QlJRGsYpkhFPErusy5KfGbvLLuQRuBNEnLf0P cx3r0W7bLDQXoCK4MRW0DtlraBRThgKL0x4pl6tpAr022mieNk7SDCRwdp4MJCcGOr3VXpVNN VbrH4hqjsWh8Tn1uXNofopKM4/AuuJznqmQdjYMGxsF2y9bkpQY8Vc4+sRyHpp3dkBDQppuRv UaFn43I5CXeETgFjVowYxSLbAXaTQK35w1qiwJpFziBhG94AtJ/XgEW79tx74l1eGdDizWY3p MYFIj+cAYjrXwZ5TgTgYHL5q4/Ms7yI+3f+PWtsvkA+jn84hlYwcoB2tKvg8TGIJpa9qFwoL6 iiy1206ljL6OYC9mE/h3ikIWqVE6pEsW5EOrWGANu+ogqvXlx3IkaWQgpoLCOd0oA5SM1Qazh KUZmesg4gOo3uRu6BT4lioXnKoKb1sOzR+uyGVgZwVEaS5CTvPayeimQqlxmXwNtu9VjInC2j PyhB85/Yd8e8A+I5hCHNygLNgq6ykZ9bmLZhD47RXWtbcu3/zO2TNyNuZYpG9hAEHVNe9FoXe POwI/sylC9yPAgObjqm74skiuVPyviKmFDjDgDTwl+y+hqfI9N1EsWpqCe+ec4fFu9bms= X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Apr 2020 20:18:26 -0000 On 01.04.2020 21:28, Tom Tromey wrote: >>>>>> "Kamil" =3D=3D Kamil Rytarowski writes: > > Kamil> Return the name assigned to a thread by an application. Return > Kamil> the string in a static buffer. > > Thanks for the patch. > > Kamil> + if (sysctl (mib, 5, NULL, &size, NULL, 0) =3D=3D -1 || size = =3D=3D 0) > Kamil> + perror_with_name (("sysctl")); > > I suspect it's better to return NULL there than to throw an exception. > > Kamil> + if (kl =3D=3D NULL) > Kamil> + perror_with_name (("calloc")); > Kamil> + > Kamil> + if (sysctl (mib, 5, kl.get (), &size, NULL, 0) =3D=3D -1 || si= ze =3D=3D 0) > Kamil> + perror_with_name (("sysctl")); > > Likewise in these cases. > > thanks, > Tom > Please check a newer patch: [PATCH v2] Implement basic threading support in the NetBSD target https://sourceware.org/pipermail/gdb-patches/2020-March/167018.html Does this comment still apply to return NULL for thread_name() thread_alive() and update_thread_list()? In practice the kernel will almost never return error when used properly, unless there is specified a wrong process id or similar. It's generally safe to abort on error here.