From: Luis Machado <luis.machado@linaro.org>
To: Simon Marchi <simon.marchi@polymtl.ca>,
Andrew Burgess <andrew.burgess@embecosm.com>,
Mike Frysinger <vapier@gentoo.org>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] sim: switch to autogenerated ChangeLog files
Date: Mon, 11 Jan 2021 14:10:41 -0300 [thread overview]
Message-ID: <02170881-4ce0-da14-a08b-da1264a3b971@linaro.org> (raw)
In-Reply-To: <313988fb-ed42-11f7-1e64-b46005580792@polymtl.ca>
On 1/11/21 2:00 PM, Simon Marchi via Gdb-patches wrote:
> On 2021-01-11 6:05 a.m., Andrew Burgess wrote:
>> I think sim/ should follow the same policy as gdb/ for now. Do feel
>> free to raise this as a suggestion for gdb/ in general though, it
>> would be an interesting conversation to observe.
>
> Last time I tried the gitlog-to-changelog script on GDB, it produced
> horrible results. Probably because it was not designed for C++.
>
> Making a script to produce ChangeLogs for C code is already very
> difficult, making it work with good results for C++ would be even
> worst. And most importantly, I think it would be wasted development
> time.
>
> My opinion is that we should either keep hand-written ChangeLogs, or
> admit that ChangeLogs are not useful and get rid of them altogether
> (and you know which side I lean towards). But auto-generating
> ChangeLogs, other than allowing to check the "we have ChangeLog" box,
> doesn't produce anything useful.
Ever since we moved binutils-gdb to git, ChangeLog's started to feel
like a waste of time. Now, with broader use of C++, it is even worse. It
makes things more verbose and harder for tools to find the right scope
(is the change in a function? A class? A member function?). And the
limit of 80 columns adds to that burden, since we need to watch out for
the length of the line. It feels like a puzzle sometimes.
"git log" produces very useful information, and we make the commit
messages very verbose (more than other projects) so developers can have
a pretty good idea of what has changed and why.
I'm strongly in favor of dropping ChangeLog's from GDB.
next prev parent reply other threads:[~2021-01-11 17:10 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-10 3:37 [PATCH 1/3] src-release: fix indentation Mike Frysinger
2021-01-10 3:37 ` [PATCH 2/3] gnulib: import gitlog-to-changelog Mike Frysinger
2021-01-11 11:06 ` Andrew Burgess
2021-01-10 3:42 ` [PATCH] sim: switch to autogenerated ChangeLog files Mike Frysinger
2021-01-11 11:05 ` Andrew Burgess
2021-01-11 17:00 ` Simon Marchi
2021-01-11 17:10 ` Luis Machado [this message]
2021-01-11 17:31 ` Christian Biesinger
2021-01-11 19:38 ` Mike Frysinger
2021-01-11 19:54 ` Simon Marchi
2021-01-11 20:35 ` Mike Frysinger
2021-01-12 10:47 ` Andrew Burgess
2021-01-12 18:14 ` Joseph Myers
2021-01-12 18:27 ` Eli Zaretskii
2021-01-12 18:40 ` Eli Zaretskii
2021-01-12 21:27 ` Mike Frysinger
2021-01-12 21:22 ` Mike Frysinger
2021-03-09 5:51 ` Mike Frysinger
2021-03-09 9:42 ` Andrew Burgess
2021-03-17 14:22 ` Luis Machado
2021-01-12 23:20 ` [PATCH 1/3] src-release: fix indentation Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=02170881-4ce0-da14-a08b-da1264a3b971@linaro.org \
--to=luis.machado@linaro.org \
--cc=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).