From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt1-x833.google.com (mail-qt1-x833.google.com [IPv6:2607:f8b0:4864:20::833]) by sourceware.org (Postfix) with ESMTPS id 6E4D4386102D for ; Mon, 11 Jan 2021 17:10:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 6E4D4386102D Received: by mail-qt1-x833.google.com with SMTP id c1so220095qtc.1 for ; Mon, 11 Jan 2021 09:10:45 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=VVHDHIls42cb1n8KcFNxdzDHA4TamttZKyF8HzDPwWs=; b=O2A2dpCu8nDJW5LOH7Y4sGqNfhvr9rED2OesDPsaBSUvCBY8P7mrExyEt0ItudS6nH dhsDl/oCrktXIGQR2cbJ0UcCkU55oPWC9jedqcpy0hLGSKAcyuJV5B9Ge65pxrNChdZI bDYaS72Agxn0ir9XCJ5eze5j9HWnSkdkH2t+0ooU8oVhPOVn6pYWlneucyx6GcK9upsi CBuzjZrYy7NNuIvo67zixS5dMzBC73QBKGUgaij44LdRcaFsMsjMpjDdEVHpO0HLqamT 2ZTt55JkHrkYrp0kJ2cMBLh33iTyBQ2Ifpv79rEJkpayldoK6DOcQruy19/5iWAvSIDg Vokg== X-Gm-Message-State: AOAM532cdZLPIaL2Odqf1A0IAbOcR8Q0SpNfmHeLe54gBlIHDq8M34hq e1B+lvRP3CAByUxvu2OvDA3egKX0sm0GkQ== X-Google-Smtp-Source: ABdhPJxc78ZjPq311563+Ip90HG/vwCvH9Rd5oa7zO9nw5Mn3WrxOPKfyKwrrKlKL/9dNllMlf7Rmw== X-Received: by 2002:ac8:7111:: with SMTP id z17mr528231qto.369.1610385044763; Mon, 11 Jan 2021 09:10:44 -0800 (PST) Received: from ?IPv6:2804:7f0:8284:874d:20e9:a3d4:1db5:c30a? ([2804:7f0:8284:874d:20e9:a3d4:1db5:c30a]) by smtp.gmail.com with ESMTPSA id 6sm216912qko.3.2021.01.11.09.10.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 11 Jan 2021 09:10:44 -0800 (PST) Subject: Re: [PATCH] sim: switch to autogenerated ChangeLog files To: Simon Marchi , Andrew Burgess , Mike Frysinger Cc: gdb-patches@sourceware.org References: <20210110033752.6002-1-vapier@gentoo.org> <20210110034223.6268-1-vapier@gentoo.org> <20210111110544.GC1151657@embecosm.com> <313988fb-ed42-11f7-1e64-b46005580792@polymtl.ca> From: Luis Machado Message-ID: <02170881-4ce0-da14-a08b-da1264a3b971@linaro.org> Date: Mon, 11 Jan 2021 14:10:41 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <313988fb-ed42-11f7-1e64-b46005580792@polymtl.ca> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Jan 2021 17:10:46 -0000 On 1/11/21 2:00 PM, Simon Marchi via Gdb-patches wrote: > On 2021-01-11 6:05 a.m., Andrew Burgess wrote: >> I think sim/ should follow the same policy as gdb/ for now. Do feel >> free to raise this as a suggestion for gdb/ in general though, it >> would be an interesting conversation to observe. > > Last time I tried the gitlog-to-changelog script on GDB, it produced > horrible results. Probably because it was not designed for C++. > > Making a script to produce ChangeLogs for C code is already very > difficult, making it work with good results for C++ would be even > worst. And most importantly, I think it would be wasted development > time. > > My opinion is that we should either keep hand-written ChangeLogs, or > admit that ChangeLogs are not useful and get rid of them altogether > (and you know which side I lean towards). But auto-generating > ChangeLogs, other than allowing to check the "we have ChangeLog" box, > doesn't produce anything useful. Ever since we moved binutils-gdb to git, ChangeLog's started to feel like a waste of time. Now, with broader use of C++, it is even worse. It makes things more verbose and harder for tools to find the right scope (is the change in a function? A class? A member function?). And the limit of 80 columns adds to that burden, since we need to watch out for the length of the line. It feels like a puzzle sometimes. "git log" produces very useful information, and we make the commit messages very verbose (more than other projects) so developers can have a pretty good idea of what has changed and why. I'm strongly in favor of dropping ChangeLog's from GDB.