From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 26D0B385457F for ; Fri, 18 Nov 2022 15:56:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 26D0B385457F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca Received: from [10.0.0.11] (unknown [217.28.27.60]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 955C71E0CB; Fri, 18 Nov 2022 10:56:42 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1668787002; bh=WibXRkriix9ynXiPRpH/d54uV/JIABhh9JQO/+JgCeY=; h=Date:Subject:To:References:From:In-Reply-To:From; b=Ilcoh0OM7coSEIlFuPQ10DmxCHxi+qIwRtypFZBZCX003kiIyYNWCQh2ePmvt1UKJ OmtF49YIsdo4NM4xv5O1swd9TIja8nuY7ARlFnVGhzroikqRnH1C5eImh7JEDsR6kT iD5NhtY4VM3erYWOhcevafNgg0Fr+4RXBAcRyWSw= Message-ID: <02243db7-df98-47f6-40a0-3f774ccf9e8f@simark.ca> Date: Fri, 18 Nov 2022 10:56:42 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v4] [PR python/18655] Fix deletion of FinishBreakpoints Content-Language: en-US To: Johnson Sun , BrunoLarsen , gdb-patches@sourceware.org References: <20221020173411.190318-1-j3.soon777@gmail.com> <20221020174917.192860-1-j3.soon777@gmail.com> From: Simon Marchi In-Reply-To: <20221020174917.192860-1-j3.soon777@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 10/20/22 13:49, Johnson Sun wrote: > Currently, FinishBreakpoints are set at the return address of a frame based on > the `finish' command, and are meant to be temporary breakpoints. However, they > are not being cleaned up after use, as reported in PR python/18655. This was > happening because the disposition of the breakpoint was not being set > correctly. > > This commit fixes this issue by correctly setting the disposition in the > post-stop hook of the breakpoint. It also adds a test to ensure this feature > isn't regressed in the future. > > Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=18655 Thanks, I see your copyright assignment is complete. I pushed the patch. Simon