From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-sender-0.a4lg.com (mail-sender-0.a4lg.com [IPv6:2401:2500:203:30b:4000:6bfe:4757:0]) by sourceware.org (Postfix) with ESMTPS id 55C1C385840A for ; Mon, 24 Oct 2022 10:51:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 55C1C385840A Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=irq.a4lg.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=irq.a4lg.com Received: from [127.0.0.1] (localhost [127.0.0.1]) by mail-sender-0.a4lg.com (Postfix) with ESMTPSA id 76FB0300089; Mon, 24 Oct 2022 10:50:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=irq.a4lg.com; s=2017s01; t=1666608659; bh=OHG2s66QHHmszLf/6D7jRmsG0coV9wJnVJ0FEpUbLoQ=; h=Message-ID:Date:Mime-Version:Subject:To:References:From: In-Reply-To:Content-Type:Content-Transfer-Encoding; b=S8Imx1N61oNkB2wleTaKLOGsy1ZSTn9g4VZ+Rve8BToYumqH3YupDaw9Wf1hDTCLM d8iHY3dDGGIEbAkdq/x+mt02B1g8F87vwNAizNcHqwUrJSIkKY6Rxjpgq23RihiwZS mZsg+ShPsIK0GpO7fmKeGRkDV4pjryYCZzgSWS1w= Message-ID: <02420829-7289-3208-4a2f-123dd11a5626@irq.a4lg.com> Date: Mon, 24 Oct 2022 19:50:57 +0900 Mime-Version: 1.0 Subject: Re: [PATCH 4/4] sim: Suppress non-literal printf warning Content-Language: en-US To: Mike Frysinger , gdb-patches@sourceware.org References: <35eaee9855aa3882a1ecc9de9d62c0f8b2fe0e7c.1663073826.git.research_trasio@irq.a4lg.com> <87h70ifq8c.fsf@redhat.com> <22f70b64-0bf9-96f8-a734-d16bbec6504a@irq.a4lg.com> From: Tsukasa OI In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,GIT_PATCH_0,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2022/10/23 21:22, Mike Frysinger wrote: > On 06 Oct 2022 14:39, Tsukasa OI via Gdb-patches wrote: >> On 2022/10/05 20:45, Andrew Burgess wrote: >>> Tsukasa OI writes: >>>> Clang generates a warning if the format parameter of a printf-like function >>>> is not a literal. However, on hw_vabort, it's unavoidable to use non- >>>> literal as a format string (unless we make huge redesign). >>>> >>>> We have "include/diagnostics.h" to suppress certain warnings only when >>>> necessary. Because DIAGNOSTIC_IGNORE_FORMAT_NONLITERAL can suppress >>>> warnings when the format parameter of a printf-like function is not a >>>> literal, this commit adds this (only where necessary) to suppress this >>>> error with "-Werror", the default configuration. >>>> >>>> sim/ChangeLog: >>>> >>>> * common/sim-hw.c (hw_vabort): Suppress non-literal printf warning >>>> by using DIAGNOSTIC_IGNORE_FORMAT_NONLITERAL. >>>> --- >>>> sim/common/sim-hw.c | 3 +++ >>>> 1 file changed, 3 insertions(+) >>>> >>>> diff --git a/sim/common/sim-hw.c b/sim/common/sim-hw.c >>>> index cece5638bc9..36f355d2262 100644 >>>> --- a/sim/common/sim-hw.c >>>> +++ b/sim/common/sim-hw.c >>>> @@ -425,10 +425,13 @@ hw_vabort (struct hw *me, >>>> strcat (msg, ": "); >>>> strcat (msg, fmt); >>>> /* report the problem */ >>>> + DIAGNOSTIC_PUSH >>>> + DIAGNOSTIC_IGNORE_FORMAT_NONLITERAL >>>> sim_engine_vabort (hw_system (me), >>>> STATE_HW (hw_system (me))->cpu, >>>> STATE_HW (hw_system (me))->cia, >>>> msg, ap); >>>> + DIAGNOSTIC_POP >>> >>> Rather than disabling diagnostics, I'd like to propose the patch below >>> which expands FMT and AP within sim-hw.c, then passes the expanded >>> string through to sim_engine_abort. What do you think of this? >> >> Ah, It took a while to understand but makes sense to me. >> >> I just needed to add ATTRIBUTE_PRINTF (2, 0) to suppress "-Werror >> -Wformat-nonliteral" but I prefer to use your patch instead. > > adding ATTRIBUTE_PRINTF doesn't suppress warnings, it fixes them > -mike Correct. I'm focusing on fixing "build failures caused by Clang warnings" and I think I wrote commit messages without considering why warnings are gone. Thanks for pointing this out. Tsukasa