From: Simon Marchi <simark@simark.ca>
To: Roland McGrath <mcgrathr@google.com>, GDB <gdb-patches@sourceware.org>
Subject: Re: [COMMITTED PATCH] [aarch64] Avoid initializers for VLAs
Date: Thu, 9 Feb 2023 14:13:52 -0500 [thread overview]
Message-ID: <02654c79-55cc-1f50-a3c6-4f1b62334399@simark.ca> (raw)
In-Reply-To: <CAB=4xhqBjK74FgnW+87W0G+Rsmxm8vc106X3Nc7nDOCGGPoSAg@mail.gmail.com>
On 2/9/23 14:06, Roland McGrath via Gdb-patches wrote:
> C99 does not permit initializers for variable length arrays, and Clang
> now enforces this.
> Committed as obvious enough.
>
> commit b695fdd9b2494a64db1fb8e584753a1a5afec494 (HEAD -> master)
> Author: Roland McGrath <mcgrathr@google.com>
> Date: Thu Feb 9 10:47:17 2023 -0800
>
> [aarch64] Avoid initializers for VLAs
>
> Clang doesn't accept initializer syntax for variable-length
> arrays in C. Just use memset instead.
"C99" and "C" don't really make sense, since this is C++. Perhaps it's
the same error in C++, but the message is a bit misleading.
It's too late for this one, but when fixing a compilation error, please
put the compiler error in the commit message.
>
> diff --git a/gdb/aarch64-linux-nat.c b/gdb/aarch64-linux-nat.c
> index e4158236db2..ecb2eeb9540 100644
> --- a/gdb/aarch64-linux-nat.c
> +++ b/gdb/aarch64-linux-nat.c
> @@ -56,6 +56,8 @@
>
> #include "nat/aarch64-mte-linux-ptrace.h"
>
> +#include <string.h>
> +
> #ifndef TRAP_HWBKPT
> #define TRAP_HWBKPT 0x0004
> #endif
> @@ -445,7 +447,9 @@ fetch_tlsregs_from_thread (struct regcache *regcache)
> gdb_assert (regno != -1);
> gdb_assert (tdep->tls_register_count > 0);
>
> - uint64_t tpidrs[tdep->tls_register_count] = { 0 };
> + uint64_t tpidrs[tdep->tls_register_count];
> + memset(tpidrs, 0, sizeof(tpidrs));
Missing space before parentheses.
> +
> struct iovec iovec;
> iovec.iov_base = tpidrs;
> iovec.iov_len = sizeof (tpidrs);
> @@ -471,7 +475,8 @@ store_tlsregs_to_thread (struct regcache *regcache)
> gdb_assert (regno != -1);
> gdb_assert (tdep->tls_register_count > 0);
>
> - uint64_t tpidrs[tdep->tls_register_count] = { 0 };
> + uint64_t tpidrs[tdep->tls_register_count];
> + memset(tpidrs, 0, sizeof(tpidrs));
Same.
Simon
next prev parent reply other threads:[~2023-02-09 19:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-09 19:06 Roland McGrath
2023-02-09 19:13 ` Simon Marchi [this message]
2023-02-09 22:51 ` Luis Machado
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=02654c79-55cc-1f50-a3c6-4f1b62334399@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=mcgrathr@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).