From: Nick Clifton <nickc@redhat.com>
To: Binutils <binutils@sourceware.org>, gdb-patches@sourceware.org
Cc: Tzvetelin Katchov <katchov@gnu.org>
Subject: RFC: Sort tarballs created by the src-release.sh script
Date: Wed, 28 Sep 2022 13:59:27 +0100 [thread overview]
Message-ID: <02ea8f50-7b68-6c4e-75db-e919121e8707@redhat.com> (raw)
Hi Guys,
A contributor recently pointed out that the binutils release tarballs are
not sorted by name, making it hard to reproducibly recreate them. At first
we thought that using tar's --sort=name option would solve this, but it
turns out that the src-release.sh script creates its own list of input file
names, so instead I am proposing this patch:
diff --git a/src-release.sh b/src-release.sh
index 079b545ae7c..caae5148034 100755
--- a/src-release.sh
+++ b/src-release.sh
@@ -185,7 +185,7 @@ do_tar()
echo "==> Making $package-$ver.tar"
rm -f $package-$ver.tar
find $package-$ver -follow \( $CVS_NAMES \) -prune \
- -o -type f -print \
+ -o -type f -print | sort \
| tar cTfh - $package-$ver.tar
}
Any comments or objections ?
Cheers
Nick
next reply other threads:[~2022-09-28 12:59 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-28 12:59 Nick Clifton [this message]
2022-09-28 13:05 ` Andreas Schwab
2022-09-28 13:34 ` Nick Clifton
2022-09-29 12:24 ` Nick Clifton
2022-09-29 12:36 ` Jan Beulich
2022-09-30 11:38 ` Nick Clifton
2022-10-02 7:54 ` Sam James
2022-10-02 7:54 ` Sam James
2022-10-03 6:55 ` Jan Beulich
2022-10-03 6:59 ` Sam James
2022-10-03 7:41 ` Andreas Schwab
2022-10-03 14:40 ` Nick Clifton
2022-10-03 19:56 ` Andreas Schwab
2022-10-04 7:10 ` Jan Beulich
2022-10-05 12:23 ` Nick Clifton
2022-10-05 13:00 ` Jan Beulich
2022-10-03 7:47 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=02ea8f50-7b68-6c4e-75db-e919121e8707@redhat.com \
--to=nickc@redhat.com \
--cc=binutils@sourceware.org \
--cc=gdb-patches@sourceware.org \
--cc=katchov@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).