From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from re-prd-fep-041.btinternet.com (mailomta27-re.btinternet.com [213.120.69.120]) by sourceware.org (Postfix) with ESMTPS id C03C53858285 for ; Fri, 4 Nov 2022 14:28:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C03C53858285 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=dronecode.org.uk Authentication-Results: sourceware.org; spf=none smtp.mailfrom=dronecode.org.uk Received: from re-prd-rgout-002.btmx-prd.synchronoss.net ([10.2.54.5]) by re-prd-fep-041.btinternet.com with ESMTP id <20221104142826.ZNEX9588.re-prd-fep-041.btinternet.com@re-prd-rgout-002.btmx-prd.synchronoss.net>; Fri, 4 Nov 2022 14:28:26 +0000 Authentication-Results: btinternet.com; auth=pass (PLAIN) smtp.auth=jonturney@btinternet.com; bimi=skipped X-SNCR-Rigid: 613A8DE84104A5D5 X-Originating-IP: [81.153.98.206] X-OWM-Source-IP: 81.153.98.206 (GB) X-OWM-Env-Sender: jonturney@btinternet.com X-VadeSecure-score: verdict=clean score=0/300, class=clean X-RazorGate-Vade: gggruggvucftvghtrhhoucdtuddrgedvgedrvddugdeivdcutefuodetggdotefrodftvfcurfhrohhfihhlvgemuceutffkvffkuffjvffgnffgvefqofdpqfgfvfenuceurghilhhouhhtmecufedtudenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurheptgfkffggfgfuvfhfhfgjsehmtderredtfeejnecuhfhrohhmpeflohhnucfvuhhrnhgvhicuoehjohhnrdhtuhhrnhgvhiesughrohhnvggtohguvgdrohhrghdruhhkqeenucggtffrrghtthgvrhhnpeehhfeigeeukedtgfefkeelgedvgeffvdejheevgfffgfduveejffelvedtffekfeenucfkphepkedurdduheefrdelkedrvddtieenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhephhgvlhhopegludelvddrudeikedruddruddtiegnpdhinhgvthepkedurdduheefrdelkedrvddtiedpmhgrihhlfhhrohhmpehjohhnrdhtuhhrnhgvhiesughrohhnvggtohguvgdrohhrghdruhhkpdhnsggprhgtphhtthhopedvpdhrtghpthhtohepghgusgdqphgrthgthhgvshesshhouhhrtggvfigrrhgvrdhorhhgpdhrtghpthhtohepthhrohhmvgihsegruggrtghorhgvrdgtohhm X-RazorGate-Vade-Verdict: clean 0 X-RazorGate-Vade-Classification: clean Received: from [192.168.1.106] (81.153.98.206) by re-prd-rgout-002.btmx-prd.synchronoss.net (5.8.716.04) (authenticated as jonturney@btinternet.com) id 613A8DE84104A5D5; Fri, 4 Nov 2022 14:28:26 +0000 Content-Type: multipart/mixed; boundary="------------ZA3DOHhrh7M6J60nutrzHIYz" Message-ID: <02f9d01b-1a0c-a9be-6e0d-bf06ab02da74@dronecode.org.uk> Date: Fri, 4 Nov 2022 14:28:26 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH 2/2] Implement target async for Windows Content-Language: en-GB To: Tom Tromey , gdb-patches@sourceware.org References: <20220803130822.735057-1-tromey@adacore.com> <20220803130822.735057-3-tromey@adacore.com> From: Jon Turney In-Reply-To: <20220803130822.735057-3-tromey@adacore.com> X-Spam-Status: No, score=-1196.9 required=5.0 tests=BAYES_00,FORGED_SPF_HELO,GIT_PATCH_0,KAM_DMARC_STATUS,KAM_LAZY_DOMAIN_SECURITY,NICE_REPLY_A,RCVD_IN_BARRACUDACENTRAL,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This is a multi-part message in MIME format. --------------ZA3DOHhrh7M6J60nutrzHIYz Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 03/08/2022 14:08, Tom Tromey via Gdb-patches wrote: > This implements target async for Windows. The basic idea is to have > the worker thread block in WaitForDebugEvent, then notify the event > loop when an event is seen. In a few situations, this blocking > behavior is undesirable, so the functions passed to do_synchronously > are changed to return a boolean indicating which behavior is needed. > --- > gdb/windows-nat.c | 123 ++++++++++++++++++++++++++++++++++++++++------ > 1 file changed, 108 insertions(+), 15 deletions(-) > > diff --git a/gdb/windows-nat.c b/gdb/windows-nat.c > index 80cdedce7b9..9c277e9a93d 100644 > --- a/gdb/windows-nat.c > +++ b/gdb/windows-nat.c > @@ -34,6 +34,7 @@ > #include > #include > #include > +#include > #include > #include > #ifdef __CYGWIN__ This breaks the build on Cygwin, as including both winsock2 and Cygwin's sys/select.h is a big no-no. I'm going to suggest the attached to fix this, but from a quick reading of the patch, I just wonder if winsock2.h is actually needed at all, as I don't immediately see anything that leaps out as needing it... --------------ZA3DOHhrh7M6J60nutrzHIYz Content-Type: text/plain; charset=UTF-8; name="0001-Fix-Cygwin-build-after-d08bae3d.patch" Content-Disposition: attachment; filename="0001-Fix-Cygwin-build-after-d08bae3d.patch" Content-Transfer-Encoding: base64 RnJvbSBjNGQzNWFhMzYzYTgwMzc3NDZhZThiZDE3ZjdiNTlmM2M1ODFlNjlmIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKb24gVHVybmV5IDxqb24udHVybmV5QGRyb25lY29k ZS5vcmcudWs+CkRhdGU6IFdlZCwgMiBOb3YgMjAyMiAxNDozMjo1NSArMDAwMApTdWJqZWN0 OiBbUEFUQ0hdIEZpeCBDeWd3aW4gYnVpbGQgYWZ0ZXIgZDA4YmFlM2QKCkNvbW1pdCBkMDhi YWUzZCAoIkltcGxlbWVudCB0YXJnZXQgYXN5bmMgZm9yIFdpbmRvd3MiKSB1bmNvbmRpdGlv bmFsbHkKaW5jbHVkZXMgd2luc29jazIuaC4gIERvbid0IGRvIHRoaXMgb24gQ3lnd2luLCBz aW5jZSB3ZSBkb24ndCB3YW50IHRvCnVzZSBXaW5kb3dzIHNvY2tldCBmdW5jdGlvbnMuCi0t LQogZ2RiL3dpbmRvd3MtbmF0LmMgfCAyICsrCiAxIGZpbGUgY2hhbmdlZCwgMiBpbnNlcnRp b25zKCspCgpkaWZmIC0tZ2l0IGEvZ2RiL3dpbmRvd3MtbmF0LmMgYi9nZGIvd2luZG93cy1u YXQuYwppbmRleCBhYjk0ZGUwM2JiZi4uNzM0MmM3MWQ3ZGIgMTAwNjQ0Ci0tLSBhL2dkYi93 aW5kb3dzLW5hdC5jCisrKyBiL2dkYi93aW5kb3dzLW5hdC5jCkBAIC0zNCw3ICszNCw5IEBA CiAjaW5jbHVkZSA8c2lnbmFsLmg+CiAjaW5jbHVkZSA8c3lzL3R5cGVzLmg+CiAjaW5jbHVk ZSA8ZmNudGwuaD4KKyNpZm5kZWYgX19DWUdXSU5fXwogI2luY2x1ZGUgPHdpbnNvY2syLmg+ CisjZW5kaWYKICNpbmNsdWRlIDx3aW5kb3dzLmg+CiAjaW5jbHVkZSA8aW1hZ2VobHAuaD4K ICNpZmRlZiBfX0NZR1dJTl9fCi0tIAoyLjM4LjEKCg== --------------ZA3DOHhrh7M6J60nutrzHIYz--