From: Pedro Alves <palves@redhat.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 3/3] gdbserver/Windows: crash during connection establishment phase
Date: Wed, 09 May 2018 23:17:00 -0000 [thread overview]
Message-ID: <0323b442-a7b5-e853-bf66-2e69e1ec13a1@redhat.com> (raw)
In-Reply-To: <20180509215734.a3yajpbtsjj2johb@adacore.com>
On 05/09/2018 10:57 PM, Joel Brobecker wrote:
>>> What do you think of the following approach? The idea is to make
>>> sure we never forget to set the expedite_regs field when we initialize
>>> the tdesc.
>>
>> Thanks, this looks good to me.
>
> Thanks, Pedro. Does it mean the first two look OK to you as well,
> or should I wait for specific review.
Let me take a look. I think I have a question about patch #2.
> Given that GDBserver appears
> to have been broken for quite a while, I don't think we are in any
> kind of hurry... Unless we decide to backport to 8.1.1?
I think backporting would be good.
Thanks,
Pedro Alves
next prev parent reply other threads:[~2018-05-09 23:08 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-04 18:30 [Windows GDBserver] Make GDBserver functional again on Windows Joel Brobecker
2018-05-04 18:30 ` [PATCH 2/3] gdbserver/Windows: Fix "no program to debug" error Joel Brobecker
2018-05-10 0:09 ` Pedro Alves
2018-05-10 16:50 ` Joel Brobecker
2018-05-04 18:30 ` [PATCH 3/3] gdbserver/Windows: crash during connection establishment phase Joel Brobecker
2018-05-04 18:46 ` Pedro Alves
2018-05-04 18:58 ` Joel Brobecker
2018-05-04 19:12 ` Pedro Alves
2018-05-07 21:47 ` Joel Brobecker
2018-05-09 15:54 ` Pedro Alves
2018-05-09 23:09 ` Joel Brobecker
2018-05-09 23:17 ` Pedro Alves [this message]
2018-05-10 17:04 ` Joel Brobecker
2018-05-04 20:20 ` Eli Zaretskii
2018-05-04 18:30 ` [PATCH 1/3] [gdbserver/win32] fatal "glob could not process pattern '(null)'" error Joel Brobecker
2018-05-09 23:50 ` Pedro Alves
2018-05-10 16:48 ` Joel Brobecker
2018-05-04 18:41 ` [Windows GDBserver] Make GDBserver functional again on Windows Sergio Durigan Junior
2018-05-04 18:54 ` Joel Brobecker
2018-05-10 18:19 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0323b442-a7b5-e853-bf66-2e69e1ec13a1@redhat.com \
--to=palves@redhat.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).