From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28574 invoked by alias); 9 May 2018 23:08:03 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 28561 invoked by uid 89); 9 May 2018 23:08:02 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS autolearn=no version=3.3.2 spammy=backporting X-HELO: mx1.redhat.com Received: from mx3-rdu2.redhat.com (HELO mx1.redhat.com) (66.187.233.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 09 May 2018 23:08:01 +0000 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 63196EC01A; Wed, 9 May 2018 23:08:00 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id CA90F10F1C19; Wed, 9 May 2018 23:07:59 +0000 (UTC) Subject: Re: [PATCH 3/3] gdbserver/Windows: crash during connection establishment phase To: Joel Brobecker References: <1525458603-33351-1-git-send-email-brobecker@adacore.com> <1525458603-33351-4-git-send-email-brobecker@adacore.com> <8700c375-c37b-9e59-d069-d62b6043b112@redhat.com> <20180504185818.htyn2gj2xx5i5s7f@adacore.com> <03cdded5-9f4e-fc1a-366a-1be7cd8b1837@redhat.com> <20180507214700.repkytrxbswql6z2@adacore.com> <3894bcb0-d2e6-7103-86dc-add689af07b0@redhat.com> <20180509215734.a3yajpbtsjj2johb@adacore.com> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: <0323b442-a7b5-e853-bf66-2e69e1ec13a1@redhat.com> Date: Wed, 09 May 2018 23:17:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180509215734.a3yajpbtsjj2johb@adacore.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-05/txt/msg00226.txt.bz2 On 05/09/2018 10:57 PM, Joel Brobecker wrote: >>> What do you think of the following approach? The idea is to make >>> sure we never forget to set the expedite_regs field when we initialize >>> the tdesc. >> >> Thanks, this looks good to me. > > Thanks, Pedro. Does it mean the first two look OK to you as well, > or should I wait for specific review. Let me take a look. I think I have a question about patch #2. > Given that GDBserver appears > to have been broken for quite a while, I don't think we are in any > kind of hurry... Unless we decide to backport to 8.1.1? I think backporting would be good. Thanks, Pedro Alves