From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23458 invoked by alias); 18 Nov 2013 09:37:24 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 23448 invoked by uid 89); 18 Nov 2013 09:37:23 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.2 required=5.0 tests=AWL,BAYES_50,RDNS_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no version=3.3.2 X-HELO: mga09.intel.com Received: from Unknown (HELO mga09.intel.com) (134.134.136.24) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 18 Nov 2013 09:36:55 +0000 Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP; 18 Nov 2013 01:33:13 -0800 X-ExtLoop1: 1 Received: from irsmsx101.ger.corp.intel.com ([163.33.3.153]) by orsmga002.jf.intel.com with ESMTP; 18 Nov 2013 01:36:46 -0800 Received: from irsmsx151.ger.corp.intel.com (163.33.192.59) by IRSMSX101.ger.corp.intel.com (163.33.3.153) with Microsoft SMTP Server (TLS) id 14.3.123.3; Mon, 18 Nov 2013 09:36:45 +0000 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.215]) by IRSMSX151.ger.corp.intel.com ([169.254.4.126]) with mapi id 14.03.0123.003; Mon, 18 Nov 2013 09:36:45 +0000 From: "Agovic, Sanimir" To: 'Tom Tromey' CC: "gdb-patches@sourceware.org" Subject: RE: [PATCH 01/10] vla: introduce new bound type abstraction adapt uses Date: Mon, 18 Nov 2013 11:15:00 -0000 Message-ID: <0377C58828D86C4588AEEC42FC3B85A7176B682C@IRSMSX105.ger.corp.intel.com> References: <1382366424-21010-1-git-send-email-sanimir.agovic@intel.com> <1382366424-21010-2-git-send-email-sanimir.agovic@intel.com> <87iow4um4k.fsf@fleche.redhat.com> In-Reply-To: <87iow4um4k.fsf@fleche.redhat.com> Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2013-11/txt/msg00457.txt.bz2 Thanks for your review. All your comments being addressed and part of v2, see below. -Sanimir > -----Original Message----- > From: Tom Tromey [mailto:tromey@redhat.com] > Sent: Thursday, November 07, 2013 07:02 PM > To: Agovic, Sanimir > Cc: gdb-patches@sourceware.org > Subject: Re: [PATCH 01/10] vla: introduce new bound type abstraction adap= t uses >=20 > Sanimir> + low.data.const_val =3D dwarf2_get_attr_constant_value (attr, > low.data.const_val); >=20 > This line is too long and should be wrapped. > Done >=20 > Sanimir> +struct type * > Sanimir> +create_range_type_1 (struct type *result_type, struct type *ind= ex_type, > Sanimir> + const struct dwarf2_prop *low_bound, > Sanimir> + const struct dwarf2_prop *high_bound) > Sanimir> +{ >=20 > This needs an introductory comment. >=20 Done.=20 > Sanimir> +/* Used to store bound information for a type. */ > Sanimir> + > Sanimir> +struct dwarf2_prop > Sanimir> +{ > Sanimir> + /* Determine which field of the union dwarf2_prop.data is use= d. */ > Sanimir> + enum > Sanimir> + { > Sanimir> + DWARF_CONST, > Sanimir> + DWARF_LOCEXPR, > Sanimir> + DWARF_LOCLIST > Sanimir> + } kind; > Sanimir> + > Sanimir> + /* Stores information as location expression, location list, > Sanimir> + or constant value. */ > Sanimir> + union data > Sanimir> + { > Sanimir> + LONGEST const_val; > Sanimir> + struct dwarf2_locexpr_baton *locexpr; > Sanimir> + struct dwarf2_loclist_baton *loclist; > Sanimir> + } data; > Sanimir> +}; >=20 > Sanimir> @@ -589,11 +612,11 @@ struct main_type > Sanimir> { > Sanimir> /* Low bound of range. */ >=20 > Sanimir> - LONGEST low; > Sanimir> + struct dwarf2_prop low; >=20 > Sanimir> /* High bound of range. */ >=20 > Sanimir> - LONGEST high; > Sanimir> + struct dwarf2_prop high; >=20 >=20 > Just after this hunk of "struct range_bounds" is this code: >=20 > /* Flags indicating whether the values of low and high are > valid. When true, the respective range value is > undefined. Currently used only for FORTRAN arrays. */ >=20 > char low_undefined; > char high_undefined; >=20 > It seems to me that it would be cleanest to make this a new value of the > enum you introduced, like "DWARF_UNDEFINED", and update a few macros to > follow. What do you think? >=20 Agreed. Added DWARF_UNDEFINED and updated macro & uses. -Sanimir Intel GmbH Dornacher Strasse 1 85622 Feldkirchen/Muenchen, Deutschland Sitz der Gesellschaft: Feldkirchen bei Muenchen Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk Registergericht: Muenchen HRB 47456 Ust.-IdNr./VAT Registration No.: DE129385895 Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052