From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3386 invoked by alias); 16 Jan 2014 17:01:56 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 3377 invoked by uid 89); 16 Jan 2014 17:01:55 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mga02.intel.com Received: from mga02.intel.com (HELO mga02.intel.com) (134.134.136.20) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 16 Jan 2014 17:01:54 +0000 Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP; 16 Jan 2014 09:01:18 -0800 X-ExtLoop1: 1 Received: from irsmsx103.ger.corp.intel.com ([163.33.3.157]) by orsmga001.jf.intel.com with ESMTP; 16 Jan 2014 09:00:50 -0800 Received: from irsmsx106.ger.corp.intel.com (163.33.3.31) by IRSMSX103.ger.corp.intel.com (163.33.3.157) with Microsoft SMTP Server (TLS) id 14.3.123.3; Thu, 16 Jan 2014 17:00:49 +0000 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.215]) by IRSMSX106.ger.corp.intel.com ([169.254.8.188]) with mapi id 14.03.0123.003; Thu, 16 Jan 2014 17:00:29 +0000 From: "Agovic, Sanimir" To: 'Tom Tromey' CC: "palves@redhat.com" , "xdje42@gmail.com" , "gdb-patches@sourceware.org" , "Boell, Keven" Subject: RE: [PATCH v4 02/13] type: add c99 variable length array support Date: Thu, 16 Jan 2014 17:01:00 -0000 Message-ID: <0377C58828D86C4588AEEC42FC3B85A7176D364C@IRSMSX105.ger.corp.intel.com> References: <1387282678-3847-1-git-send-email-sanimir.agovic@intel.com> <1387282678-3847-3-git-send-email-sanimir.agovic@intel.com> <87eh49osy8.fsf@fleche.redhat.com> In-Reply-To: <87eh49osy8.fsf@fleche.redhat.com> Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2014-01/txt/msg00618.txt.bz2 Thanks for your review. > -----Original Message----- > From: Tom Tromey [mailto:tromey@redhat.com] > Sent: Wednesday, January 15, 2014 10:07 PM > To: Agovic, Sanimir > Cc: palves@redhat.com; xdje42@gmail.com; gdb-patches@sourceware.org; Boel= l, Keven > Subject: Re: [PATCH v4 02/13] type: add c99 variable length array support >=20 > >>>>> "Sanimir" =3D=3D Sanimir Agovic writes: >=20 > Sanimir> +int > Sanimir> +dwarf2_evaluate_property (const struct dynamic_prop *prop, CORE= _ADDR address, > Sanimir> + CORE_ADDR *value) > Sanimir> +{ > [...] > Sanimir> + if (!value_optimized_out (val)) > Sanimir> + *value =3D value_as_long (value_ind (val)); > Sanimir> + } > Sanimir> + return 1; >=20 > This particular branch can return 1 but not set *value. > That seems wrong. >=20 Fixed. > Sanimir> + else if (attr_form_is_block (target_attr)) > Sanimir> + { > Sanimir> + const gdb_byte ops[] =3D {DW_OP_deref}; > Sanimir> + > Sanimir> + baton =3D obstack_alloc (obstack, sizeof (*baton)); > Sanimir> + baton->locexpr =3D block_to_locexpr_baton (DW_BLOCK (target_= attr), > Sanimir> + cu, ops, sizeof (ops)); >=20 > I noted in an earlier review that I think this approach will not work. > Not sure if I'm misunderstanding something; but I dug up the old thread > and you didn't respond to this bit: >=20 > https://sourceware.org/ml/gdb-patches/2013-11/msg00785.html >=20 Thanks, I got it now. I`m working on it. -Sanimir Intel GmbH Dornacher Strasse 1 85622 Feldkirchen/Muenchen, Deutschland Sitz der Gesellschaft: Feldkirchen bei Muenchen Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk Registergericht: Muenchen HRB 47456 Ust.-IdNr./VAT Registration No.: DE129385895 Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052