From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4907 invoked by alias); 16 Jan 2014 17:02:48 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 4842 invoked by uid 89); 16 Jan 2014 17:02:47 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mga02.intel.com Received: from mga02.intel.com (HELO mga02.intel.com) (134.134.136.20) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 16 Jan 2014 17:02:46 +0000 Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP; 16 Jan 2014 09:02:22 -0800 X-ExtLoop1: 1 Received: from irsmsx103.ger.corp.intel.com ([163.33.3.157]) by orsmga001.jf.intel.com with ESMTP; 16 Jan 2014 09:02:21 -0800 Received: from irsmsx153.ger.corp.intel.com (163.33.192.75) by IRSMSX103.ger.corp.intel.com (163.33.3.157) with Microsoft SMTP Server (TLS) id 14.3.123.3; Thu, 16 Jan 2014 17:02:04 +0000 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.215]) by IRSMSX153.ger.corp.intel.com ([169.254.9.156]) with mapi id 14.03.0123.003; Thu, 16 Jan 2014 17:02:03 +0000 From: "Agovic, Sanimir" To: 'Tom Tromey' CC: "palves@redhat.com" , "xdje42@gmail.com" , "gdb-patches@sourceware.org" , "Boell, Keven" Subject: RE: [PATCH v4 12/13] test: basic c99 vla tests for C primitives Date: Thu, 16 Jan 2014 17:02:00 -0000 Message-ID: <0377C58828D86C4588AEEC42FC3B85A7176D3671@IRSMSX105.ger.corp.intel.com> References: <1387282678-3847-1-git-send-email-sanimir.agovic@intel.com> <1387282678-3847-13-git-send-email-sanimir.agovic@intel.com> <871u09orgl.fsf@fleche.redhat.com> In-Reply-To: <871u09orgl.fsf@fleche.redhat.com> Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2014-01/txt/msg00620.txt.bz2 Thanks for your review. > -----Original Message----- > From: Tom Tromey [mailto:tromey@redhat.com] > Sent: Wednesday, January 15, 2014 10:39 PM > To: Agovic, Sanimir > Cc: palves@redhat.com; xdje42@gmail.com; gdb-patches@sourceware.org; Boel= l, Keven > Subject: Re: [PATCH v4 12/13] test: basic c99 vla tests for C primitives >=20 > >>>>> "Sanimir" =3D=3D Sanimir Agovic writes: >=20 > Sanimir> +gdb_test "print sizeof (++int_vla\[0\])" "\\$\\d+ =3D ${sizeof_= int}" \ > Sanimir> + "print sizeof (++int_vla\[0\])" > Sanimir> +gdb_test "print int_vla\[0\]" "\\$\\d+ =3D 42" \ > Sanimir> + "print int_vla\[0\] - sizeof no side effects" >=20 > I didn't see any tests for the case where there should be a side effect. >=20 This line from above: =20 gdb_test "print sizeof (++int_vla\[0\])" [...] Is used to ensure that no side effect happen to arguments passed to sizeof. The test is trying to express the following:=20 int i =3D 42; sizeof(++i); assert (i =3D=3D 42) Is it OK? -Sanimir Intel GmbH Dornacher Strasse 1 85622 Feldkirchen/Muenchen, Deutschland Sitz der Gesellschaft: Feldkirchen bei Muenchen Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk Registergericht: Muenchen HRB 47456 Ust.-IdNr./VAT Registration No.: DE129385895 Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052