From: "Agovic, Sanimir" <sanimir.agovic@intel.com>
To: 'Tom Tromey' <tromey@redhat.com>,
'Joel Brobecker' <brobecker@adacore.com>
Cc: "palves@redhat.com" <palves@redhat.com>,
"xdje42@gmail.com" <xdje42@gmail.com>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
"Boell, Keven" <keven.boell@intel.com>
Subject: RE: [PATCH v4 01/13] vla: introduce new bound type abstraction adapt uses
Date: Thu, 16 Jan 2014 17:03:00 -0000 [thread overview]
Message-ID: <0377C58828D86C4588AEEC42FC3B85A7176D3683@IRSMSX105.ger.corp.intel.com> (raw)
In-Reply-To: <87zjmworgf.fsf@fleche.redhat.com>
Thanks for your review.
> -----Original Message-----
> From: Tom Tromey [mailto:tromey@redhat.com]
> Sent: Wednesday, January 15, 2014 10:39 PM
> To: Agovic, Sanimir
> Cc: 'Joel Brobecker'; palves@redhat.com; xdje42@gmail.com; gdb-patches@sourceware.org;
> Boell, Keven
> Subject: Re: [PATCH v4 01/13] vla: introduce new bound type abstraction adapt uses
>
> Joel> I think that the _1 suffix is usually used when the function performs
> Joel> the private portion of a more public routine. But in this case,
> Joel> create_range_type_1 is meant to be a public routine, and the _1
> Joel> suffix is not very explicit. IMO, what would be ideal would be to
> Joel> rename the current create_range_type into "create_static_range_type",
> Joel> and then make create_range_type_1 the new create_range_type. I checked
> Joel> the GDB tree, and there aren't that many calls to update. If people
> Joel> prefer, I can even take care of that myself once the patche series
> Joel> has gone in. Otherwise, another compromise solution is to rename
> Joel> create_range_type_1 to create_range_type_full (for instance).
>
> Sanimir> Sounds good to me. I will prepend a patch doing the
> Sanimir> create_range_type -> create_static_range_type thingy and use
> Sanimir> create_range_type in this patch instead of create_range_type_1.
>
> I guess this is one of the remaining blockers for this series now.
> Though since Joel was agreeable I think it would be fine if you'd prefer
> to do it as a follow-up.
>
I had already prepared a patch doing the necessary renaming upfront. If it is OK
to you and/or Joel I like to keep it as the first patch in my series.
-Sanimir
Intel GmbH
Dornacher Strasse 1
85622 Feldkirchen/Muenchen, Deutschland
Sitz der Gesellschaft: Feldkirchen bei Muenchen
Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk
Registergericht: Muenchen HRB 47456
Ust.-IdNr./VAT Registration No.: DE129385895
Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052
next prev parent reply other threads:[~2014-01-16 17:03 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-17 12:18 [PATCH v4 00/13] C99 variable length array support Sanimir Agovic
2013-12-17 12:18 ` [PATCH v4 07/13] vla: support for DW_AT_count Sanimir Agovic
2013-12-17 12:18 ` [PATCH v4 05/13] vla: update type from newly created value Sanimir Agovic
2013-12-18 3:44 ` Joel Brobecker
2013-12-17 12:18 ` [PATCH v4 01/13] vla: introduce new bound type abstraction adapt uses Sanimir Agovic
2013-12-18 3:24 ` Joel Brobecker
2013-12-18 15:59 ` Agovic, Sanimir
2014-01-15 21:39 ` Tom Tromey
2014-01-16 2:45 ` Joel Brobecker
2014-01-16 17:03 ` Agovic, Sanimir [this message]
2014-01-16 17:39 ` Tom Tromey
2013-12-17 12:18 ` [PATCH v4 06/13] vla: print "variable length" for unresolved dynamic bounds Sanimir Agovic
2013-12-17 12:18 ` [PATCH v4 04/13] vla: enable sizeof operator for indirection Sanimir Agovic
2014-01-15 21:28 ` Tom Tromey
2014-01-16 17:02 ` Agovic, Sanimir
2013-12-17 12:18 ` [PATCH v4 02/13] type: add c99 variable length array support Sanimir Agovic
2014-01-15 21:07 ` Tom Tromey
2014-01-16 17:01 ` Agovic, Sanimir
2013-12-17 12:19 ` [PATCH v4 11/13] test: evaluate pointers to C99 vla correctly Sanimir Agovic
2013-12-17 12:19 ` [PATCH v4 12/13] test: basic c99 vla tests for C primitives Sanimir Agovic
2014-01-15 21:39 ` Tom Tromey
2014-01-16 17:02 ` Agovic, Sanimir
2014-01-16 17:33 ` Tom Tromey
2014-01-17 13:36 ` Agovic, Sanimir
2014-01-20 5:47 ` Tom Tromey
2014-01-20 9:32 ` Agovic, Sanimir
2013-12-17 12:19 ` [PATCH v4 08/13] vla: resolve dynamic bounds if value contents is a constant byte-sequence Sanimir Agovic
2013-12-17 12:19 ` [PATCH v4 13/13] test: add mi vla test Sanimir Agovic
2013-12-17 12:19 ` [PATCH v4 09/13] test: cover subranges with present DW_AT_count attribute Sanimir Agovic
2013-12-17 12:19 ` [PATCH v4 03/13] vla: enable sizeof operator to work with variable length arrays Sanimir Agovic
2014-01-15 21:24 ` Tom Tromey
2013-12-17 12:19 ` [PATCH v4 10/13] test: multi-dimensional c99 vla Sanimir Agovic
2013-12-18 3:01 ` [PATCH v4 00/13] C99 variable length array support Joel Brobecker
2014-01-15 21:41 ` Tom Tromey
2014-01-16 17:05 ` Agovic, Sanimir
2014-01-16 22:11 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0377C58828D86C4588AEEC42FC3B85A7176D3683@IRSMSX105.ger.corp.intel.com \
--to=sanimir.agovic@intel.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=keven.boell@intel.com \
--cc=palves@redhat.com \
--cc=tromey@redhat.com \
--cc=xdje42@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).