From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) by sourceware.org (Postfix) with ESMTPS id 7E7F33858C83 for ; Mon, 17 Oct 2022 19:37:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7E7F33858C83 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wm1-f46.google.com with SMTP id c7-20020a05600c0ac700b003c6cad86f38so13475577wmr.2 for ; Mon, 17 Oct 2022 12:37:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=gzQKqP9//d3H45L91PELSTvZ9waJoj69nfG5y2DlGaE=; b=ozQCwxWxO7jRAGHjnw8pBPOMc1aAhCtwEL9cMoHMw9cueQ9TUg0aGje9dQCB/iV+bR bGP35z4KBw6k938wRPZIb6VvPNIuTioMSo3BLfvhYQLA5/vK7WO4VaOWcGpTTwqj0zlR QfvXrYHoE/VjxXj3FLESfruf7J/ZUBcV9f8BFje9oCrgN4N4NYrLwWEAiySYNYslynJ0 miklGOw00XCrN4xjbdxoNz+rSf3G37KPPf4noh1bhgrFOqHyyvGFVn8d19DH5pLsqAxp JCS622YdB8dehChhIfsrxMglFDdpd9O/THZtzfvrceUOyFfLM8nWx3JwoyqzepF1eQHj vbwQ== X-Gm-Message-State: ACrzQf2ZC3v45a9mxuaPncewZfeDIwoZf4xq4yhgZLagdeeT4rZcTKJt sHGkbPIkIOgpgFJdmcEKj6UPi2BPm4YSiA== X-Google-Smtp-Source: AMsMyM486eUiFiZvwrRWZ8eYu2VybSAHP5irTIAnMYLI9qHjjlhAWMW0HUtZfcaHqeAmyP3t7s51Kw== X-Received: by 2002:a05:600c:6023:b0:3c6:bd83:752f with SMTP id az35-20020a05600c602300b003c6bd83752fmr20606491wmb.35.1666035469472; Mon, 17 Oct 2022 12:37:49 -0700 (PDT) Received: from ?IPv6:2001:8a0:f93a:3b00:e038:5cdc:b8bf:4653? ([2001:8a0:f93a:3b00:e038:5cdc:b8bf:4653]) by smtp.gmail.com with ESMTPSA id a21-20020a05600c2d5500b003b50428cf66sm10733545wmg.33.2022.10.17.12.37.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 Oct 2022 12:37:48 -0700 (PDT) Subject: Re: [PATCH] internal_error: remove need to pass __FILE__/__LINE__ To: Simon Marchi , gdb-patches@sourceware.org References: <20221017185019.3233941-1-pedro@palves.net> <6e5b27a9-abd4-60f3-fc3a-d9f8fa9f6a64@simark.ca> From: Pedro Alves Message-ID: <037dc77f-a3f9-34de-adcd-82d775c5d90f@palves.net> Date: Mon, 17 Oct 2022 20:37:28 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <6e5b27a9-abd4-60f3-fc3a-d9f8fa9f6a64@simark.ca> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.9 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Oct 2022 19:37:57 -0000 On 2022-10-17 8:27 p.m., Simon Marchi wrote: >> Most probably. I prefer keeping internal_error for it being more pervasive >> and older. gdb_assert_not_reached is a more recent addition. > > Fine with me. > >>> The only difference is that gdb_assert_not_reached includes the >>> function name, but I don't think it's an important difference. I think >>> we could switch to a single one that does include the function name. >> >> I don't think it needs to be in this patch, though? >> >> This one is just making internal_error more convenient to call. We can >> always look at doing something to its internals separately. > > Sure, it's just an idea for eventually. Cool, thanks. I guess I am not sure whether your earlier comment meant that you're OK with the patch itself (rather than the idea), though. :-)