From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by sourceware.org (Postfix) with ESMTPS id 927283857832 for ; Mon, 13 Sep 2021 16:50:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 927283857832 Received: from pps.filterd (m0246629.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 18DFu0v7002554; Mon, 13 Sep 2021 16:50:57 GMT Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by mx0b-00069f02.pphosted.com with ESMTP id 3b1ka938x5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 13 Sep 2021 16:50:57 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 18DGfL7K085671; Mon, 13 Sep 2021 16:50:56 GMT Received: from nam11-dm6-obe.outbound.protection.outlook.com (mail-dm6nam11lp2175.outbound.protection.outlook.com [104.47.57.175]) by userp3020.oracle.com with ESMTP id 3b167qq1h1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 13 Sep 2021 16:50:55 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Lot6oCiHtHkMaOvfl8/3YF7tYgmPw1sl4dUvR4jor6LDgxMrGp0EOqBV7+tbWMCLhld3WaPDvo06Q4o1EodHb06WIQkzJMANF4+JQLslpxNksDNwOHxjNwenN8gAhotYKy6tgErp6WaRLJGAw8KsskubrxQQ0057BWkfcguT9nt3XU7xaAca7iuSYMlpaIuFyAtiX+WmHyOzzgBE0nzbb2L3I28U3hO3hYpVgu33U6XZSyrT2MOoAgGBZq2W7b2BZSwSXaG/FcCAI8z52++VpDccVx+TVU9mK4r1NyP3swfxxxA7xacKslkG/OXRHOOl5MyYl/mwc3+HmrZRmr9JJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=vJa9t4c4pe9wD3KqxAztBa92Vkc6MHht45HcykEnm8M=; b=oD/DlFJSniT3q3BTxf8lIOLW2CQ/zweVzxnNBhmlWt6yrV/fN7v92dDoI4g2ZWck2liRnQaACuba/jnwrnkbhaRKHaTtkJw61YA/UrGsGoelb05UViGaY1+v9ZR+v+14tNzF74zXBIjATtPbkqJrwsR+IXuKi4NxKjwC//xXvxC+4wO2H4RMchinjwldqFl8luWN5NhVGfaLdWTey9ac3hxGCJ/7QSOvJjh6PdAmShPx1QAvTVXcltWptNOSqrbl2N9FcVZG2ptiT+7TRrvhUpZSM+QaX5Z/5pZm4ypHHMIiXCsdu5dlbc/7YZBCj4QjbGQ6IX7Ly7sGpButnWp2ag== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none Received: from BN6PR10MB1748.namprd10.prod.outlook.com (2603:10b6:405:9::16) by BN6PR10MB1329.namprd10.prod.outlook.com (2603:10b6:404:44::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.17; Mon, 13 Sep 2021 16:50:53 +0000 Received: from BN6PR10MB1748.namprd10.prod.outlook.com ([fe80::93d:77e4:40df:9042]) by BN6PR10MB1748.namprd10.prod.outlook.com ([fe80::93d:77e4:40df:9042%9]) with mapi id 15.20.4500.019; Mon, 13 Sep 2021 16:50:53 +0000 Subject: Re: [PATCH 00/30] Rewrite the DWARF "partial" reader To: Tom Tromey , Wei-min Pan via Gdb-patches References: <20210826021937.1490292-1-tom@tromey.com> <1451db09-69e1-beac-4733-36f4c03a1db6@oracle.com> <87pmteizwq.fsf@tromey.com> From: Weimin Pan Message-ID: <03842c03-0a45-e52c-4e53-1a6801e235b4@oracle.com> Date: Mon, 13 Sep 2021 09:50:40 -0700 User-Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 In-Reply-To: <87pmteizwq.fsf@tromey.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-ClientProxiedBy: BY5PR03CA0008.namprd03.prod.outlook.com (2603:10b6:a03:1e0::18) To BN6PR10MB1748.namprd10.prod.outlook.com (2603:10b6:405:9::16) MIME-Version: 1.0 Received: from [172.27.35.125] (108.88.88.153) by BY5PR03CA0008.namprd03.prod.outlook.com (2603:10b6:a03:1e0::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.15 via Frontend Transport; Mon, 13 Sep 2021 16:50:53 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f82589cc-db01-410c-e185-08d976d6a64e X-MS-TrafficTypeDiagnostic: BN6PR10MB1329: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QZrjwYbUTaipPofjyqu7buCLOX0oJQD18OOchT8hhiOG7eW0aKSHQUasRzrx2bzwo4Uj83N5OSIsbsNhCQxWClcA2mw9uwjNYIsKZ9glVIJKyHrjW40MVWxSkDDuR7t0UIFnMyPP7LuXgIodikQ6X8bh3FOnM4j8dYqduSnRIK52NaoXad68ZquLUXgzY5Vi5WsdmBhtkI1S7M26sJzYfdewxshc6rVFMYL6z8gX17ndnJ61rGj2qRFgqvbIQUOG+/k6TpIphH8tSXa62JNufklI7gFowEVZFG/DKl4nM43e1j63tNhKy6IGtZz3Z2pBpaGfujtPxDXLGA7raYzJUghxF4FCEoxrqP1mCnpQyHhwdV91yj1GZW/HDvDbf7hnLzj03VGDgP33rnKPFJlHz/XICf0XHrdGXMRrn3lxFrrqj462e6NFndmoQHDled1kZrTrsB/v5WfEvyp3ZPARB+IDoSO1b0eVVpfKxkhPA3dptZpNOdFhsC2J5T0ClX+lRcrHMR4eb2hNxpCcw4hLBJFeAxsn0Cln1XEiZlE71WHpk2TO3QYFaJiQTSu3aOzJZ7lOofQqaCfioEcztNWPkSOX94aBoW984X2m4sKT0FEZTMTFQXZbojpWXWwpQ98VDL0jqx2wyzjEnM338jYD+5QOgH3HdFs91LKxLjy+t6TkNkBWr4vg8bfkwSs10TGfH02NG/afoYvqc68whhE9H0pnSCoIoRoiClHpOGhsCXOqLhDK0+mWW7bnoH+14eKIHRukDczoZVBV2Z0xGEtN5g== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN6PR10MB1748.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(136003)(376002)(39860400002)(396003)(366004)(346002)(66476007)(956004)(66556008)(2616005)(8936002)(110136005)(16576012)(38350700002)(38100700002)(44832011)(5660300002)(186003)(36756003)(26005)(86362001)(66946007)(31696002)(8676002)(53546011)(6486002)(52116002)(2906002)(31686004)(6666004)(478600001)(316002)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?d0VUaEFmaFZTM1pRVVZJYzFjKzRsOTVrUGZHTGF3ZVZuY2djTGt3YVlWU2Fo?= =?utf-8?B?R1JMNE41RGRtRW0rQysyTkE1NlZ6MW1MTWlvZWs4ZjVsYU1WRDNkWHppck5m?= =?utf-8?B?L0haN1BmNVNpTHhWNW5ISzcvVEtCazJ6dlZWS09hQm50cXkrRWRSSVVudTZG?= =?utf-8?B?NnpnLzZlSStkdVhxL20wQU0wbFhtU3RYeFI3OUkvbkd5UWpJaGlzcEFzajdC?= =?utf-8?B?bUxWNE5iLzFFbjU2ZDQwdE1BeVVlcXZQMVBkRFFLNCtPVWNDcVc5OVY0eVVu?= =?utf-8?B?MTM4SFl2dVlUU3lqT1QydXBkLzlrdUJLbkhIQ2VLajBtTHRWYXF4UEJJL1NP?= =?utf-8?B?TTlrMEpheHJYOUZsaElqTFkzMk83Rmo3MlRNbTdPbFA1UlRxakpqaGN6eEpu?= =?utf-8?B?WlJRMDQrTFRIeXczbHhCeUtrWlBpcnhoRTF6UGx5dXVYckNvVlYrWUQ3aSth?= =?utf-8?B?NHQ1WGpyMTRqUFFWUmt5ZjRsemhtTjhWVU1wdGlnMStLVVZpcDA2ZWx0eUpn?= =?utf-8?B?VmhiTXVMM2dIZWIvdjBJaDVhT2Zla1VJYm80YVJIYzNpK3pVQnU1V3JCZDJP?= =?utf-8?B?YWd3TDdiNjBYbkVKeDNpMythWHIxczZvdFE1cHovUXB2ekRScXRqS1hEWlJH?= =?utf-8?B?SGRUcE5RM1U3dkZiRWcvQ2lpQnA5RVF2WWI0Ykw5eFRKR25OOFk4enZpVlVs?= =?utf-8?B?VFNBd3pIWS9IWmMraFpUdWVZTkdEMVoxcUE4RW9yNHUydnVXUzBudlFVa1dh?= =?utf-8?B?YWJLdHpmc0YyaEZFYzQrK1JRZWEzYi9pSmNzREplYjJQSk90OStxTVpDTS83?= =?utf-8?B?SHUzazI2UVF3ajZiNVBKMTN6SEo5THhoQjhpcmcvRXAweFd1bTlCS21YQ2Zh?= =?utf-8?B?OUtOamw0VU4zdmdTeXlOM1JLcDBXYTl4WlJMVTEzQ1FkNUFOSUVJb0RrL21z?= =?utf-8?B?MUhMOHIxS205dzZFWmR3Q3p5VjYxSjRjcUdmTElzQUZsRCsrb3BtS2YwNzdy?= =?utf-8?B?SHhEU3FTY25XQldYTzF4MU9uazRWMU9IbHBWVjJ5TmtjaFRPY3FXUW5WN2hS?= =?utf-8?B?ZC8wK3pPaDMrTmpyQ2dLejlPdGlTV1J5KytVS1hycnlLVEtPTmxnUVpjVmJz?= =?utf-8?B?MXh6ZUk2L3dIYUM5c3hLUlpYQTJXUWFMa0xtaHVuV1NtSWtaU2NOM1ViSW1u?= =?utf-8?B?YUZjK2srOER0TmhRTmxFUDFUVnJRaDBZQjc4S3pMVnlXMmNVSk1uR3JDYkQ3?= =?utf-8?B?Z054dXYzN3RKb2ZSbmVHTVJvR1lWSW9kaE1LSXpiL05SbkZiU3didmhqRjNK?= =?utf-8?B?UDJIUUFlcGZrRUlBa1hXcXFuRk83SzhDWmQ1MXJEa3lDWU9qdEFZVTBRZHR2?= =?utf-8?B?SVBqcEF4NmF1eGNjYzQyaW00SzZ2S2Q0WGJFWjdXRGlmemlEbnlOZEkreHNB?= =?utf-8?B?UzBpWE45dFlYc2hibzB1eHJyZHowa3RiUlZEanlXUG5NeEw3WnRhTTFnaWV1?= =?utf-8?B?Y3lKQkJQby9EcGozcVF3eW1Rb29QQ25hbTBTQlBEWk9ISElmaWkrSStXSHJn?= =?utf-8?B?Q3NBZlZqdTFBRXdTQ1pmVFFlWTliQStTeU80dm5wM2VkVU5EZmwxOUNzdXdC?= =?utf-8?B?RTZxcTVpL0hFMkZFL1g5Y3RLZCtSeHF6b2MwQmNZS1ZJOFRwbnFaM0JVVzAr?= =?utf-8?B?US9hK0grSGlHSjBBdVkrQk5MR3RkbGpvd2xWSVNxamY5aDQ2SGtyUTJUMk5W?= =?utf-8?Q?qpbogTR+q0yEA5+Uq8Q5FO5KfMYPd8RwaLCgSAr?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: f82589cc-db01-410c-e185-08d976d6a64e X-MS-Exchange-CrossTenant-AuthSource: BN6PR10MB1748.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Sep 2021 16:50:53.6751 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: EeS06B2e0eVvK9yZgkEXO4AFLIjhOqkssaHr6PxX3oYRLXtipFI1KH/Ftxca2NEh1AgAf0TOFSYlM/CIddfkfg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR10MB1329 X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10106 signatures=668682 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 adultscore=0 suspectscore=0 phishscore=0 mlxlogscore=999 malwarescore=0 mlxscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2109030001 definitions=main-2109130108 X-Proofpoint-GUID: o-ry44vWncwQ86c79oIhl64ZH5kHykgS X-Proofpoint-ORIG-GUID: o-ry44vWncwQ86c79oIhl64ZH5kHykgS X-Spam-Status: No, score=-5.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, MSGID_FROM_MTA_HEADER, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Sep 2021 16:51:01 -0000 On 9/11/2021 2:08 PM, Tom Tromey wrote: >>> Given the lack of response to our reiterated pings, would you prefer that >>> we get rid of the partial symbol table in the CTF reader as well? > Hi. I'm sorry about that. I haven't had much time for reviews lately, > so I've been pretty much ignoring everything. > > I think how the CTF reader works is up to you. I feel like I brought up > the idea of avoiding psymtabs once, in favor of a direct implementation > of the "quick" functions (perhaps via a thinner wrapper around libctf), > but maybe you didn't want to take that route? IIRC maybe the existing > code had already been written. > > thanks, > Tom Hi Tom, I understand you've been busy working on the index DWARF project which is quite complicated. Our approach was to using partial symbol table for CTF support initially and switch to using quick functions, wrapped around libctf like you said, next. I was wondering if you can take a look at our latest patch and give us the green light to push it. Thank you very much.