From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by sourceware.org (Postfix) with ESMTPS id B14733858404 for ; Wed, 28 Sep 2022 02:00:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B14733858404 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id D9FEE1F8A3; Wed, 28 Sep 2022 02:00:19 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id B0CF313A3B; Wed, 28 Sep 2022 02:00:19 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id n8PBKbOqM2NgRQAAMHmgww (envelope-from ); Wed, 28 Sep 2022 02:00:19 +0000 Message-ID: <03994f80-2aa9-e30a-2cab-d458b402e148@suse.de> Date: Wed, 28 Sep 2022 04:00:19 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH 0/2] Fix .gdb_index with Ada Content-Language: en-US To: Tom Tromey , gdb-patches@sourceware.org References: <20220922202054.2773698-1-tromey@adacore.com> From: Tom de Vries In-Reply-To: <20220922202054.2773698-1-tromey@adacore.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-13.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Sep 2022 02:00:23 -0000 On 9/22/22 22:20, Tom Tromey via Gdb-patches wrote: > This series improves .gdb_index support for Ada, fixing a regression > introduced by the DWARF reader rewrite. > > I regression tested this using the cc-with-gdb-index target board on > x86-64 Fedora 34. There were no regressions, only improvements. > Hi, I've tested this series with target board cc-with-gdb-index. The only FAILs I found were: ... $ grep ^FAIL: gdb.sum FAIL: gdb.base/c-linkage-name.exp: print symada__cS before partial symtab expansion FAIL: gdb.dwarf2/dw2-zero-range.exp: ranges_sect=ranges: Zero address complaint - relocated - psymtab FAIL: gdb.dwarf2/dw2-zero-range.exp: ranges_sect=ranges: Zero address complaint - unrelocated - psymtab FAIL: gdb.dwarf2/dw2-zero-range.exp: ranges_sect=rnglists: Zero address complaint - relocated - psymtab FAIL: gdb.dwarf2/dw2-zero-range.exp: ranges_sect=rnglists: Zero address complaint - unrelocated - psymtab FAIL: gdb.python/py-symbol.exp: print (len (gdb.lookup_static_symbols ('rr'))) ... The FAILs from gdb.python/py-symbol.exp and gdb.dwarf2/dw2-zero-range.exp are know, they also fail with target board cc-with-debug-names. The gdb.base/c-linkage-name.exp FAIL does look relevant to this series, and probably was regressed by the same offending commit. Doing: ... diff --git a/gdb/dwarf2/index-write.c b/gdb/dwarf2/index-write.c index ae05946e790..0268371ec2e 100644 --- a/gdb/dwarf2/index-write.c +++ b/gdb/dwarf2/index-write.c @@ -1167,7 +1167,6 @@ write_cooked_index (cooked_index_vector *table, minimal symbols anyway, so including it in the index is usually redundant -- and the cases where it would not be redundant are rare and not worth supporting. */ - continue; } gdb_index_symbol_kind kind; ... fixes the FAIL, so is this one of the "rare and not worth supporting" cases you're referring to? Thanks, - Tom