From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id E212E385842D for ; Tue, 21 Feb 2023 14:36:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E212E385842D Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca Received: from [172.16.0.192] (192-222-180-24.qc.cable.ebox.net [192.222.180.24]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 6C2F41E110; Tue, 21 Feb 2023 09:36:54 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1676990214; bh=JK3wU1txjNhlVaJIyhyHPLMzPH1ST3Xuxgp3/qI7B+4=; h=Date:Subject:To:References:From:In-Reply-To:From; b=KY7E1AoR3YuWdE+CMGU/M8uCQPs238fLExjHW8l+BdFFgcrmKIxGOJo5W2R/ckBu3 KooGD3hxNGKYTWTKE0Fj1i4TFzmtmUKRDg35QLUkFafO7qAIi8h1Qt2o0usIY5NFsX pnZ4O5w61Opk8Ohj2FGl2pe8ZxXzhYTUIEFwTdcM= Message-ID: <03f11e34-1a30-6712-09a2-8983e68d1a70@simark.ca> Date: Tue, 21 Feb 2023 09:36:54 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [PATCH v2] gdb: add --with-curses to --configuration output To: Philippe Blain , gdb-patches@sourceware.org References: <20230211-configuration-show-curses-v2-1-a28c6ea6f00a@gmail.com> <7a7dbf0d-c6d6-22bc-5bb1-c671b7720424@simark.ca> Content-Language: fr From: Simon Marchi In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-10.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2/21/23 07:52, Philippe Blain wrote: > Hi Simon, > > Le 2023-02-20 à 12:08, Simon Marchi a écrit : >>> diff --git a/gdb/configure.ac b/gdb/configure.ac >>> index 7c7bf88b3fb..6ad0f9d8815 100644 >>> --- a/gdb/configure.ac >>> +++ b/gdb/configure.ac >>> @@ -563,11 +563,11 @@ if test x"$prefer_curses" = xyes; then >>> # search /usr/local/include, if ncurses is installed in /usr/local. A >>> # default installation of ncurses on alpha*-dec-osf* will lead to such >>> # a situation. >>> - AC_SEARCH_LIBS(waddstr, [ncursesw ncurses cursesX curses]) >>> - >>> - if test "$ac_cv_search_waddstr" != no; then >>> - curses_found=yes >>> - fi >>> + AC_SEARCH_LIBS(waddstr, [ncursesw ncurses cursesX curses], >>> + [curses_found=yes && >>> + AC_DEFINE([HAVE_LIBCURSES], [1], >>> + [Define to 1 if curses is enabled.]) >>> + ]) >> >> I don't think the `&&` is needed, you can just put each action on its >> own line. It becomes regular shell script in the end. I tried removing >> it on my side, it seems to work fine. If that work for you too, I can >> push the patch with that little change. > > Yes, that sounds good to me. Thanks! > > Philippe. Pushed, thanks! Simon