From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 3ECEF385782C for ; Mon, 10 May 2021 00:16:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 3ECEF385782C Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 14A0GDJg008722 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Sun, 9 May 2021 20:16:18 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 14A0GDJg008722 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id D4F781E54D for ; Sun, 9 May 2021 20:16:13 -0400 (EDT) Subject: Re: [PATCH] gdb: add ../config/pkg.m4 in acinclude.m4 To: gdb-patches@sourceware.org References: <20210509012432.1154603-1-simon.marchi@polymtl.ca> From: Simon Marchi Message-ID: <04311a21-f880-b6d5-eb5d-5cd70d95b607@polymtl.ca> Date: Sun, 9 May 2021 20:16:13 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Mon, 10 May 2021 00:16:13 +0000 X-Spam-Status: No, score=-3.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, KAM_NUMSUBJECT, KAM_SHORT, NICE_REPLY_A, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 May 2021 00:16:24 -0000 On 2021-05-09 4:00 p.m., Mike Frysinger wrote: > On 08 May 2021 21:24, Simon Marchi via Gdb-patches wrote: >> Since commit adeab0c5b33f ("config/debuginfod: do not include pkg.m4 >> directly"), it no longer works to re-generate the autoconf stuff in GDB >> without passing "-I ../config": >> >> $ autoreconf -f >> configure.ac:161: error: possibly undefined macro: AC_MSG_ERROR >> If this token and others are legitimate, please use m4_pattern_allow. >> See the Autoconf documentation. >> configure.ac:329: error: possibly undefined macro: AC_MSG_WARN >> configure.ac:409: error: possibly undefined macro: AC_DEFINE >> autoreconf: /opt/autostuff/2.69/bin/autoconf failed with exit status: 1 >> >> The reason is: since that commit, the PKG_CHECK_MODULES macro is not >> found. When passing "-I ../config" to the autoconf tools, then it's >> found. But if I understand correctly, the reason why we have all these >> includes in acinclude.m4 is to avoid having to specify that, to make the >> default invocation without special arguments "just work". > > how about this instead ? i can run `aclocal && autoconf` with this. > > --- a/gdb/configure.ac > +++ b/gdb/configure.ac > @@ -18,9 +18,8 @@ dnl along with this program. If not, see . > > dnl Process this file with autoconf to produce a configure script. > > -m4_include(../config/debuginfod.m4) > - > AC_INIT > +AC_CONFIG_MACRO_DIRS([../config]) > AC_CONFIG_SRCDIR([main.c]) > AC_CONFIG_HEADERS(config.h:config.in, [echo > stamp-h]) > AM_MAINTAINER_MODE > -mike > Ah yes, that sounds much better. If we have this, could we remove all lines in acinclude.m4 that refer to a file in ../config?