From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 7BBE2385734D for ; Mon, 15 May 2023 19:28:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7BBE2385734D Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1684178891; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4Uf0gbg5vvvtj8cq/FmaK8Epqc9CS7xHbx17vz0ynTA=; b=aDZGC7B/hKMenQjnQ4XOtEEdUDGGaT8g0CIwB4p1G2n0HrAMXX4SV1VtbhgSepl3tO2bH1 qRivnMXb1CUT+XaBbSQlbYW9taX3IEmAPyrDXteYd4Tqb3IimWWOAqzvKhZ8AN132Rbzuh DbaEY3QnPQv0VqW5+2mM2lUDMaFq+Jw= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-154-NEM2TmbDNGi4g0lqtftWtg-1; Mon, 15 May 2023 15:28:06 -0400 X-MC-Unique: NEM2TmbDNGi4g0lqtftWtg-1 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-3076fc5c278so7716880f8f.3 for ; Mon, 15 May 2023 12:28:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684178885; x=1686770885; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4Uf0gbg5vvvtj8cq/FmaK8Epqc9CS7xHbx17vz0ynTA=; b=JKdQeGgBOLZILhgljectOFiPWxplhkMCsGNm+ief+1lUuuLLwxD+kSpq4zDAQrkWQ4 iqAj7zH8Rv56S/1i8qXleYzhFyJwwVe+k05trDOR0hNytiYxzZ2E84SHLFupGMNrH8in gnYBoX5W7FsmJ2o6vbMzpkxTBkTsBiC+f2xBDQSOvXqvxG3BJ7rJtlo25et2dJ/7NtlY 8E61/l/ENLywHbNnnfXq7Uw51qutDtMPWC3k2lkZU5siulBGR/2ezyD4drjGHCe91AiL 3hGBZgvjqKrojZACVgt9w/mwWBGJSWgGcSYdnCd9oBL3wd1Wkyi2fXSn99HY5geI8Fut Dayg== X-Gm-Message-State: AC+VfDx440Caotmef79WZ6uomODuxxnNhXXvgjbmkf9rArkVNpBpXr3J v+sZO1bvdHLM47tD30n8bDfxY1On8CSl9z8+pMZj6vWnxnLVwXpgaixancrFSYzRXo9P88zMdlU o38iwPtiE69EWBfxZ4slWWLig+WjvPpNCLf8YUExfcFNrWlILmIwrWDEnPfP3ceQGkd6DT7hPf5 xWK4GQlg== X-Received: by 2002:a5d:55cf:0:b0:304:b967:956f with SMTP id i15-20020a5d55cf000000b00304b967956fmr27708696wrw.8.1684178885051; Mon, 15 May 2023 12:28:05 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4XWbD0vbrpDl1w1Y/CQjmWwi6GHiVHwwqK6AUDutOg3mi5nPzPuPig3xjJGKxW+2A+rgGhTA== X-Received: by 2002:a5d:55cf:0:b0:304:b967:956f with SMTP id i15-20020a5d55cf000000b00304b967956fmr27708684wrw.8.1684178884712; Mon, 15 May 2023 12:28:04 -0700 (PDT) Received: from localhost (11.72.115.87.dyn.plus.net. [87.115.72.11]) by smtp.gmail.com with ESMTPSA id l11-20020a7bc34b000000b003f1751016desm296435wmj.28.2023.05.15.12.28.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 May 2023 12:28:04 -0700 (PDT) From: Andrew Burgess To: gdb-patches@sourceware.org Cc: Andrew Burgess Subject: [PATCHv2 8/9] gdb: remove tracepoint_probe_create_sals_from_location_spec Date: Mon, 15 May 2023 20:27:44 +0100 Message-Id: <043a8df33eca35c82e68dca87e4e548f64872d0d.1684178710.git.aburgess@redhat.com> X-Mailer: git-send-email 2.25.4 In-Reply-To: References: MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-Spam-Status: No, score=-11.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: The tracepoint_probe_create_sals_from_location_spec function just forwards all its arguments to bkpt_probe_create_sals_from_location_spec, and is only used in one place. Lets delete tracepoint_probe_create_sals_from_location_spec and replace it with bkpt_probe_create_sals_from_location_spec. There should be no user visible changes after this commit. --- gdb/breakpoint.c | 19 +++---------------- 1 file changed, 3 insertions(+), 16 deletions(-) diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c index be035def12a..3964665d867 100644 --- a/gdb/breakpoint.c +++ b/gdb/breakpoint.c @@ -221,9 +221,6 @@ static bool strace_marker_p (struct breakpoint *b); static void bkpt_probe_create_sals_from_location_spec (location_spec *locspec, struct linespec_result *canonical); -static void tracepoint_probe_create_sals_from_location_spec - (location_spec *locspec, - struct linespec_result *canonical); const struct breakpoint_ops code_breakpoint_ops = { @@ -238,10 +235,11 @@ static const struct breakpoint_ops bkpt_probe_breakpoint_ops = create_breakpoints_sal, }; -/* Tracepoints set on probes. */ +/* Tracepoints set on probes. We use the same methods as for breakpoints + on probes. */ static const struct breakpoint_ops tracepoint_probe_breakpoint_ops = { - tracepoint_probe_create_sals_from_location_spec, + bkpt_probe_create_sals_from_location_spec, create_breakpoints_sal, }; @@ -12007,17 +12005,6 @@ tracepoint::print_recreate (struct ui_file *fp) const gdb_printf (fp, " passcount %d\n", pass_count); } -/* Virtual table for tracepoints on static probes. */ - -static void -tracepoint_probe_create_sals_from_location_spec - (location_spec *locspec, - struct linespec_result *canonical) -{ - /* We use the same method for breakpoint on probes. */ - bkpt_probe_create_sals_from_location_spec (locspec, canonical); -} - void dprintf_breakpoint::re_set () { -- 2.25.4