From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 23E1D383E81D for ; Sun, 24 May 2020 15:12:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 23E1D383E81D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark@simark.ca Received: from [10.0.0.11] (173-246-6-90.qc.cable.ebox.net [173.246.6.90]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 9D8181E5F9; Sun, 24 May 2020 11:12:40 -0400 (EDT) Subject: Re: [PATCH] gdb: make gdbarch.sh write gdbarch.{c,h} directly To: Tom Tromey , Simon Marchi via Gdb-patches Cc: Simon Marchi References: <20200511211825.1538934-1-simon.marchi@efficios.com> <87r1vodg8q.fsf@tromey.com> From: Simon Marchi Message-ID: <047c924d-ef47-b617-ae89-95f2d93ce453@simark.ca> Date: Sun, 24 May 2020 11:12:40 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: fr Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 24 May 2020 15:12:42 -0000 On 2020-05-12 5:16 p.m., Simon Marchi wrote: > On 2020-05-12 4:56 p.m., Tom Tromey wrote: >>>>>>> "Simon" == Simon Marchi via Gdb-patches writes: >> >> Simon> It was suggested in this thread [1] that gdbarch.sh should write to >> Simon> gdbarch.h and gdbarch.c directly. This patch implements that. >> >> Simon> When running gdbarch.sh, we currently need to move new-gdbarch.c over >> Simon> gdbarch.c and new-gdbarch.h over gdbarch.h. It might have been useful >> Simon> at some point to not have gdbarch.sh overwrite gdbarch.h and gdbarch.c, >> Simon> but with git it's really unnecessary. Any changes to gdbarch.sh can be >> Simon> inspected using `git diff`. >> >> This is a nice improvement, thanks. >> >> Tom >> > > Thanks, I'll wait for more input for the community before pushing, in case somebody > has an objection. > > Simon > I pushed this patch. Simon