* Re: [PATCH v7 0/5] Catch syscall group
@ 2016-06-27 18:54 Doug Evans
0 siblings, 0 replies; 6+ messages in thread
From: Doug Evans @ 2016-06-27 18:54 UTC (permalink / raw)
To: Gabriel Krisman Bertazi; +Cc: gdb-patches, palves, sergiodj
Gabriel Krisman Bertazi writes:
> Hi,
>
> This is yet another iteration of the catch syscall group patch set.
> This version includes the fixes proposed by Sergio, Doug and Pedro in
> the last iteration. Thank you guys for the suggestions.
>
> Changes since v6:
> - Initialize variable to NULL (Sergio)
> - Create wrapper rules syscalls-xml and clean-syscalls-xml (Pedro)
> - Always check for xsltproc in configure.ac. Only force the dependency
> when in maintainer mode.
> - Expose xml creation rule outside of maintainer mode (Pedro)
> - Fix up license header in apply-defaults.xsl (Pedro)
>
> Looking forward to hear from you guys.
>
> Gabriel Krisman Bertazi (5):
> Implemement support for groups of syscalls in the xml-syscall
> interface.
> Add support to catch groups of syscalls.
> Add tests for catching groups of syscalls on supported
> architectures.
> Include group information to xml syscall files.
> Update documentation on catching a group of related syscalls.
Hi.
I gave the latest series a quick read through.
LGTM.
Thanks!
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v7 0/5] Catch syscall group
@ 2016-06-19 20:34 Gabriel Krisman Bertazi
2016-06-30 16:10 ` Pedro Alves
0 siblings, 1 reply; 6+ messages in thread
From: Gabriel Krisman Bertazi @ 2016-06-19 20:34 UTC (permalink / raw)
To: gdb-patches; +Cc: palves, sergiodj, dje, Gabriel Krisman Bertazi
Hi,
This is yet another iteration of the catch syscall group patch set.
This version includes the fixes proposed by Sergio, Doug and Pedro in
the last iteration. Thank you guys for the suggestions.
Changes since v6:
- Initialize variable to NULL (Sergio)
- Create wrapper rules syscalls-xml and clean-syscalls-xml (Pedro)
- Always check for xsltproc in configure.ac. Only force the dependency
when in maintainer mode.
- Expose xml creation rule outside of maintainer mode (Pedro)
- Fix up license header in apply-defaults.xsl (Pedro)
Looking forward to hear from you guys.
Gabriel Krisman Bertazi (5):
Implemement support for groups of syscalls in the xml-syscall
interface.
Add support to catch groups of syscalls.
Add tests for catching groups of syscalls on supported
architectures.
Include group information to xml syscall files.
Update documentation on catching a group of related syscalls.
gdb/NEWS | 5 +
gdb/break-catch-syscall.c | 103 ++++++--
gdb/configure.ac | 9 +
gdb/data-directory/Makefile.in | 21 +-
gdb/doc/gdb.texinfo | 28 ++-
gdb/syscalls/aarch64-linux.xml | 271 ---------------------
gdb/syscalls/aarch64-linux.xml.in | 271 +++++++++++++++++++++
gdb/syscalls/amd64-linux.xml | 314 ------------------------
gdb/syscalls/amd64-linux.xml.in | 314 ++++++++++++++++++++++++
gdb/syscalls/apply-defaults.xsl | 43 ++++
gdb/syscalls/arm-linux.xml | 398 -------------------------------
gdb/syscalls/arm-linux.xml.in | 398 +++++++++++++++++++++++++++++++
gdb/syscalls/bfin-linux.xml | 326 -------------------------
gdb/syscalls/bfin-linux.xml.in | 326 +++++++++++++++++++++++++
gdb/syscalls/gdb-syscalls.dtd | 3 +-
gdb/syscalls/i386-linux.xml | 340 --------------------------
gdb/syscalls/i386-linux.xml.in | 340 ++++++++++++++++++++++++++
gdb/syscalls/linux-defaults.xml.in | 243 +++++++++++++++++++
gdb/syscalls/mips-n32-linux.xml | 319 -------------------------
gdb/syscalls/mips-n32-linux.xml.in | 319 +++++++++++++++++++++++++
gdb/syscalls/mips-n64-linux.xml | 312 ------------------------
gdb/syscalls/mips-n64-linux.xml.in | 312 ++++++++++++++++++++++++
gdb/syscalls/mips-o32-linux.xml | 347 ---------------------------
gdb/syscalls/mips-o32-linux.xml.in | 347 +++++++++++++++++++++++++++
gdb/syscalls/ppc-linux.xml | 310 ------------------------
gdb/syscalls/ppc-linux.xml.in | 310 ++++++++++++++++++++++++
gdb/syscalls/ppc64-linux.xml | 295 -----------------------
gdb/syscalls/ppc64-linux.xml.in | 295 +++++++++++++++++++++++
gdb/syscalls/s390-linux.xml | 367 ----------------------------
gdb/syscalls/s390-linux.xml.in | 367 ++++++++++++++++++++++++++++
gdb/syscalls/s390x-linux.xml | 334 --------------------------
gdb/syscalls/s390x-linux.xml.in | 334 ++++++++++++++++++++++++++
gdb/syscalls/sparc-linux.xml | 344 --------------------------
gdb/syscalls/sparc-linux.xml.in | 344 ++++++++++++++++++++++++++
gdb/syscalls/sparc64-linux.xml | 326 -------------------------
gdb/syscalls/sparc64-linux.xml.in | 326 +++++++++++++++++++++++++
gdb/testsuite/gdb.base/catch-syscall.exp | 39 +++
gdb/xml-syscall.c | 234 +++++++++++++++++-
gdb/xml-syscall.h | 16 ++
39 files changed, 5326 insertions(+), 4624 deletions(-)
delete mode 100644 gdb/syscalls/aarch64-linux.xml
create mode 100644 gdb/syscalls/aarch64-linux.xml.in
delete mode 100644 gdb/syscalls/amd64-linux.xml
create mode 100644 gdb/syscalls/amd64-linux.xml.in
create mode 100644 gdb/syscalls/apply-defaults.xsl
delete mode 100644 gdb/syscalls/arm-linux.xml
create mode 100644 gdb/syscalls/arm-linux.xml.in
delete mode 100644 gdb/syscalls/bfin-linux.xml
create mode 100644 gdb/syscalls/bfin-linux.xml.in
delete mode 100644 gdb/syscalls/i386-linux.xml
create mode 100644 gdb/syscalls/i386-linux.xml.in
create mode 100644 gdb/syscalls/linux-defaults.xml.in
delete mode 100644 gdb/syscalls/mips-n32-linux.xml
create mode 100644 gdb/syscalls/mips-n32-linux.xml.in
delete mode 100644 gdb/syscalls/mips-n64-linux.xml
create mode 100644 gdb/syscalls/mips-n64-linux.xml.in
delete mode 100644 gdb/syscalls/mips-o32-linux.xml
create mode 100644 gdb/syscalls/mips-o32-linux.xml.in
delete mode 100644 gdb/syscalls/ppc-linux.xml
create mode 100644 gdb/syscalls/ppc-linux.xml.in
delete mode 100644 gdb/syscalls/ppc64-linux.xml
create mode 100644 gdb/syscalls/ppc64-linux.xml.in
delete mode 100644 gdb/syscalls/s390-linux.xml
create mode 100644 gdb/syscalls/s390-linux.xml.in
delete mode 100644 gdb/syscalls/s390x-linux.xml
create mode 100644 gdb/syscalls/s390x-linux.xml.in
delete mode 100644 gdb/syscalls/sparc-linux.xml
create mode 100644 gdb/syscalls/sparc-linux.xml.in
delete mode 100644 gdb/syscalls/sparc64-linux.xml
create mode 100644 gdb/syscalls/sparc64-linux.xml.in
--
2.4.11
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v7 0/5] Catch syscall group
2016-06-19 20:34 Gabriel Krisman Bertazi
@ 2016-06-30 16:10 ` Pedro Alves
2016-07-13 1:45 ` Gabriel Krisman Bertazi
0 siblings, 1 reply; 6+ messages in thread
From: Pedro Alves @ 2016-06-30 16:10 UTC (permalink / raw)
To: Gabriel Krisman Bertazi, gdb-patches; +Cc: sergiodj, dje
On 06/19/2016 09:34 PM, Gabriel Krisman Bertazi wrote:
> Changes since v6:
> - Initialize variable to NULL (Sergio)
> - Create wrapper rules syscalls-xml and clean-syscalls-xml (Pedro)
> - Always check for xsltproc in configure.ac. Only force the dependency
> when in maintainer mode.
> - Expose xml creation rule outside of maintainer mode (Pedro)
> - Fix up license header in apply-defaults.xsl (Pedro)
Thanks. I'm happy with the updates. LGTM.
--
Pedro Alves
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v7 0/5] Catch syscall group
2016-06-30 16:10 ` Pedro Alves
@ 2016-07-13 1:45 ` Gabriel Krisman Bertazi
2016-07-13 17:34 ` Doug Evans
0 siblings, 1 reply; 6+ messages in thread
From: Gabriel Krisman Bertazi @ 2016-07-13 1:45 UTC (permalink / raw)
To: Pedro Alves; +Cc: Gabriel Krisman Bertazi, gdb-patches, sergiodj, dje
Pedro Alves <palves@redhat.com> writes:
> On 06/19/2016 09:34 PM, Gabriel Krisman Bertazi wrote:
>> Changes since v6:
>> - Initialize variable to NULL (Sergio)
>> - Create wrapper rules syscalls-xml and clean-syscalls-xml (Pedro)
>> - Always check for xsltproc in configure.ac. Only force the dependency
>> when in maintainer mode.
>> - Expose xml creation rule outside of maintainer mode (Pedro)
>> - Fix up license header in apply-defaults.xsl (Pedro)
>
> Thanks. I'm happy with the updates. LGTM.
Thanks, Doug and Pedro.
It's been almost 2 weeks from the last review. I'm out of office this
week, but unless anyone has other concerns, I plan to push it next week.
Does any one has other suggestions for this?
Thanks,
--
Gabriel Krisman Bertazi
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v7 0/5] Catch syscall group
2016-07-13 1:45 ` Gabriel Krisman Bertazi
@ 2016-07-13 17:34 ` Doug Evans
2016-07-23 21:44 ` Gabriel Krisman Bertazi
0 siblings, 1 reply; 6+ messages in thread
From: Doug Evans @ 2016-07-13 17:34 UTC (permalink / raw)
To: Gabriel Krisman Bertazi; +Cc: Pedro Alves, gdb-patches, Sergio Durigan Junior
On Tue, Jul 12, 2016 at 6:44 PM, Gabriel Krisman Bertazi
<gabriel@krisman.be> wrote:
> Pedro Alves <palves@redhat.com> writes:
>
>> On 06/19/2016 09:34 PM, Gabriel Krisman Bertazi wrote:
>>> Changes since v6:
>>> - Initialize variable to NULL (Sergio)
>>> - Create wrapper rules syscalls-xml and clean-syscalls-xml (Pedro)
>>> - Always check for xsltproc in configure.ac. Only force the dependency
>>> when in maintainer mode.
>>> - Expose xml creation rule outside of maintainer mode (Pedro)
>>> - Fix up license header in apply-defaults.xsl (Pedro)
>>
>> Thanks. I'm happy with the updates. LGTM.
>
> Thanks, Doug and Pedro.
>
> It's been almost 2 weeks from the last review. I'm out of office this
> week, but unless anyone has other concerns, I plan to push it next week.
>
> Does any one has other suggestions for this?
None come to mind.
Go for it, and thanks!
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v7 0/5] Catch syscall group
2016-07-13 17:34 ` Doug Evans
@ 2016-07-23 21:44 ` Gabriel Krisman Bertazi
0 siblings, 0 replies; 6+ messages in thread
From: Gabriel Krisman Bertazi @ 2016-07-23 21:44 UTC (permalink / raw)
To: Doug Evans
Cc: Gabriel Krisman Bertazi, Pedro Alves, gdb-patches, Sergio Durigan Junior
Doug Evans <dje@google.com> writes:
> On Tue, Jul 12, 2016 at 6:44 PM, Gabriel Krisman Bertazi
> <gabriel@krisman.be> wrote:
>> Pedro Alves <palves@redhat.com> writes:
>>
>>> On 06/19/2016 09:34 PM, Gabriel Krisman Bertazi wrote:
>>>> Changes since v6:
>>>> - Initialize variable to NULL (Sergio)
>>>> - Create wrapper rules syscalls-xml and clean-syscalls-xml (Pedro)
>>>> - Always check for xsltproc in configure.ac. Only force the dependency
>>>> when in maintainer mode.
>>>> - Expose xml creation rule outside of maintainer mode (Pedro)
>>>> - Fix up license header in apply-defaults.xsl (Pedro)
>>>
>>> Thanks. I'm happy with the updates. LGTM.
>>
>> Thanks, Doug and Pedro.
>>
>> It's been almost 2 weeks from the last review. I'm out of office this
>> week, but unless anyone has other concerns, I plan to push it next week.
>>
>> Does any one has other suggestions for this?
>
> None come to mind.
> Go for it, and thanks!
Pushed: <https://sourceware.org/ml/gdb-cvs/2016-07/msg00078.html>
Thanks,
--
Gabriel Krisman Bertazi
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-07-23 21:44 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-27 18:54 [PATCH v7 0/5] Catch syscall group Doug Evans
-- strict thread matches above, loose matches on Subject: below --
2016-06-19 20:34 Gabriel Krisman Bertazi
2016-06-30 16:10 ` Pedro Alves
2016-07-13 1:45 ` Gabriel Krisman Bertazi
2016-07-13 17:34 ` Doug Evans
2016-07-23 21:44 ` Gabriel Krisman Bertazi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).