From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 85147 invoked by alias); 7 Dec 2017 11:30:36 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 85017 invoked by uid 89); 7 Dec 2017 11:30:23 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-6.9 required=5.0 tests=BAYES_00,GIT_PATCH_1,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=Hx-languages-length:980 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 07 Dec 2017 11:30:13 +0000 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D039D49012; Thu, 7 Dec 2017 11:30:10 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 323FA183A2; Thu, 7 Dec 2017 11:30:10 +0000 (UTC) Subject: Re: [PATCH] Initialize target description early in IPA To: Yao Qi , gdb-patches@sourceware.org References: <1512640910-26090-1-git-send-email-yao.qi@linaro.org> From: Pedro Alves Message-ID: <04d3d5e3-6c99-d442-055d-b465ad2b7431@redhat.com> Date: Thu, 07 Dec 2017 11:30:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <1512640910-26090-1-git-send-email-yao.qi@linaro.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-12/txt/msg00133.txt.bz2 Hi Yao, Thanks for the fix. This is OK. A couple minor nits below. On 12/07/2017 10:01 AM, Yao Qi wrote: > +#if !defined __ILP32__ > +/* Map the tdesc index to xcr0 mask. */ > +uint64_t idx2mask[X86_TDESC_LAST] = { "static" ? > +/* Map the tdesc index to xcr0 mask. */ > +uint64_t idx2mask[X86_TDESC_LAST] = { "static" ? > + global decimal > + set test "advance through tracing" > + gdb_test_multiple "continue" $test { > + -re "Thread 2 .* hit Catchpoint $decimal \\(call to syscall .*\\).*\r\n$gdb_prompt $" { > + # IPA starts a helper thread, which calls accept. Ignore it. > + send_gdb "continue\n" > + exp_continue > + } (Bah, it's unfortunate that we don't have syntax to make catchpoints be thread specific... ) > + -re "Breakpoint \[0-9\]+, end .*$gdb_prompt $" { You could use $decimal here too. > + pass $test > + } > + } > > gdb_test "tstatus" ".*Trace .*" "check on trace status" Thanks, Pedro Alves