Re: [PATCH] gdb: remove casts to long in dwarf2/loc.c

[Tom de Vries <tdevries@suse.de>]

On 12/4/23 21:40, Simon Marchi wrote:
> I spotted this while reviewing another patch, these casts to long are
> unnecessary.  The result of subtracting two pointers is ptrdiff_t, which
> can be printed with the `t` length specifier.
> 

I'm not sure if it's relevant, but gdb_printf uses 
format_pieces::format_pieces, which supports a number of length 
specififers, but not 't'.

Thanks,
- Tom

> Change-Id: Idf8052b110a61007261be19137e4864ae6b37190
> ---
>   gdb/dwarf2/loc.c | 13 +++++--------
>   1 file changed, 5 insertions(+), 8 deletions(-)
> 
> diff --git a/gdb/dwarf2/loc.c b/gdb/dwarf2/loc.c
> index 5b2d58ab44e4..606c97c745de 100644
> --- a/gdb/dwarf2/loc.c
> +++ b/gdb/dwarf2/loc.c
> @@ -3329,10 +3329,9 @@ disassemble_dwarf_expression (struct ui_file *stream,
>         name = get_DW_OP_name (op);
>   
>         if (!name)
> -	error (_("Unrecognized DWARF opcode 0x%02x at %ld"),
> -	       op, (long) (data - 1 - start));
> -      gdb_printf (stream, "  %*ld: %s", indent + 4,
> -		  (long) (data - 1 - start), name);
> +	error (_("Unrecognized DWARF opcode 0x%02x at %td"), op,
> +	       data - 1 - start);
> +      gdb_printf (stream, "  %*td: %s", indent + 4, data - 1 - start, name);
>   
>         switch (op)
>   	{
> @@ -3515,15 +3514,13 @@ disassemble_dwarf_expression (struct ui_file *stream,
>   	case DW_OP_skip:
>   	  l = extract_signed_integer (data, 2, gdbarch_byte_order (arch));
>   	  data += 2;
> -	  gdb_printf (stream, " to %ld",
> -		      (long) (data + l - start));
> +	  gdb_printf (stream, " to %td", data + l - start);
>   	  break;
>   
>   	case DW_OP_bra:
>   	  l = extract_signed_integer (data, 2, gdbarch_byte_order (arch));
>   	  data += 2;
> -	  gdb_printf (stream, " %ld",
> -		      (long) (data + l - start));
> +	  gdb_printf (stream, " %td", data + l - start);
>   	  break;
>   
>   	case DW_OP_call2:
> 
> base-commit: 9d8fc40eb0e611162844eb7b89f1c76875153fbe